New Upstream Snapshot - eclipse-platform-debug

Ready changes

Summary

Merged new upstream version: 20111011+git20221209.1.7bfd90d (was: 4.26).

Resulting package

Built on 2023-01-22T02:08 (took 13m17s)

The resulting binary packages can be installed (if you have the apt repository enabled) by running one of:

apt install -t fresh-snapshots libeclipse-core-externaltools-javaapt install -t fresh-snapshots libeclipse-core-variables-javaapt install -t fresh-snapshots libeclipse-debug-core-javaapt install -t fresh-snapshots libeclipse-debug-ui-javaapt install -t fresh-snapshots libeclipse-ui-console-javaapt install -t fresh-snapshots libeclipse-ui-externaltools-java

Lintian Result

Diff

diff --git a/.github/dependabot.yml b/.github/dependabot.yml
deleted file mode 100644
index 71607d0..0000000
--- a/.github/dependabot.yml
+++ /dev/null
@@ -1,6 +0,0 @@
-version: 2
-updates:
-- package-ecosystem: github-actions
-  directory: "/"
-  schedule:
-    interval: daily
diff --git a/.github/workflows/verifyFreezePeriod.yml b/.github/workflows/verifyFreezePeriod.yml
deleted file mode 100644
index fed6cc5..0000000
--- a/.github/workflows/verifyFreezePeriod.yml
+++ /dev/null
@@ -1,12 +0,0 @@
-# This workflow calls the Code-Freeze-Period check
-
-name: Check Code Freeze Period
-
-on:
-  pull_request:
-    branches: 
-     - 'master'
-
-jobs:
-  check-freeze-period:
-    uses: eclipse-platform/eclipse.platform.releng.aggregator/.github/workflows/verifyFreezePeriod.yml@master
diff --git a/.gitignore b/.gitignore
deleted file mode 100644
index 6e021b7..0000000
--- a/.gitignore
+++ /dev/null
@@ -1,13 +0,0 @@
-/*/bin/
-/.project
-*~
-*.rej
-*.bak
-javacore.*
-heapdump.*
-core.*
-Snap.*
-
-# maven
-/*/target/
-/target/
diff --git a/debian/changelog b/debian/changelog
index 826879f..19a31b3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+eclipse-platform-debug (20111011+git20221209.1.7bfd90d-1) UNRELEASED; urgency=low
+
+  * New upstream snapshot.
+
+ -- Debian Janitor <janitor@jelmer.uk>  Sun, 22 Jan 2023 02:03:19 -0000
+
 eclipse-platform-debug (4.26-1) unstable; urgency=medium
 
   * New upstream release
diff --git a/org.eclipse.debug.ui.launchview.tests/build.properties b/org.eclipse.debug.ui.launchview.tests/build.properties
index 0cd83c4..7fdf85f 100644
--- a/org.eclipse.debug.ui.launchview.tests/build.properties
+++ b/org.eclipse.debug.ui.launchview.tests/build.properties
@@ -20,3 +20,7 @@ bin.includes = META-INF/,\
                plugin.properties,\
                plugin.xml
 
+# Maven/Tycho pom model adjustments
+pom.model.property.testClass = org.eclipse.debug.ui.launchview.tests.AutomatedSuite
+pom.model.property.tycho.surefire.useUIHarness = true
+pom.model.property.tycho.surefire.useUIThread = true
diff --git a/org.eclipse.debug.ui.launchview.tests/plugin.properties b/org.eclipse.debug.ui.launchview.tests/plugin.properties
index 580ecd8..454cf78 100755
--- a/org.eclipse.debug.ui.launchview.tests/plugin.properties
+++ b/org.eclipse.debug.ui.launchview.tests/plugin.properties
@@ -15,7 +15,3 @@
 pluginName=Debug UI (LaunchView) Test Plugin
 providerName=Eclipse.org
 
-# Maven/Tycho pom model adjustments
-pom.model.property.testClass = org.eclipse.debug.ui.launchview.tests.AutomatedSuite
-pom.model.property.tycho.surefire.useUIHarness = true
-pom.model.property.tycho.surefire.useUIThread = true
diff --git a/org.eclipse.debug.ui/META-INF/MANIFEST.MF b/org.eclipse.debug.ui/META-INF/MANIFEST.MF
index 343c6f0..c56d917 100644
--- a/org.eclipse.debug.ui/META-INF/MANIFEST.MF
+++ b/org.eclipse.debug.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.debug.ui; singleton:=true
-Bundle-Version: 3.17.100.qualifier
+Bundle-Version: 3.17.200.qualifier
 Bundle-Activator: org.eclipse.debug.internal.ui.DebugUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/DebugUIPlugin.java b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/DebugUIPlugin.java
index d90c61a..bb4536b 100644
--- a/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/DebugUIPlugin.java
+++ b/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/DebugUIPlugin.java
@@ -21,8 +21,8 @@ import java.lang.reflect.InvocationTargetException;
 import java.net.MalformedURLException;
 import java.net.URL;
 import java.text.MessageFormat;
-import java.util.HashSet;
 import java.util.Hashtable;
+import java.util.LinkedHashSet;
 import java.util.Set;
 
 import javax.xml.parsers.DocumentBuilder;
@@ -218,7 +218,7 @@ public class DebugUIPlugin extends AbstractUIPlugin implements ILaunchListener,
 	 *
 	 * @since 3.3
 	 */
-	private Set<ISaveParticipant> fSaveParticipants = new HashSet<>();
+	private Set<ISaveParticipant> fSaveParticipants = new LinkedHashSet<>();
 
 	/**
 	 * Theme listener.
@@ -461,7 +461,9 @@ public class DebugUIPlugin extends AbstractUIPlugin implements ILaunchListener,
 
 			DebugElementHelper.dispose();
 
-			fSaveParticipants.clear();
+			synchronized (fSaveParticipants) {
+				fSaveParticipants.clear();
+			}
 
 			ResourcesPlugin.getWorkspace().removeSaveParticipant(getUniqueIdentifier());
 
@@ -485,7 +487,11 @@ public class DebugUIPlugin extends AbstractUIPlugin implements ILaunchListener,
 	 * @since 3.3
 	 */
 	public boolean addSaveParticipant(ISaveParticipant participant) {
-		return fSaveParticipants.add(participant);
+		boolean added;
+		synchronized (fSaveParticipants) {
+			added = fSaveParticipants.add(participant);
+		}
+		return added;
 	}
 
 	/**
@@ -497,7 +503,11 @@ public class DebugUIPlugin extends AbstractUIPlugin implements ILaunchListener,
 	 * @since 3.3
 	 */
 	public boolean removeSaveParticipant(ISaveParticipant participant) {
-		return fSaveParticipants.remove(participant);
+		boolean removed;
+		synchronized (fSaveParticipants) {
+			removed = fSaveParticipants.remove(participant);
+		}
+		return removed;
 	}
 
 	@Override
@@ -506,41 +516,47 @@ public class DebugUIPlugin extends AbstractUIPlugin implements ILaunchListener,
 		Hashtable<String, String> props = new Hashtable<>(2);
 		props.put(org.eclipse.osgi.service.debug.DebugOptions.LISTENER_SYMBOLICNAME, getUniqueIdentifier());
 		context.registerService(DebugOptionsListener.class.getName(), this, props);
-		ResourcesPlugin.getWorkspace().addSaveParticipant(getUniqueIdentifier(),
-				new ISaveParticipant() {
-					@Override
-					public void saving(ISaveContext saveContext) throws CoreException {
-						IEclipsePreferences node = InstanceScope.INSTANCE.getNode(getUniqueIdentifier());
-						if(node != null) {
-							try {
-								node.flush();
-							} catch (BackingStoreException e) {
-								log(e);
-							}
-						}
-				for (ISaveParticipant sp : fSaveParticipants) {
-					sp.saving(saveContext);
-						}
+		class DebugUIPluginSaveParticipant implements ISaveParticipant {
+			@Override
+			public void saving(ISaveContext saveContext) throws CoreException {
+				IEclipsePreferences node = InstanceScope.INSTANCE.getNode(getUniqueIdentifier());
+				if (node != null) {
+					try {
+						node.flush();
+					} catch (BackingStoreException e) {
+						log(e);
 					}
-					@Override
-					public void rollback(ISaveContext saveContext) {
-				for (ISaveParticipant sp : fSaveParticipants) {
+				}
+				Set<ISaveParticipant> saveParticipants = getSaveParticipants();
+				for (ISaveParticipant sp : saveParticipants) {
+					sp.saving(saveContext);
+				}
+			}
+
+			@Override
+			public void rollback(ISaveContext saveContext) {
+				Set<ISaveParticipant> saveParticipants = getSaveParticipants();
+				for (ISaveParticipant sp : saveParticipants) {
 					sp.rollback(saveContext);
-						}
-					}
-					@Override
-					public void prepareToSave(ISaveContext saveContext) throws CoreException {
-				for (ISaveParticipant sp : fSaveParticipants) {
+				}
+			}
+
+			@Override
+			public void prepareToSave(ISaveContext saveContext) throws CoreException {
+				Set<ISaveParticipant> saveParticipants = getSaveParticipants();
+				for (ISaveParticipant sp : saveParticipants) {
 					sp.prepareToSave(saveContext);
-						}
-					}
-					@Override
-					public void doneSaving(ISaveContext saveContext) {
-				for (ISaveParticipant sp : fSaveParticipants) {
+				}
+			}
+
+			@Override
+			public void doneSaving(ISaveContext saveContext) {
+				Set<ISaveParticipant> saveParticipants = getSaveParticipants();
+				for (ISaveParticipant sp : saveParticipants) {
 					sp.doneSaving(saveContext);
-						}
-					}
-				});
+				}
+			}
+		};
 
 		// make sure the perspective manager is created
 		// and be the first debug event listener
@@ -583,6 +599,9 @@ public class DebugUIPlugin extends AbstractUIPlugin implements ILaunchListener,
 					// key-bindings work
 					getLaunchConfigurationManager().getLaunchShortcuts();
 				});
+
+		DebugUIPluginSaveParticipant saveParticipant = new DebugUIPluginSaveParticipant();
+		ResourcesPlugin.getWorkspace().addSaveParticipant(getUniqueIdentifier(), saveParticipant);
 	}
 
 	@Override
@@ -1419,5 +1438,13 @@ public class DebugUIPlugin extends AbstractUIPlugin implements ILaunchListener,
 		}
 		return new EvaluationContext(parent, defaultvar);
 	}
+
+	private Set<ISaveParticipant> getSaveParticipants() {
+		Set<ISaveParticipant> copy = new LinkedHashSet<>();
+		synchronized (fSaveParticipants) {
+			copy.addAll(fSaveParticipants);
+		}
+		return copy;
+	}
 }
 
diff --git a/pom.xml b/pom.xml
index 554b353..654e1c5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -15,7 +15,7 @@
   <parent>
     <groupId>org.eclipse</groupId>
     <artifactId>eclipse-platform-parent</artifactId>
-    <version>4.26.0-SNAPSHOT</version>
+    <version>4.27.0-SNAPSHOT</version>
     <relativePath>../eclipse-platform-parent</relativePath>
   </parent>
 

Debdiff

[The following lists of changes regard files as different if they have different names, permissions or owners.]

Files in second set of .debs but not in first

-rw-r--r--  root/root   /usr/share/java/eclipse-debug-ui-3.17.200.jar
-rw-r--r--  root/root   /usr/share/maven-repo/org/eclipse/debug/org.eclipse.debug.ui/3.17.200/org.eclipse.debug.ui-3.17.200.pom
lrwxrwxrwx  root/root   /usr/lib/eclipse/plugins/org.eclipse.debug.ui_3.17.200.jar -> ../../../share/java/eclipse-debug-ui.jar
lrwxrwxrwx  root/root   /usr/share/java/eclipse-debug-ui.jar -> eclipse-debug-ui-3.17.200.jar
lrwxrwxrwx  root/root   /usr/share/maven-repo/org/eclipse/debug/org.eclipse.debug.ui/3.17.200/org.eclipse.debug.ui-3.17.200.jar -> ../../../../../../java/eclipse-debug-ui-3.17.200.jar
lrwxrwxrwx  root/root   /usr/share/maven-repo/org/eclipse/debug/org.eclipse.debug.ui/debian/org.eclipse.debug.ui-debian.jar -> ../../../../../../java/eclipse-debug-ui-3.17.200.jar

Files in first set of .debs but not in second

-rw-r--r--  root/root   /usr/share/java/eclipse-debug-ui-3.17.100.jar
-rw-r--r--  root/root   /usr/share/maven-repo/org/eclipse/debug/org.eclipse.debug.ui/3.17.100/org.eclipse.debug.ui-3.17.100.pom
lrwxrwxrwx  root/root   /usr/lib/eclipse/plugins/org.eclipse.debug.ui_3.17.100.jar -> ../../../share/java/eclipse-debug-ui.jar
lrwxrwxrwx  root/root   /usr/share/java/eclipse-debug-ui.jar -> eclipse-debug-ui-3.17.100.jar
lrwxrwxrwx  root/root   /usr/share/maven-repo/org/eclipse/debug/org.eclipse.debug.ui/3.17.100/org.eclipse.debug.ui-3.17.100.jar -> ../../../../../../java/eclipse-debug-ui-3.17.100.jar
lrwxrwxrwx  root/root   /usr/share/maven-repo/org/eclipse/debug/org.eclipse.debug.ui/debian/org.eclipse.debug.ui-debian.jar -> ../../../../../../java/eclipse-debug-ui-3.17.100.jar

Control files of package libeclipse-core-externaltools-java: lines which differ (wdiff format)

  • Source: eclipse-platform-debug (4.26-1~jan+control1) (20111011+git20221209.1.7bfd90d-1~jan+nus1)

Control files of package libeclipse-core-variables-java: lines which differ (wdiff format)

  • Source: eclipse-platform-debug (4.26-1~jan+control1) (20111011+git20221209.1.7bfd90d-1~jan+nus1)

Control files of package libeclipse-debug-core-java: lines which differ (wdiff format)

  • Source: eclipse-platform-debug (4.26-1~jan+control1) (20111011+git20221209.1.7bfd90d-1~jan+nus1)

Control files of package libeclipse-debug-ui-java: lines which differ (wdiff format)

  • Source: eclipse-platform-debug (4.26-1~jan+control1) (20111011+git20221209.1.7bfd90d-1~jan+nus1)

Control files of package libeclipse-ui-console-java: lines which differ (wdiff format)

  • Source: eclipse-platform-debug (4.26-1~jan+control1) (20111011+git20221209.1.7bfd90d-1~jan+nus1)

Control files of package libeclipse-ui-externaltools-java: lines which differ (wdiff format)

  • Source: eclipse-platform-debug (4.26-1~jan+control1) (20111011+git20221209.1.7bfd90d-1~jan+nus1)

More details

Full run details