Lintian Fixes - libgdiplus
Recent merge proposals
Ready changes
Summary
- Trim trailing whitespace. ( trailing-whitespace )
- Use secure URI in Homepage field. ( homepage-field-uses-insecure-uri )
- Bump debhelper from deprecated 7 to 13. ( package-uses-deprecated-debhelper-compat-version )
- Set debhelper-compat version in Build-Depends. ( uses-debhelper-compat-file )
- Set upstream metadata fields: Bug-Database, Bug-Submit (from ./configure), Name (from ./configure), Repository-Browse. ( upstream-metadata-file-is-missing , upstream-metadata-missing-bug-tracking )
- Drop unnecessary dependency on dh-autoreconf. ( useless-autoreconf-build-depends )
- Add patch ac-path-pkgconfig.patch: Use cross-build compatible macro for finding pkg-config. ( autotools-pkg-config-macro-not-cross-compilation-safe )
Failed fixers:
See the worker log for details.
Diff
diff --git a/debian/changelog b/debian/changelog
index 7946daf..f641c3b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -53,15 +53,15 @@ libgdiplus (3.6-1) unstable; urgency=medium
libgdiplus (2.11+git20131008.9732566-5) unstable; urgency=low
- * [5e251c5] Ensure PNG transparency values are initialized. Thanks to
+ * [5e251c5] Ensure PNG transparency values are initialized. Thanks to
Tom Hindle (LP: #1296786) (Closes: #741980)
-- Jo Shields <directhex@apebox.org> Mon, 31 Mar 2014 19:02:03 +0100
libgdiplus (2.11+git20131008.9732566-4) unstable; urgency=low
- * [01b42b2] Add debian/patches/use_freetype_macros.patch,
- cherry-picked from upstream 180c02e0f2a2016eba8520b456ca929e9dcf03db,
+ * [01b42b2] Add debian/patches/use_freetype_macros.patch,
+ cherry-picked from upstream 180c02e0f2a2016eba8520b456ca929e9dcf03db,
as a workaround to the FTBFS on FreeType 2.5+ (Closes: #732274)
-- Jo Shields <directhex@apebox.org> Mon, 16 Dec 2013 14:21:47 +0000
@@ -74,18 +74,18 @@ libgdiplus (2.11+git20131008.9732566-3) unstable; urgency=low
libgdiplus (2.11+git20131008.9732566-2) unstable; urgency=low
- * [ecab77d] Refresh list of target architectures, to aid removal
+ * [ecab77d] Refresh list of target architectures, to aid removal
of arches which Mono no longer supports (Closes: #727591)
-- Jo Shields <directhex@apebox.org> Thu, 24 Oct 2013 14:14:10 +0100
libgdiplus (2.11+git20131008.9732566-1) unstable; urgency=low
- * [285d0a3] Imported Upstream version 2.11+git20131008.9732566
+ * [285d0a3] Imported Upstream version 2.11+git20131008.9732566
(Closes: #649946)
- * [b7b1355] Build-depends on libtiff5-dev | libtiff-dev, change
+ * [b7b1355] Build-depends on libtiff5-dev | libtiff-dev, change
from libtiff4-dev (Closes #681132)
- * [fea5c93] Build-Depends on libpng-dev, change from libpng12-dev
+ * [fea5c93] Build-Depends on libpng-dev, change from libpng12-dev
(Closes: #662402)
-- Jo Shields <directhex@apebox.org> Thu, 10 Oct 2013 11:31:26 +0200
@@ -93,11 +93,11 @@ libgdiplus (2.11+git20131008.9732566-1) unstable; urgency=low
libgdiplus (2.10-3) unstable; urgency=low
[ Iain Lane ]
- * [9ee065e] Change BD on libjpeg62-dev to libjpeg-dev, as part of the
+ * [9ee065e] Change BD on libjpeg62-dev to libjpeg-dev, as part of the
transition (Closes: #634138)
[ Jo Shields ]
- * [6dc8f99] Replace s390 architecture with s390x, since s390 is no longer
+ * [6dc8f99] Replace s390 architecture with s390x, since s390 is no longer
in Mono.
-- Jo Shields <directhex@apebox.org> Wed, 18 Jan 2012 00:49:22 +0000
@@ -129,8 +129,8 @@ libgdiplus (2.6.7-3) unstable; urgency=low
libgdiplus (2.6.7-2) experimental; urgency=high
- * SECURITY UPDATE: Import upstream commit fa0e3a1d516166c341d5, which
- closes integer overflows in BMP, JPEG and TIFF handling.
+ * SECURITY UPDATE: Import upstream commit fa0e3a1d516166c341d5, which
+ closes integer overflows in BMP, JPEG and TIFF handling.
(Closes: #594155) (CVE-2010-1526)
-- Jo Shields <directhex@apebox.org> Wed, 25 Aug 2010 08:51:05 +0100
@@ -149,8 +149,8 @@ libgdiplus (2.6.7-1) experimental; urgency=low
libgdiplus (2.6.4-2) experimental; urgency=low
* git:upstream-2.6.4/debian/patches/libpng_1.4_compatibility_version_check_fix:
- + Change version number check on libpng in src/pngcodec.c to >1.3.99,
- rather than >1.2.43, as security releases on the 1.2 branch should be
+ + Change version number check on libpng in src/pngcodec.c to >1.3.99,
+ rather than >1.2.43, as security releases on the 1.2 branch should be
treated in the old way, not the new 1.4-branch-way.
-- Jo Shields <directhex@apebox.org> Fri, 02 Jul 2010 14:43:49 +0100
@@ -536,9 +536,9 @@ libgdiplus (0.1-2) unstable; urgency=low
* Dave Beckett:
+ Build-Dep on libcairo1-dev, libglib2.0-dev (>= 2.2.3), libmono-dev
- + Fixed libgdiplus.pc to use the correct cairo versioned dependency.
+ + Fixed libgdiplus.pc to use the correct cairo versioned dependency.
* Eduard Bloch:
- + Changes to the fixes above to relax the mono version dependency and
+ + Changes to the fixes above to relax the mono version dependency and
not use Sed
-- Dave Beckett <Dave.Beckett@bristol.ac.uk> Mon, 16 Feb 2004 23:53:54 +0000
@@ -548,4 +548,3 @@ libgdiplus (0.1-1) unstable; urgency=low
* Initial Release (closes: #230896)
-- Eduard Bloch <blade@debian.org> Sat, 7 Feb 2004 22:37:11 +0100
-
diff --git a/debian/compat b/debian/compat
deleted file mode 100644
index 7f8f011..0000000
--- a/debian/compat
+++ /dev/null
@@ -1 +0,0 @@
-7
diff --git a/debian/control b/debian/control
index 337aab0..0345ce1 100644
--- a/debian/control
+++ b/debian/control
@@ -3,24 +3,23 @@ Section: libs
Priority: optional
Maintainer: Debian Mono Group <pkg-mono-group@lists.alioth.debian.org>
Uploaders: Mirco Bauer <meebey@debian.org>, Sebastian Dröge <slomo@debian.org>, Jo Shields <directhex@apebox.org>
-Build-Depends:
- debhelper (>= 7.0.50~),
- libglib2.0-dev (>= 2.2.3),
- libx11-dev,
- libxt-dev,
- libfontconfig1-dev,
- libfreetype6-dev,
- libxft-dev (>= 2.0),
- libpng-dev,
- libjpeg-dev,
- libtiff5-dev | libtiff-dev,
- libgif-dev,
- libexif-dev,
+Build-Depends:
+ debhelper-compat (= 13),
+ libglib2.0-dev (>= 2.2.3),
+ libx11-dev,
+ libxt-dev,
+ libfontconfig1-dev,
+ libfreetype6-dev,
+ libxft-dev (>= 2.0),
+ libpng-dev,
+ libjpeg-dev,
+ libtiff5-dev | libtiff-dev,
+ libgif-dev,
+ libexif-dev,
libcairo2-dev (>= 1.4),
- libpango1.0-dev,
- dh-autoreconf
+ libpango1.0-dev
Standards-Version: 3.9.1
-Homepage: http://www.mono-project.com/Libgdiplus
+Homepage: https://www.mono-project.com/Libgdiplus
Vcs-Git: https://salsa.debian.org/dotnet-team/libgdiplus.git
Vcs-Browser: https://salsa.debian.org/dotnet-team/libgdiplus
diff --git a/debian/patches/ac-path-pkgconfig.patch b/debian/patches/ac-path-pkgconfig.patch
new file mode 100644
index 0000000..c40c0b1
--- /dev/null
+++ b/debian/patches/ac-path-pkgconfig.patch
@@ -0,0 +1,24 @@
+Description: Use cross-build compatible macro for finding pkg-config.
+ .
+ The package uses AC_PATH_PROG to discover the location of pkg-config(1). This
+ macro fails to select the correct version to support cross-compilation.
+ .
+ This patch changes it to use AC_PATH_TOOL.
+ .
+ Refer to https://bugs.debian.org/884798 for details.
+Origin: other
+Last-Update: 2023-02-25
+
+=== modified file 'configure.ac'
+--- a/configure.ac 2022-04-22 16:30:41 +0000
++++ b/configure.ac 2023-02-25 14:22:57 +0000
+@@ -16,7 +16,7 @@
+
+ AC_C_BIGENDIAN
+
+-AC_PATH_PROG(PKG_CONFIG, pkg-config, no)
++AC_PATH_TOOL(PKG_CONFIG, pkg-config, no)
+ if test "x$PKG_CONFIG" = "xno"; then
+ AC_MSG_ERROR([You need to install pkg-config])
+ fi
+
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..cb99cc8
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+ac-path-pkgconfig.patch
diff --git a/debian/rules b/debian/rules
index caa17c8..6bb1c2e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -80,4 +80,4 @@ override_dh_auto_clean:
%:
- dh $@ --with autoreconf
+ dh $@
diff --git a/debian/upstream/metadata b/debian/upstream/metadata
new file mode 100644
index 0000000..682c14f
--- /dev/null
+++ b/debian/upstream/metadata
@@ -0,0 +1,5 @@
+---
+Name: libgdiplus
+Bug-Database: https://github.com/mono/mono/issues
+Bug-Submit: https://github.com/mono/mono/issues/new
+Repository-Browse: https://github.com/mono/mono
Debdiff
[The following lists of changes regard files as different if they have different names, permissions or owners.]
Files in second set of .debs but not in first
-rw-r--r-- root/root /usr/lib/debug/.build-id/c5/ac74533d65c77e74bcc3f20f257a70d2f5b801.debug
Files in first set of .debs but not in second
-rw-r--r-- root/root /usr/lib/debug/.build-id/c6/5910821c82ec3ff7b94bcccb7fde2f98dda870.debug
Control files of package libgdiplus: lines which differ (wdiff format)
Depends: libc6 (>= 2.29), libcairo2 (>= 1.10.0), libexif12 (>= 0.6.21-1~), libfontconfig1 (>= 2.12.6), libgif7 (>= 5.1), libglib2.0-0 (>= 2.31.8), libharfbuzz0b (>= 2.6.0), libjpeg62-turbo (>= 1.3.1), libpango-1.0-0 (>= 1.44.3), libpangocairo-1.0-0 (>= 1.18.0), libpng16-16 (>= 1.6.2-1), libtiff5 libtiff6 (>= 4.0.3), libx11-6
Homepage: http://www.mono-project.com/Libgdiplus https://www.mono-project.com/Libgdiplus
Control files of package libgdiplus-dbgsym: lines which differ (wdiff format)
Build-Ids: c65910821c82ec3ff7b94bcccb7fde2f98dda870 c5ac74533d65c77e74bcc3f20f257a70d2f5b801