Lintian Fixes - liblastfm

Ready changes

Merge these changes:

git pull https://janitor.debian.net/git/liblastfm lintian-fixes

Summary

Diff

=== modified file 'debian/changelog'
--- a/debian/changelog	2015-12-11 17:41:33 +0000
+++ b/debian/changelog	2020-04-28 19:47:05 +0000
@@ -1,3 +1,21 @@
+liblastfm (1.0.9-2) UNRELEASED; urgency=medium
+
+  * Trim trailing whitespace.
+  * Use secure copyright file specification URI.
+  * debian/copyright: use spaces rather than tabs to start continuation
+    lines.
+  * Transition to automatic debug packages (from: liblastfm5-dbg,
+    liblastfm-dbg, liblastfm-fingerprint1-dbg, liblastfm-fingerprint5-
+    dbg).
+  * Bump debhelper from deprecated 9 to 12.
+  * Set debhelper-compat version in Build-Depends.
+  * Set upstream metadata fields: Bug-Database, Bug-Submit, Repository,
+    Repository-Browse.
+  * Use secure URI in Vcs control header Vcs-Git.
+  * Drop unnecessary dh arguments: --parallel
+
+ -- Debian Janitor <janitor@jelmer.uk>  Tue, 28 Apr 2020 19:41:05 +0000
+
 liblastfm (1.0.9-1) unstable; urgency=low
 
   * New upstream release. (Closes: #805081)
@@ -8,7 +26,7 @@
   * debian/control:
     - Standards-Version: 3.9.6
   * update debian/copyright
-  * Remove patch applied upstream: 
+  * Remove patch applied upstream:
     - fix_q_os_x11.patch
   * Add patch:
     - change_target-name.patch

=== removed file 'debian/compat'
--- a/debian/compat	2012-07-21 21:16:56 +0000
+++ b/debian/compat	1970-01-01 00:00:00 +0000
@@ -1,1 +0,0 @@
-9

=== modified file 'debian/control'
--- a/debian/control	2015-12-11 17:41:33 +0000
+++ b/debian/control	2020-04-28 19:46:27 +0000
@@ -3,7 +3,7 @@
 Maintainer: Stefan Ahlers <stef.ahlers@t-online.de>
 Build-Depends:
  cmake,
- debhelper (>= 9),
+ debhelper-compat (= 12),
  libfftw3-dev,
  libqt4-dev,
  qtbase5-dev,
@@ -12,7 +12,7 @@
 Standards-Version: 3.9.6
 Section: libs
 Homepage: http://www.last.fm/
-Vcs-Git: git://github.com/justin-time/liblastfm.git
+Vcs-Git: https://github.com/justin-time/liblastfm.git
 Vcs-Browser: https://github.com/justin-time/liblastfm
 
 Package: liblastfm-dev
@@ -58,21 +58,6 @@
  This library lets you fingerprint decoded audio tracks and fetch metadata
  suggestions for them.
 
-Package: liblastfm-dbg
-Architecture: any
-Multi-Arch: same
-Section: debug
-Priority: extra
-Depends:
- liblastfm-fingerprint1 (= ${binary:Version}),
- liblastfm1 (= ${binary:Version}),
- ${misc:Depends}
-Description: Debugging symbols for the Last.fm web services library (Qt4 build)
- liblastfm is a collection of C++/Qt4 libraries provided by Last.fm for use
- with their web services.
- .
- This package contains the debugging symbols for the liblastfm libraries.
-
 Package: liblastfm-fingerprint5-1
 Architecture: any
 Multi-Arch: same
@@ -112,47 +97,3 @@
  with their web services.
  .
  This package contains the base web services library.
-
-Package: liblastfm5-dbg
-Architecture: any
-Multi-Arch: same
-Section: debug
-Priority: extra
-Depends:
- liblastfm5-1 (= ${binary:Version}),
- ${misc:Depends}
-Description: Debugging symbols for the Last.fm web services library (Qt5 build)
- liblastfm is a collection of C++/Qt5 libraries provided by Last.fm for use
- with their web services.
- .
- This package contains the debugging symbols for the liblastfm libraries.
- 
-Package: liblastfm-fingerprint1-dbg
-Architecture: any
-Multi-Arch: same
-Section: debug
-Priority: extra
-Depends:
- liblastfm5-1 (= ${binary:Version}),
- ${misc:Depends}
-Description: Debugging symbols for the fingerprint library (Qt4 build)
- liblastfm is a collection of C++/Qt4 libraries provided by Last.fm for use
- with their web services.
- .
- This package contains the debugging symbols for the liblastfm-fingerprint
- libraries.
- 
-Package: liblastfm-fingerprint5-dbg
-Architecture: any
-Multi-Arch: same
-Section: debug
-Priority: extra
-Depends:
- liblastfm5-1 (= ${binary:Version}),
- ${misc:Depends}
-Description: Debugging symbols for the fingerprint library (Qt5 build)
- liblastfm is a collection of C++/Qt5 libraries provided by Last.fm for use
- with their web services.
- .
- This package contains the debugging symbols for the liblastfm-fingerprint
- libraries.

=== modified file 'debian/copyright'
--- a/debian/copyright	2015-12-11 17:41:33 +0000
+++ b/debian/copyright	2020-04-28 19:42:42 +0000
@@ -1,4 +1,4 @@
-Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
+Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
 Upstream-Name: liblastfm
 Upstream-Contact: Michael Coffey <michaelc@last.fm>
 Source: https://github.com/lastfm/liblastfm
@@ -9,7 +9,7 @@
 
 Files: debian/*
 Copyright: 2012-2014 John Stamp <jstamp@mehercule.net>
-	   2015	Stefan Ahlers <stef.ahlers@t-online.de>
+           2015	Stefan Ahlers <stef.ahlers@t-online.de>
 License: GPL-3+
 
 Files: demos/*

=== modified file 'debian/rules'
--- a/debian/rules	2015-12-11 17:41:33 +0000
+++ b/debian/rules	2020-04-28 19:47:05 +0000
@@ -9,7 +9,7 @@
 include /usr/share/pkg-kde-tools/makefiles/1/variables.mk
 
 %:
-	dh $@ --parallel --with pkgkde_symbolshelper
+	dh $@ --with pkgkde_symbolshelper
 
 override_dh_auto_configure:
 	mkdir -p $(QT4_PATH) $(QT5_PATH)
@@ -18,7 +18,7 @@
 	# Qt4 builds
 	QT_SELECT=qt4 dh_auto_configure -B$(QT4_PATH) -- -DBUILD_FINGERPRINT=TRUE -DBUILD_TESTS=FALSE $(DEB_CMAKE_CUSTOM_FLAGS) -DBUILD_WITH_QT4=ON
 
-	# Qt5 builds 
+	# Qt5 builds
 	QT_SELECT=qt5 dh_auto_configure -B$(QT5_PATH) -- -DBUILD_FINGERPRINT=TRUE -DBUILD_TESTS=FALSE $(DEB_CMAKE_CUSTOM_FLAGS)
 
 override_dh_auto_build:
@@ -40,10 +40,7 @@
 	dh_auto_install -B$(QT5_PATH)
 
 override_dh_strip:
-	dh_strip -pliblastfm1 --dbg-package=liblastfm-dbg
-	dh_strip -pliblastfm5-1 --dbg-package=liblastfm5-dbg
-	dh_strip -pliblastfm-fingerprint1 --dbg-package=liblastfm-fingerprint1-dbg
-	dh_strip -pliblastfm-fingerprint5-1 --dbg-package=liblastfm-fingerprint5-dbg
-
-override_dh_install:
-	dh_install --list-missing
+	dh_strip -pliblastfm1 --dbgsym-migration='liblastfm-dbg (<< 1.0.9-2~)'
+	dh_strip -pliblastfm5-1 --dbgsym-migration='liblastfm5-dbg (<< 1.0.9-2~)'
+	dh_strip -pliblastfm-fingerprint1 --dbgsym-migration='liblastfm-fingerprint1-dbg (<< 1.0.9-2~)'
+	dh_strip -pliblastfm-fingerprint5-1 --dbgsym-migration='liblastfm-fingerprint5-dbg (<< 1.0.9-2~)'

=== added directory 'debian/upstream'
=== added file 'debian/upstream/metadata'
--- a/debian/upstream/metadata	1970-01-01 00:00:00 +0000
+++ b/debian/upstream/metadata	2020-04-28 19:45:43 +0000
@@ -0,0 +1,4 @@
+Bug-Database: https://github.com/lastfm/liblastfm/issues
+Bug-Submit: https://github.com/lastfm/liblastfm/issues/new
+Repository: https://github.com/lastfm/liblastfm.git
+Repository-Browse: https://github.com/lastfm/liblastfm

Debdiff

[The following lists of changes regard files as different if they have different names, permissions or owners.]

Files in second set of .debs but not in first

-rw-r--r--  root/root   /usr/lib/debug/.build-id/44/6187dae918327cfddecafdadb8c735b7d18181.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/4d/d31b1301c59795a93a221069f24518466b141b.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/7b/f531104a11d438019259123da1668f9b2c8e06.debug
lrwxrwxrwx  root/root   /usr/share/doc/liblastfm-fingerprint1-dbgsym -> liblastfm-fingerprint1
lrwxrwxrwx  root/root   /usr/share/doc/liblastfm-fingerprint5-1-dbgsym -> liblastfm-fingerprint5-1
lrwxrwxrwx  root/root   /usr/share/doc/liblastfm1-dbgsym -> liblastfm1
lrwxrwxrwx  root/root   /usr/share/doc/liblastfm5-1-dbgsym -> liblastfm5-1

Files in first set of .debs but not in second

-rw-r--r--  root/root   /usr/lib/debug/.build-id/46/4edaa6c5d627268d3f4b6aaa0f8b4608b533d2.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/6e/34ed2790df45d6e70b0111713180e358f6c2ed.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/ce/495354afc17089f466d1f004c4097f6008a52f.debug
-rw-r--r--  root/root   /usr/share/doc/liblastfm-dbg/changelog.Debian.gz
-rw-r--r--  root/root   /usr/share/doc/liblastfm-dbg/copyright
-rw-r--r--  root/root   /usr/share/doc/liblastfm-fingerprint1-dbg/changelog.Debian.gz
-rw-r--r--  root/root   /usr/share/doc/liblastfm-fingerprint1-dbg/copyright
-rw-r--r--  root/root   /usr/share/doc/liblastfm-fingerprint5-dbg/changelog.Debian.gz
-rw-r--r--  root/root   /usr/share/doc/liblastfm-fingerprint5-dbg/copyright
-rw-r--r--  root/root   /usr/share/doc/liblastfm5-dbg/changelog.Debian.gz
-rw-r--r--  root/root   /usr/share/doc/liblastfm5-dbg/copyright

No differences were encountered between the control files of package liblastfm-dev

No differences were encountered between the control files of package liblastfm-fingerprint1

No differences were encountered between the control files of package liblastfm-fingerprint5-1

No differences were encountered between the control files of package liblastfm1

No differences were encountered between the control files of package liblastfm5-1

No differences were encountered between the control files of package liblastfm5-dev

Run locally

Try this locally (using the lintian-brush package):

debcheckout liblastfm
cd liblastfm
lintian-brush

More details

Full run details