New Upstream Release - golang-inet-netstack
Ready changes
Summary
Merged new upstream version: 0.0~git20220214.7585b01 (was: 0.0~git20211120.8aa80cf2).
Diff
diff --git a/README.md b/README.md
index 1373ab4d..4ef5c079 100644
--- a/README.md
+++ b/README.md
@@ -1,18 +1,25 @@
# netstack
-This is a "fork" of https://github.com/google/gvisor, extracting out
+This was a "fork" of https://github.com/google/gvisor, extracting out
just the "netstack" networking bits, which previously were
self-contained at https://github.com/google/netstack.
+## UPDATE
+
+This repo is no longer maintained. As of Go 1.17 and its [lazy module
+loading](https://go.dev/ref/mod#lazy-loading) we no longer need it, so we now
+just use upstream gVisor directly.
+
## Why?
Because [gVisor's `go.mod` is gigantic](https://github.com/google/gvisor/blob/go/go.mod)
and causes problems to people trying to use it as a library.
-Arguably Go's tooling is also somewhat to blame:
-Go doesn't make it easy (or even possible) to use a subset (a few
-packages) out of a mega module like gVisor without getting impacted
-by otherwise-unrelated requirements of that dependent module.
+Arguably Go's tooling is also somewhat to blame: Go doesn't make it
+easy (or even possible) to use a subset (a few packages) out of a mega
+module like gVisor without getting impacted by otherwise-unrelated
+requirements of that dependent module. (Update: as of Go 1.17, this
+appears to be fixed; see UPDATE above)
Specifically, [Tailscale](https://github.com/tailscale/tailscale)
wanted to use gVisor's `tcpip` networking packages, which worked fine for a
diff --git a/debian/changelog b/debian/changelog
index 83e2e4ba..8a79341f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+golang-inet-netstack (0.0~git20220214.7585b01-1) UNRELEASED; urgency=low
+
+ * New upstream snapshot.
+ * Drop patch allow-go-119, present upstream.
+
+ -- Debian Janitor <janitor@jelmer.uk> Thu, 22 Jun 2023 04:29:19 -0000
+
golang-inet-netstack (0.0~git20211120.8aa80cf2-6) unstable; urgency=medium
* Allow building on go 1.19. Closes: #1017246.
diff --git a/debian/patches/allow-go-119 b/debian/patches/allow-go-119
deleted file mode 100644
index e60787ce..00000000
--- a/debian/patches/allow-go-119
+++ /dev/null
@@ -1,74 +0,0 @@
-Description: Allow go 1.19
- Old rules prevented it, but it works fine.
- .
- golang-inet-netstack (0.0~git20211120.8aa80cf2-6) unstable; urgency=medium
- .
- * Allow building on go 1.19. Closes: #1017246.
-Author: John Goerzen <jgoerzen@complete.org>
-Bug-Debian: https://bugs.debian.org/1017246
-
----
-The information above should follow the Patch Tagging Guidelines, please
-checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
-are templates for supplementary fields that you might want to add:
-
-Origin: <vendor|upstream|other>, <url of original patch>
-Bug: <url in upstream bugtracker>
-Bug-Debian: https://bugs.debian.org/<bugnumber>
-Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
-Forwarded: <no|not-needed|url proving that it has been forwarded>
-Reviewed-By: <name and email of someone who approved the patch>
-Last-Update: 2022-09-09
-
---- golang-inet-netstack-0.0~git20211120.8aa80cf2.orig/gohacks/gohacks_unsafe.go
-+++ golang-inet-netstack-0.0~git20211120.8aa80cf2/gohacks/gohacks_unsafe.go
-@@ -12,8 +12,8 @@
- // See the License for the specific language governing permissions and
- // limitations under the License.
-
--//go:build go1.13 && !go1.19
--// +build go1.13,!go1.19
-+//go:build go1.13
-+// +build go1.13
-
- // //go:linkname directives type-checked by checklinkname. Any other
- // non-linkname assumptions outside the Go 1 compatibility guarantee should
---- golang-inet-netstack-0.0~git20211120.8aa80cf2.orig/goid/goid.go
-+++ golang-inet-netstack-0.0~git20211120.8aa80cf2/goid/goid.go
-@@ -12,8 +12,8 @@
- // See the License for the specific language governing permissions and
- // limitations under the License.
-
--//go:build go1.12 && !go1.19
--// +build go1.12,!go1.19
-+//go:build go1.12
-+// +build go1.12
-
- // Check type signatures when updating Go version.
-
---- golang-inet-netstack-0.0~git20211120.8aa80cf2.orig/sync/mutex_unsafe.go
-+++ golang-inet-netstack-0.0~git20211120.8aa80cf2/sync/mutex_unsafe.go
-@@ -3,8 +3,8 @@
- // Use of this source code is governed by a BSD-style
- // license that can be found in the LICENSE file.
-
--//go:build go1.13 && !go1.19
--// +build go1.13,!go1.19
-+//go:build go1.13
-+// +build go1.13
-
- // When updating the build constraint (above), check that syncMutex matches the
- // standard library sync.Mutex definition.
---- golang-inet-netstack-0.0~git20211120.8aa80cf2.orig/sync/runtime_unsafe.go
-+++ golang-inet-netstack-0.0~git20211120.8aa80cf2/sync/runtime_unsafe.go
-@@ -3,8 +3,8 @@
- // Use of this source code is governed by a BSD-style
- // license that can be found in the LICENSE file.
-
--//go:build go1.13 && !go1.19
--// +build go1.13,!go1.19
-+//go:build go1.13
-+// +build go1.13
-
- // //go:linkname directives type-checked by checklinkname. Any other
- // non-linkname assumptions outside the Go 1 compatibility guarantee should
diff --git a/debian/patches/series b/debian/patches/series
index ddc69c0c..e69de29b 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +0,0 @@
-allow-go-119
More details
Historical runs
- unexpected-local-upstream-changes: Tree has local changes: ['golang-inet-netstack-0.0~git20220214.7585b01/sync/runtime_unsafe.go', 'golang-inet-netstack-0.0~git20220214.7585b01/sync/mutex_unsafe.go', 'golang-inet-netstack-0.0~git20220214.7585b01/goid/goid.go', 'golang-inet-netstack-0.0~git20220214.7585b01/gohacks/gohacks_unsafe.go']
- unexpected-local-upstream-changes: Tree has local changes: ['golang-inet-netstack-0.0~git20220214.7585b01/sync/runtime_unsafe.go', 'golang-inet-netstack-0.0~git20220214.7585b01/sync/mutex_unsafe.go', 'golang-inet-netstack-0.0~git20220214.7585b01/goid/goid.go', 'golang-inet-netstack-0.0~git20220214.7585b01/gohacks/gohacks_unsafe.go']
- unexpected-local-upstream-changes: Tree has local changes: ['golang-inet-netstack-0.0~git20220214.7585b01/sync/runtime_unsafe.go', 'golang-inet-netstack-0.0~git20220214.7585b01/sync/mutex_unsafe.go', 'golang-inet-netstack-0.0~git20220214.7585b01/goid/goid.go', 'golang-inet-netstack-0.0~git20220214.7585b01/gohacks/gohacks_unsafe.go']
- unexpected-local-upstream-changes: Tree has local changes: ['golang-inet-netstack-0.0~git20220214.7585b01/sync/runtime_unsafe.go', 'golang-inet-netstack-0.0~git20220214.7585b01/sync/mutex_unsafe.go', 'golang-inet-netstack-0.0~git20220214.7585b01/goid/goid.go', 'golang-inet-netstack-0.0~git20220214.7585b01/gohacks/gohacks_unsafe.go']
- push-failed: Failed to push result branch: Connection closed: Connection closed early The remote server unexpectedly closed the connection.
- push-failed: Failed to push result branch: Connection closed: Connection closed early The remote server unexpectedly closed the connection.
- unexpected-local-upstream-changes: Tree has local changes: ['golang-inet-netstack-0.0~git20220214.7585b01/sync/runtime_unsafe.go', 'golang-inet-netstack-0.0~git20220214.7585b01/sync/mutex_unsafe.go', 'golang-inet-netstack-0.0~git20220214.7585b01/goid/goid.go', 'golang-inet-netstack-0.0~git20220214.7585b01/gohacks/gohacks_unsafe.go']
- unexpected-local-upstream-changes: Tree has local changes: ['golang-inet-netstack-0.0~git20220214.7585b01/sync/runtime_unsafe.go', 'golang-inet-netstack-0.0~git20220214.7585b01/sync/mutex_unsafe.go', 'golang-inet-netstack-0.0~git20220214.7585b01/goid/goid.go', 'golang-inet-netstack-0.0~git20220214.7585b01/gohacks/gohacks_unsafe.go']
- result-push-failed: Failed to push result branch: Connection closed: Connection closed early The remote server unexpectedly closed the connection.
- result-push-failed: Failed to push result branch: Connection closed: Connection closed early The remote server unexpectedly closed the connection.
- result-push-failed: Failed to push result branch: Connection closed: Connection closed early The remote server unexpectedly closed the connection.
- result-push-failed: Failed to push result branch: Connection closed: Connection closed early The remote server unexpectedly closed the connection.
- result-push-failed: Failed to push result branch: Connection closed: Connection closed early The remote server unexpectedly closed the connection.
- result-push-failed: Failed to push result branch: Connection closed: Connection closed early The remote server unexpectedly closed the connection.
- worker-timeout: No keepalives received in 1:00:09.970022.
- worker-timeout: No keepalives received in 1:00:10.753480.
- run-disappeared: Worker started processing new run rather than 4a0ff52f-8152-4d65-ba07-043ce45725e2
- run-disappeared: Worker started processing new run rather than e5701ddd-2535-4935-8e86-dcb87c9e42ef
- run-disappeared: Worker started processing new run rather than 05fd6de4-c282-4c80-8668-5ee91e675070
- worker-timeout: No keepalives received in 1:00:10.064478.
- run-disappeared: Jenkins job https://jenkins.debian.net/job/janitor-worker/758155/ has disappeared
- worker-clone-incomplete-read: IncompleteRead(0 bytes read)
- build-failed-stage-explain-bd-uninstallable: build failed stage explain-bd-uninstallable
- build-failed-stage-explain-bd-uninstallable: build failed stage explain-bd-uninstallable
- success: Merged new upstream version 0.0~git20220214.7585b01
- success: Merged new upstream version 0.0~git20220214.7585b01