Commit 50a5dd49588aa2c69df81655543ae91d6921a0b1 - async-http-client

+1

-1

bom/pom.xml less more

4	4	<parent>
5	5	<groupId>org.asynchttpclient</groupId>
6	6	<artifactId>async-http-client-project</artifactId>
7		<version>2.12.2</version>
	7	<version>2.12.3</version>
8	8	</parent>
9	9
10	10	<artifactId>async-http-client-bom</artifactId>

+1

-1

client/pom.xml less more

1	1	<parent>
2	2	<groupId>org.asynchttpclient</groupId>
3	3	<artifactId>async-http-client-project</artifactId>
4		<version>2.12.2</version>
	4	<version>2.12.3</version>
5	5	</parent>
6	6	<modelVersion>4.0.0</modelVersion>
7	7	<artifactId>async-http-client</artifactId>

+3

-2

client/src/main/java/org/asynchttpclient/netty/handler/intercept/Redirect30xInterceptor.java less more

37	37
38	38	import static io.netty.handler.codec.http.HttpHeaderNames.*;
39	39	import static org.asynchttpclient.util.HttpConstants.Methods.GET;
	40	import static org.asynchttpclient.util.HttpConstants.Methods.HEAD;
	41	import static org.asynchttpclient.util.HttpConstants.Methods.OPTIONS;
40	42	import static org.asynchttpclient.util.HttpConstants.ResponseStatusCodes.*;
41	43	import static org.asynchttpclient.util.HttpUtils.followRedirect;
42	44	import static org.asynchttpclient.util.MiscUtils.isNonEmpty;

86	88
87	89	String originalMethod = request.getMethod();
88	90	boolean switchToGet = !originalMethod.equals(GET)
89		&& (statusCode == MOVED_PERMANENTLY_301 \|\| statusCode == SEE_OTHER_303 \|\| (statusCode == FOUND_302 && !config.isStrict302Handling()));
	91	&& !originalMethod.equals(OPTIONS) && !originalMethod.equals(HEAD) && (statusCode == MOVED_PERMANENTLY_301 \|\| statusCode == SEE_OTHER_303 \|\| (statusCode == FOUND_302 && !config.isStrict302Handling()));
90	92	boolean keepBody = statusCode == TEMPORARY_REDIRECT_307 \|\| statusCode == PERMANENT_REDIRECT_308 \|\| (statusCode == FOUND_302 && config.isStrict302Handling());
91	93
92	94	final RequestBuilder requestBuilder = new RequestBuilder(switchToGet ? GET : originalMethod)

125	127	HttpHeaders responseHeaders = response.headers();
126	128	String location = responseHeaders.get(LOCATION);
127	129	Uri newUri = Uri.create(future.getUri(), location);
128
129	130	LOGGER.debug("Redirecting to {}", newUri);
130	131
131	132	CookieStore cookieStore = config.getCookieStore();

+1

-0

client/src/main/java/org/asynchttpclient/netty/request/NettyRequestFactory.java less more

139	139	if (connect) {
140	140	// assign proxy-auth as configured on request
141	141	headers.set(PROXY_AUTHORIZATION, request.getHeaders().getAll(PROXY_AUTHORIZATION));
	142	headers.set(USER_AGENT, request.getHeaders().getAll(USER_AGENT));
142	143
143	144	} else {
144	145	// assign headers as configured on request

+7

-1

client/src/main/java/org/asynchttpclient/netty/request/NettyRequestSender.java less more

274	274
275	275	// some headers are only set when performing the first request
276	276	HttpHeaders headers = future.getNettyRequest().getHttpRequest().headers();
	277	if(proxy != null && proxy.getCustomHeaders() != null ) {
	278	HttpHeaders customHeaders = proxy.getCustomHeaders().apply(request);
	279	if(customHeaders != null) {
	280	headers.add(customHeaders);
	281	}
	282	}
277	283	Realm realm = future.getRealm();
278	284	Realm proxyRealm = future.getProxyRealm();
279	285	requestFactory.addAuthorizationHeader(headers, perConnectionAuthorizationHeader(request, proxy, realm));

463	469	public void abort(Channel channel, NettyResponseFuture<?> future, Throwable t) {
464	470
465	471	if (channel != null) {
466		Object attribute = Channels.getAttribute(future.channel());
	472	Object attribute = Channels.getAttribute(channel);
467	473	if (attribute instanceof StreamedResponsePublisher) {
468	474	((StreamedResponsePublisher) attribute).setError(t);
469	475	}

+23

-2

client/src/main/java/org/asynchttpclient/proxy/ProxyServer.java less more

15	15	*/
16	16	package org.asynchttpclient.proxy;
17	17
	18	import io.netty.handler.codec.http.HttpHeaders;
	19
18	20	import org.asynchttpclient.Realm;
	21	import org.asynchttpclient.Request;
19	22
20	23	import java.util.ArrayList;
21	24	import java.util.Collections;
22	25	import java.util.List;
	26	import java.util.function.Function;
23	27
24	28	import static org.asynchttpclient.util.Assertions.assertNotNull;
25	29	import static org.asynchttpclient.util.MiscUtils.isNonEmpty;

35	39	private final Realm realm;
36	40	private final List<String> nonProxyHosts;
37	41	private final ProxyType proxyType;
	42	private final Function<Request, HttpHeaders> customHeaders;
38	43
39	44	public ProxyServer(String host, int port, int securedPort, Realm realm, List<String> nonProxyHosts,
40		ProxyType proxyType) {
	45	ProxyType proxyType, Function<Request, HttpHeaders> customHeaders) {
41	46	this.host = host;
42	47	this.port = port;
43	48	this.securedPort = securedPort;
44	49	this.realm = realm;
45	50	this.nonProxyHosts = nonProxyHosts;
46	51	this.proxyType = proxyType;
	52	this.customHeaders = customHeaders;
	53	}
	54
	55	public ProxyServer(String host, int port, int securedPort, Realm realm, List<String> nonProxyHosts,
	56	ProxyType proxyType) {
	57	this(host, port, securedPort, realm, nonProxyHosts, proxyType, null);
47	58	}
48	59
49	60	public String getHost() {

68	79
69	80	public ProxyType getProxyType() {
70	81	return proxyType;
	82	}
	83
	84	public Function<Request, HttpHeaders> getCustomHeaders() {
	85	return customHeaders;
71	86	}
72	87
73	88	/**

117	132	private Realm realm;
118	133	private List<String> nonProxyHosts;
119	134	private ProxyType proxyType;
	135	private Function<Request, HttpHeaders> customHeaders;
120	136
121	137	public Builder(String host, int port) {
122	138	this.host = host;

156	172	return this;
157	173	}
158	174
	175	public Builder setCustomHeaders(Function<Request, HttpHeaders> customHeaders) {
	176	this.customHeaders = customHeaders;
	177	return this;
	178	}
	179
159	180	public ProxyServer build() {
160	181	List<String> nonProxyHosts = this.nonProxyHosts != null ? Collections.unmodifiableList(this.nonProxyHosts)
161	182	: Collections.emptyList();
162	183	ProxyType proxyType = this.proxyType != null ? this.proxyType : ProxyType.HTTP;
163		return new ProxyServer(host, port, securedPort, realm, nonProxyHosts, proxyType);
	184	return new ProxyServer(host, port, securedPort, realm, nonProxyHosts, proxyType, customHeaders);
164	185	}
165	186	}
166	187	}

+2

-0

client/src/test/java/org/asynchttpclient/AsyncStreamHandlerTest.java less more

427	427	}));
428	428	}
429	429
	430	// This test is flaky - see https://github.com/AsyncHttpClient/async-http-client/issues/1728#issuecomment-699962325
	431	// For now, just run again if fails
430	432	@Test(groups = "online")
431	433	public void asyncOptionsTest() throws Throwable {
432	434

+19

-5

client/src/test/java/org/asynchttpclient/BasicHttpProxyToHttpsTest.java less more

30	30	import java.util.concurrent.ExecutionException;
31	31	import java.util.concurrent.Future;
32	32
33		import static io.netty.handler.codec.http.HttpHeaderNames.PROXY_AUTHENTICATE;
34		import static io.netty.handler.codec.http.HttpHeaderNames.PROXY_AUTHORIZATION;
	33	import static io.netty.handler.codec.http.HttpHeaderNames.*;
35	34	import static org.asynchttpclient.Dsl.*;
36	35	import static org.asynchttpclient.test.TestUtils.addHttpConnector;
37	36	import static org.asynchttpclient.test.TestUtils.addHttpsConnector;
	37	import static org.asynchttpclient.config.AsyncHttpClientConfigDefaults.*;
38	38
39	39	/**
40		* Test that validates that when having an HTTP proxy and trying to access an HTTPS through the proxy the proxy credentials should be passed during the CONNECT request.
	40	* Test that validates that when having an HTTP proxy and trying to access an HTTPS
	41	* through the proxy the proxy credentials and a custom user-agent (if set) should be passed during the CONNECT request.
41	42	*/
42	43	public class BasicHttpProxyToHttpsTest {
43	44
44	45	private static final Logger LOGGER = LoggerFactory.getLogger(BasicHttpProxyToHttpsTest.class);
	46	private static final String CUSTOM_USER_AGENT = "custom-user-agent";
45	47
46	48	private int httpPort;
47	49	private int proxyPort;

65	67	ConnectHandler connectHandler = new ConnectHandler() {
66	68
67	69	@Override
	70	// This proxy receives a CONNECT request from the client before making the real request for the target host.
68	71	protected boolean handleAuthentication(HttpServletRequest request, HttpServletResponse response, String address) {
	72
	73	// If the userAgent of the CONNECT request is the same as the default userAgent,
	74	// then the custom userAgent was not properly propagated and the test should fail.
	75	String userAgent = request.getHeader(USER_AGENT.toString());
	76	if(userAgent.equals(defaultUserAgent())) {
	77	return false;
	78	}
	79
	80	// If the authentication failed, the test should also fail.
69	81	String authorization = request.getHeader(PROXY_AUTHORIZATION.toString());
70	82	if (authorization == null) {
71	83	response.setStatus(HttpServletResponse.SC_PROXY_AUTHENTICATION_REQUIRED);
72	84	response.setHeader(PROXY_AUTHENTICATE.toString(), "Basic realm=\"Fake Realm\"");
73	85	return false;
74		} else if (authorization.equals("Basic am9obmRvZTpwYXNz")) {
	86	}
	87	else if (authorization.equals("Basic am9obmRvZTpwYXNz")) {
75	88	return true;
76	89	}
77	90	response.setStatus(HttpServletResponse.SC_UNAUTHORIZED);

97	110	String targetUrl = "https://localhost:" + httpPort + "/foo/bar";
98	111	Request request = get(targetUrl)
99	112	.setProxyServer(proxyServer("127.0.0.1", proxyPort).setRealm(realm(AuthScheme.BASIC, "johndoe", "pass")))
	113	.setHeader("user-agent", CUSTOM_USER_AGENT)
100	114	// .setRealm(realm(AuthScheme.BASIC, "user", "passwd"))
101	115	.build();
102	116	Future<Response> responseFuture = client.executeRequest(request);

106	120	Assert.assertEquals("/foo/bar", response.getHeader("X-pathInfo"));
107	121	}
108	122	}
109		}⏎
	123	}

+11

-3

client/src/test/java/org/asynchttpclient/Head302Test.java less more

69	69	private static class Head302handler extends AbstractHandler {
70	70	public void handle(String s, org.eclipse.jetty.server.Request r, HttpServletRequest request, HttpServletResponse response) throws IOException, ServletException {
71	71	if ("HEAD".equalsIgnoreCase(request.getMethod())) {
72		response.setStatus(HttpServletResponse.SC_FOUND); // 302
73		response.setHeader("Location", request.getPathInfo() + "_moved");
74		} else if ("GET".equalsIgnoreCase(request.getMethod())) {
	72	// See https://github.com/AsyncHttpClient/async-http-client/issues/1728#issuecomment-700007980
	73	// When setFollowRedirect == TRUE, a follow-up request to a HEAD request will also be a HEAD.
	74	// This will cause an infinite loop, which will error out once the maximum amount of redirects is hit (default 5).
	75	// Instead, we (arbitrarily) choose to allow for 3 redirects and then return a 200.
	76	if(request.getRequestURI().endsWith("_moved_moved_moved")) {
	77	response.setStatus(HttpServletResponse.SC_OK);
	78	} else {
	79	response.setStatus(HttpServletResponse.SC_FOUND); // 302
	80	response.setHeader("Location", request.getPathInfo() + "_moved");
	81	}
	82	} else if ("GET".equalsIgnoreCase(request.getMethod()) ) {
75	83	response.setStatus(HttpServletResponse.SC_OK);
76	84	} else {
77	85	response.setStatus(HttpServletResponse.SC_FORBIDDEN);

+3

-3

client/src/test/java/org/asynchttpclient/MultipleHeaderTest.java less more

52	52	socket.shutdownInput();
53	53	if (req.endsWith("MultiEnt")) {
54	54	OutputStreamWriter outputStreamWriter = new OutputStreamWriter(socket.getOutputStream());
55		outputStreamWriter.append("HTTP/1.0 200 OK\n" + "Connection: close\n" + "Content-Type: text/plain; charset=iso-8859-1\n" + "Content-Length: 2\n"
56		+ "Content-Length: 1\n" + "\n0\n");
	55	outputStreamWriter.append("HTTP/1.0 200 OK\n" + "Connection: close\n" + "Content-Type: text/plain; charset=iso-8859-1\n" + "X-Duplicated-Header: 2\n"
	56	+ "X-Duplicated-Header: 1\n" + "\n0\n");
57	57	outputStreamWriter.flush();
58	58	socket.shutdownOutput();
59	59	} else if (req.endsWith("MultiOther")) {

147	147	public State onHeadersReceived(HttpHeaders response) {
148	148	try {
149	149	int i = 0;
150		for (String header : response.getAll(CONTENT_LENGTH)) {
	150	for (String header : response.getAll("X-Duplicated-Header")) {
151	151	clHeaders[i++] = header;
152	152	}
153	153	} finally {

+108

-0

client/src/test/java/org/asynchttpclient/netty/NettyConnectionResetByPeerTest.java less more

	0	package org.asynchttpclient.netty;
	1
	2	import org.asynchttpclient.DefaultAsyncHttpClient;
	3	import org.asynchttpclient.DefaultAsyncHttpClientConfig;
	4	import org.asynchttpclient.RequestBuilder;
	5	import org.testng.annotations.BeforeTest;
	6	import org.testng.annotations.Test;
	7
	8	import java.io.IOException;
	9	import java.io.InputStream;
	10	import java.io.OutputStream;
	11	import java.net.ServerSocket;
	12	import java.net.Socket;
	13	import java.net.SocketException;
	14	import java.util.Arrays;
	15	import java.util.concurrent.Exchanger;
	16	import java.util.concurrent.ExecutionException;
	17	import java.util.concurrent.TimeoutException;
	18	import java.util.function.Consumer;
	19
	20	import static org.hamcrest.CoreMatchers.instanceOf;
	21	import static org.hamcrest.CoreMatchers.is;
	22	import static org.hamcrest.MatcherAssert.assertThat;
	23	import static org.hamcrest.Matchers.not;
	24	import static org.testng.Assert.assertTrue;
	25
	26	public class NettyConnectionResetByPeerTest {
	27
	28	private String resettingServerAddress;
	29
	30	@BeforeTest
	31	public void setUp() {
	32	resettingServerAddress = createResettingServer();
	33	}
	34
	35	@Test
	36	public void testAsyncHttpClientConnectionResetByPeer() throws InterruptedException {
	37	try {
	38	DefaultAsyncHttpClientConfig config = new DefaultAsyncHttpClientConfig.Builder()
	39	.setRequestTimeout(1500)
	40	.build();
	41	new DefaultAsyncHttpClient(config).executeRequest(
	42	new RequestBuilder("GET").setUrl(resettingServerAddress)
	43	)
	44	.get();
	45	} catch (ExecutionException e) {
	46	Throwable ex = e.getCause();
	47	assertThat(ex, is(instanceOf(IOException.class)));
	48	}
	49	}
	50
	51	private static String createResettingServer() {
	52	return createServer(sock -> {
	53	try (Socket socket = sock) {
	54	socket.setSoLinger(true, 0);
	55	InputStream inputStream = socket.getInputStream();
	56	//to not eliminate read
	57	OutputStream os = new OutputStream() {
	58	@Override
	59	public void write(int b) {
	60	// Do nothing
	61	}
	62	};
	63	os.write(startRead(inputStream));
	64	} catch (IOException e) {
	65	throw new RuntimeException(e);
	66	}
	67	});
	68	}
	69
	70	private static String createServer(Consumer<Socket> handler) {
	71	Exchanger<Integer> portHolder = new Exchanger<>();
	72	Thread t = new Thread(() -> {
	73	try (ServerSocket ss = new ServerSocket(0)) {
	74	portHolder.exchange(ss.getLocalPort());
	75	while (true) {
	76	handler.accept(ss.accept());
	77	}
	78	} catch (Exception e) {
	79	if (e instanceof InterruptedException) {
	80	Thread.currentThread()
	81	.interrupt();
	82	}
	83	throw new RuntimeException(e);
	84	}
	85	});
	86	t.setDaemon(true);
	87	t.start();
	88	return tryGetAddress(portHolder);
	89	}
	90
	91	private static String tryGetAddress(Exchanger<Integer> portHolder) {
	92	try {
	93	return "http://localhost:" + portHolder.exchange(0);
	94	} catch (InterruptedException e) {
	95	Thread.currentThread()
	96	.interrupt();
	97	throw new RuntimeException(e);
	98	}
	99	}
	100
	101	private static byte[] startRead(InputStream inputStream) throws IOException {
	102	byte[] buffer = new byte[4];
	103	int length = inputStream.read(buffer);
	104	return Arrays.copyOf(buffer, length);
	105	}
	106
	107	}

+119

-0

client/src/test/java/org/asynchttpclient/proxy/CustomHeaderProxyTest.java less more

	0	/*
	1	* Copyright (c) 2010-2012 Sonatype, Inc. All rights reserved.
	2	*
	3	* This program is licensed to you under the Apache License Version 2.0,
	4	* and you may not use this file except in compliance with the Apache License Version 2.0.
	5	* You may obtain a copy of the Apache License Version 2.0 at http://www.apache.org/licenses/LICENSE-2.0.
	6	*
	7	* Unless required by applicable law or agreed to in writing,
	8	* software distributed under the Apache License Version 2.0 is distributed on an
	9	* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
	10	* See the Apache License Version 2.0 for the specific language governing permissions and limitations there under.
	11	*/
	12	package org.asynchttpclient.proxy;
	13
	14	import io.netty.handler.codec.http.DefaultHttpHeaders;
	15	import org.asynchttpclient.AbstractBasicTest;
	16	import org.asynchttpclient.AsyncHttpClient;
	17	import org.asynchttpclient.AsyncHttpClientConfig;
	18	import org.asynchttpclient.Response;
	19	import org.asynchttpclient.request.body.generator.ByteArrayBodyGenerator;
	20	import org.asynchttpclient.test.EchoHandler;
	21	import org.asynchttpclient.util.HttpConstants;
	22	import org.eclipse.jetty.proxy.ConnectHandler;
	23	import org.eclipse.jetty.server.Request;
	24	import org.eclipse.jetty.server.Server;
	25	import org.eclipse.jetty.server.ServerConnector;
	26	import org.eclipse.jetty.server.handler.AbstractHandler;
	27	import org.testng.annotations.AfterClass;
	28	import org.testng.annotations.BeforeClass;
	29	import org.testng.annotations.Test;
	30
	31	import javax.servlet.ServletException;
	32	import javax.servlet.http.HttpServletRequest;
	33	import javax.servlet.http.HttpServletResponse;
	34	import java.io.IOException;
	35
	36	import static org.asynchttpclient.Dsl.*;
	37	import static org.asynchttpclient.test.TestUtils.*;
	38	import static org.testng.Assert.assertEquals;
	39
	40	/**
	41	* Proxy usage tests.
	42	*/
	43	public class CustomHeaderProxyTest extends AbstractBasicTest {
	44
	45	private Server server2;
	46
	47	private final String customHeaderName = "Custom-Header";
	48	private final String customHeaderValue = "Custom-Value";
	49
	50	public AbstractHandler configureHandler() throws Exception {
	51	return new ProxyHandler(customHeaderName, customHeaderValue);
	52	}
	53
	54	@BeforeClass(alwaysRun = true)
	55	public void setUpGlobal() throws Exception {
	56	server = new Server();
	57	ServerConnector connector = addHttpConnector(server);
	58	server.setHandler(configureHandler());
	59	server.start();
	60	port1 = connector.getLocalPort();
	61
	62	server2 = new Server();
	63	ServerConnector connector2 = addHttpsConnector(server2);
	64	server2.setHandler(new EchoHandler());
	65	server2.start();
	66	port2 = connector2.getLocalPort();
	67
	68	logger.info("Local HTTP server started successfully");
	69	}
	70
	71	@AfterClass(alwaysRun = true)
	72	public void tearDownGlobal() throws Exception {
	73	server.stop();
	74	server2.stop();
	75	}
	76
	77	@Test
	78	public void testHttpProxy() throws Exception {
	79	AsyncHttpClientConfig config = config()
	80	.setFollowRedirect(true)
	81	.setProxyServer(
	82	proxyServer("localhost", port1)
	83	.setCustomHeaders((req) -> new DefaultHttpHeaders().add(customHeaderName, customHeaderValue))
	84	.build()
	85	)
	86	.setUseInsecureTrustManager(true)
	87	.build();
	88	try (AsyncHttpClient asyncHttpClient = asyncHttpClient(config)) {
	89	Response r = asyncHttpClient.executeRequest(post(getTargetUrl2()).setBody(new ByteArrayBodyGenerator(LARGE_IMAGE_BYTES))).get();
	90	assertEquals(r.getStatusCode(), 200);
	91	}
	92	}
	93
	94	public static class ProxyHandler extends ConnectHandler {
	95	String customHeaderName;
	96	String customHeaderValue;
	97
	98	public ProxyHandler(String customHeaderName, String customHeaderValue) {
	99	this.customHeaderName = customHeaderName;
	100	this.customHeaderValue = customHeaderValue;
	101	}
	102
	103	@Override
	104	public void handle(String s, Request r, HttpServletRequest request, HttpServletResponse response) throws IOException, ServletException {
	105	if (HttpConstants.Methods.CONNECT.equalsIgnoreCase(request.getMethod())) {
	106	if (request.getHeader(customHeaderName).equals(customHeaderValue)) {
	107	response.setStatus(HttpServletResponse.SC_OK);
	108	super.handle(s, r, request, response);
	109	} else {
	110	response.setStatus(HttpServletResponse.SC_BAD_REQUEST);
	111	r.setHandled(true);
	112	}
	113	} else {
	114	super.handle(s, r, request, response);
	115	}
	116	}
	117	}
	118	}

+1

-1

example/pom.xml less more

1	1	<parent>
2	2	<groupId>org.asynchttpclient</groupId>
3	3	<artifactId>async-http-client-project</artifactId>
4		<version>2.12.2</version>
	4	<version>2.12.3</version>
5	5	</parent>
6	6	<modelVersion>4.0.0</modelVersion>
7	7	<artifactId>async-http-client-example</artifactId>

+1

-1

extras/guava/pom.xml less more

1	1	<parent>
2	2	<groupId>org.asynchttpclient</groupId>
3	3	<artifactId>async-http-client-extras-parent</artifactId>
4		<version>2.12.2</version>
	4	<version>2.12.3</version>
5	5	</parent>
6	6	<modelVersion>4.0.0</modelVersion>
7	7	<artifactId>async-http-client-extras-guava</artifactId>

+1

-1

extras/jdeferred/pom.xml less more

17	17	<parent>
18	18	<artifactId>async-http-client-extras-parent</artifactId>
19	19	<groupId>org.asynchttpclient</groupId>
20		<version>2.12.2</version>
	20	<version>2.12.3</version>
21	21	</parent>
22	22	<artifactId>async-http-client-extras-jdeferred</artifactId>
23	23	<name>Asynchronous Http Client JDeferred Extras</name>

+1

-1

extras/pom.xml less more

1	1	<parent>
2	2	<groupId>org.asynchttpclient</groupId>
3	3	<artifactId>async-http-client-project</artifactId>
4		<version>2.12.2</version>
	4	<version>2.12.3</version>
5	5	</parent>
6	6	<modelVersion>4.0.0</modelVersion>
7	7	<artifactId>async-http-client-extras-parent</artifactId>

+1

-1

extras/registry/pom.xml less more

1	1	<parent>
2	2	<groupId>org.asynchttpclient</groupId>
3	3	<artifactId>async-http-client-extras-parent</artifactId>
4		<version>2.12.2</version>
	4	<version>2.12.3</version>
5	5	</parent>
6	6	<modelVersion>4.0.0</modelVersion>
7	7	<artifactId>async-http-client-extras-registry</artifactId>

+1

-1

extras/retrofit2/pom.xml less more

3	3	<parent>
4	4	<artifactId>async-http-client-extras-parent</artifactId>
5	5	<groupId>org.asynchttpclient</groupId>
6		<version>2.12.2</version>
	6	<version>2.12.3</version>
7	7	</parent>
8	8
9	9	<artifactId>async-http-client-extras-retrofit2</artifactId>

+1

-1

extras/rxjava/pom.xml less more

2	2	<parent>
3	3	<artifactId>async-http-client-extras-parent</artifactId>
4	4	<groupId>org.asynchttpclient</groupId>
5		<version>2.12.2</version>
	5	<version>2.12.3</version>
6	6	</parent>
7	7	<artifactId>async-http-client-extras-rxjava</artifactId>
8	8	<name>Asynchronous Http Client RxJava Extras</name>

+1

-1

extras/rxjava2/pom.xml less more

2	2	<parent>
3	3	<artifactId>async-http-client-extras-parent</artifactId>
4	4	<groupId>org.asynchttpclient</groupId>
5		<version>2.12.2</version>
	5	<version>2.12.3</version>
6	6	</parent>
7	7	<artifactId>async-http-client-extras-rxjava2</artifactId>
8	8	<name>Asynchronous Http Client RxJava2 Extras</name>

+1

-1

extras/simple/pom.xml less more

2	2	<parent>
3	3	<artifactId>async-http-client-extras-parent</artifactId>
4	4	<groupId>org.asynchttpclient</groupId>
5		<version>2.12.2</version>
	5	<version>2.12.3</version>
6	6	</parent>
7	7	<artifactId>async-http-client-extras-simple</artifactId>
8	8	<name>Asynchronous Http Simple Client</name>

+1

-1

extras/typesafeconfig/pom.xml less more

3	3	<parent>
4	4	<artifactId>async-http-client-extras-parent</artifactId>
5	5	<groupId>org.asynchttpclient</groupId>
6		<version>2.12.2</version>
	6	<version>2.12.3</version>
7	7	</parent>
8	8
9	9	<artifactId>async-http-client-extras-typesafe-config</artifactId>

+1

-1

netty-utils/pom.xml less more

1	1	<parent>
2	2	<groupId>org.asynchttpclient</groupId>
3	3	<artifactId>async-http-client-project</artifactId>
4		<version>2.12.2</version>
	4	<version>2.12.3</version>
5	5	</parent>
6	6	<modelVersion>4.0.0</modelVersion>
7	7	<artifactId>async-http-client-netty-utils</artifactId>

+3

-3

pom.xml less more

3	3
4	4	<groupId>org.asynchttpclient</groupId>
5	5	<artifactId>async-http-client-project</artifactId>
6		<version>2.12.2</version>
	6	<version>2.12.3</version>
7	7	<packaging>pom</packaging>
8	8
9	9	<name>Asynchronous Http Client Project</name>

33	33	<connection>scm:git:git@github.com:AsyncHttpClient/async-http-client.git</connection>
34	34	<developerConnection>scm:git:git@github.com:AsyncHttpClient/async-http-client.git</developerConnection>
35	35	<url>https://github.com/AsyncHttpClient/async-http-client/tree/master</url>
36		<tag>async-http-client-project-2.12.2</tag>
	36	<tag>async-http-client-project-2.12.3</tag>
37	37	</scm>
38	38
39	39	<distributionManagement>

465	465	<surefire.redirectTestOutputToFile>true</surefire.redirectTestOutputToFile>
466	466	<source.property>1.8</source.property>
467	467	<target.property>1.8</target.property>
468		<netty.version>4.1.53.Final</netty.version>
	468	<netty.version>4.1.60.Final</netty.version>
469	469	<slf4j.version>1.7.30</slf4j.version>
470	470	<reactive-streams.version>1.0.3</reactive-streams.version>
471	471	<activation.version>1.2.2</activation.version>