Codebase list cdebconf / 8913946
Merge branch 'g-malloc-cannot-fail' into 'master' gtk: Remove "check NULL" comments See merge request installer-team/cdebconf!10 Julien Cristau 2 years ago
7 changed file(s) with 0 addition(s) and 30 deletion(s). Raw diff Collapse all Expand all
+0
-1
src/modules/frontend/gtk/choice_model.c less more
143143 raw_translated_choices = q_get_choices(fe, question);
144144 count = strgetargc(raw_choices);
145145 g_assert(0 < count);
146 /* check NULLs! */
147146 sorted_indices = g_malloc0(count * sizeof (int));
148147 choice_values = g_malloc0(count * sizeof (char *));
149148 choice_translated_values = g_malloc0(count * sizeof (char *));
+0
-5
src/modules/frontend/gtk/go.c less more
9393 struct frontend_data * fe_data = fe->data;
9494 struct setter * setter;
9595
96 /* check NULL! */
9796 setter = g_malloc0(sizeof (struct setter));
9897 setter->func = func;
9998 setter->question = question;
165164 char * label;
166165
167166 label = cdebconf_gtk_get_text(fe, "debconf/button-help", "Help");
168 /* XXX: check NULL! */
169167 button = gtk_button_new_with_label(label);
170168 g_free(label);
171169
207205 char * label;
208206
209207 label = cdebconf_gtk_get_text(fe, "debconf/button-goback", "Go Back");
210 /* XXX: check NULL! */
211208 button = gtk_button_new_with_label(label);
212209 g_free(label);
213210
228225 GtkWidget * button;
229226 char * label;
230227
231 /* XXX: check NULL! */
232228 label = cdebconf_gtk_get_text(fe, "debconf/button-continue", "Continue");
233229 button = gtk_button_new_with_label(label);
234230 g_free(label);
454450 GtkWidget * hpadding_box;
455451 GtkAdjustment *adj;
456452
457 /* check NULL! */
458453 question_box = gtk_vbox_new(FALSE /* don't make children equal */,
459454 0 /* padding */);
460455
+0
-1
src/modules/frontend/gtk/handlers.c less more
192192 {
193193 GtkWidget * alignment;
194194
195 /* check NULL! */
196195 alignment = gtk_alignment_new(0.0 /* left */, 0.0 /* top */,
197196 1.0 /* expand horizontally */,
198197 0.0 /* no vertical expansion */);
+0
-3
src/modules/frontend/gtk/progress.c less more
9292 {
9393 GtkWidget * progress_bar;
9494
95 /* XXX: check NULL! */
9695 progress_bar = gtk_progress_bar_new();
9796
9897 gtk_progress_bar_set_ellipsize(GTK_PROGRESS_BAR(progress_bar),
185184 {
186185 GtkWidget * progress_box;
187186
188 /* check NULL! */
189187 progress_box = gtk_vbox_new(FALSE /* don't make children equal */,
190188 0 /* padding */);
191189
319317 GtkWidget * button;
320318 char * label;
321319
322 /* XXX: check NULL! */
323320 label = cdebconf_gtk_get_text(fe, "debconf/button-cancel", "Cancel");
324321 button = gtk_button_new_with_label(label);
325322 g_free(label);
+0
-1
src/modules/frontend/gtk/screenshot.c less more
185185 GtkWidget * button;
186186 char * label;
187187
188 /* XXX: check NULL! */
189188 label = cdebconf_gtk_get_text(fe, "debconf/gtk-button-screenshot",
190189 "Screenshot");
191190 button = gtk_button_new_with_label(label);
+0
-5
src/modules/frontend/gtk/select_handlers.c less more
308308 PangoTabArray * tab_array;
309309
310310 if (CAN_ALIGN(fe)) {
311 /* XXX: check NULL */
312311 tab_array = pango_tab_array_new(0 /* start with no tabs */,
313312 FALSE /* use pango unit */);
314313 adjust_tabs(GTK_WIDGET(view), tab_array,
346345 GtkWidget * scroll;
347346 GtkWidget * frame;
348347
349 /* check NULL! */
350348 view = gtk_tree_view_new_with_model(model);
351349
352350 gtk_tree_view_set_headers_visible(GTK_TREE_VIEW(view),
448446 guint selected_index;
449447 gchar * result;
450448
451 /* check NULL! */
452449 selected_values = g_malloc0(
453450 sizeof (char *) * (1 /* terminating NULL */ +
454451 cdebconf_gtk_choice_model_get_length(model)));
738735 GtkWidget * combo_box;
739736 GtkCellRenderer * text_renderer;
740737
741 /* XXX: check NULL! */
742738 combo_box = gtk_combo_box_new_with_model(model);
743 /* XXX: check NULL! */
744739 text_renderer = gtk_cell_renderer_text_new();
745740 gtk_cell_layout_pack_start(GTK_CELL_LAYOUT(combo_box), text_renderer,
746741 TRUE /* expand */);
+0
-14
src/modules/frontend/gtk/ui.c less more
203203 }
204204 g_free(theme_name);
205205
206 /* XXX: check NULL! */
207206 banner = gtk_event_box_new();
208207 logo = gtk_image_new_from_file(banner_path);
209208 gtk_misc_set_alignment(GTK_MISC(logo), 0.5 /* center */, 0 /* top */);
251250 struct frontend_data * fe_data = fe->data;
252251 GtkWidget * label_title;
253252
254 /* check NULL! */
255253 label_title = gtk_label_new(NULL /* no label */);
256254
257255 gtk_misc_set_alignment(GTK_MISC(label_title), 0 /* left */, 0 /* top */);
299297
300298 g_assert(NULL == fe_data->action_box);
301299
302 /* check NULL! */
303300 action_box = gtk_hbutton_box_new();
304301
305302 gtk_button_box_set_layout(GTK_BUTTON_BOX(action_box), GTK_BUTTONBOX_END);
327324 GtkWidget * v_mainbox;
328325 GtkWidget * h_mainbox;
329326
330 /* check NULL! */
331327 outer_box = gtk_vbox_new(FALSE /* don't make children equal */,
332328 0 /* padding */);
333329 create_banner(fe, outer_box);
334 /* check NULL! */
335330 v_mainbox = gtk_vbox_new(FALSE /* don't make children equal */,
336331 0 /* padding */);
337 /* check NULL! */
338332 h_mainbox = gtk_hbox_new(FALSE /* don't make children equal */,
339333 0 /* padding */);
340334 create_label_title(fe, v_mainbox);
437431 struct frontend_data * fe_data = fe->data;
438432 struct shortcut * shortcut;
439433
440 /* XXX: check NULL! */
441434 shortcut = g_malloc0(sizeof (struct shortcut));
442435 shortcut->window = fe_data->window;
443436 shortcut->handler_id = g_signal_connect_after(
471464 GtkWidget * vbox;
472465 GtkWidget * hbox;
473466
474 /* XXX: check NULL! */
475467 vbox = gtk_vbox_new(FALSE /* don't make children equal */,
476468 0 /* padding */);
477 /* XXX: check NULL! */
478469 hbox = gtk_hbox_new(FALSE /* don't make children equal */,
479470 0 /* padding */);
480471 gtk_box_pack_start(GTK_BOX(vbox), *widget, TRUE /* expand */,
497488 GtkWidget * close_button;
498489 char * label;
499490
500 /* check NULL! */
501491 action_box = gtk_hbutton_box_new();
502492 gtk_button_box_set_layout(GTK_BUTTON_BOX(action_box), GTK_BUTTONBOX_END);
503493
504494 label = cdebconf_gtk_get_text(fe, "debconf/button-continue", "Continue");
505 /* check NULL! */
506495 close_button = gtk_button_new_with_label(label);
507496 g_free(label);
508497
524513 GtkWidget * label;
525514 gchar * markup;
526515
527 /* check NULL! */
528516 label = gtk_label_new(NULL /* no text */);
529517 gtk_misc_set_alignment(GTK_MISC(label), 0 /* left aligned */,
530518 0 /* top aligned */);
547535 GtkWidget * frame;
548536 GtkWidget * label;
549537
550 /* XXX: check NULL! */
551538 dialog = gtk_window_new(GTK_WINDOW_TOPLEVEL);
552539 gtk_window_set_modal(GTK_WINDOW(dialog), TRUE /* modal */);
553540 gtk_window_set_transient_for(GTK_WINDOW(dialog),
561548 label = gtk_label_new(message);
562549 gtk_label_set_line_wrap(GTK_LABEL(label), TRUE);
563550
564 /* XXX: check NULL! */
565551 vbox = gtk_vbox_new(FALSE /* don't make children equal */,
566552 DEFAULT_PADDING);
567553 gtk_box_pack_start(GTK_BOX(vbox), create_dialog_title_label(title),