Codebase list findbugs / f8af55e
rework patches for new upstream release These should be broken down/combined into fewer patches that address each category of patch - e.g., the build system, compilation/porting changes, and docs, etc. tony mancill 8 years ago
11 changed file(s) with 213 addition(s) and 324 deletion(s). Raw diff Collapse all Expand all
0 Index: findbugs-2.0.3/build.properties
1 ===================================================================
2 --- findbugs-2.0.3.orig/build.properties 2013-12-17 19:44:08.738200004 +0800
3 +++ findbugs-2.0.3/build.properties 2013-12-17 19:51:27.826196570 +0800
0 unchanged:
1 --- a/build.properties
2 +++ b/build.properties
43 @@ -8,10 +8,12 @@
54 src/gui/,\
65 etc
2423
2524 # Set this to the directory where FOP (http://xml.apache.org/fop/)
2625 # is installed. (Note: this is disabled for now.)
27 Index: findbugs-2.0.3/build.xml
28 ===================================================================
29 --- findbugs-2.0.3.orig/build.xml 2013-12-17 19:44:08.738200004 +0800
30 +++ findbugs-2.0.3/build.xml 2013-12-17 19:51:27.830196570 +0800
31 @@ -60,24 +60,23 @@
32 <property name="version.props.file" value="${build.dir}/classes/edu/umd/cs/findbugs/version.properties"/>
26 --- a/build.xml
27 +++ b/build.xml
28 @@ -60,12 +60,24 @@
3329
3430 <path id="findbugs.classpath">
35 - <pathelement location="${jar.dir}/bcel.jar"/>
36 - <pathelement location="${jar.dir}/dom4j-1.6.1.jar"/>
37 - <pathelement location="${jar.dir}/AppleJavaExtensions.jar"/>
38 - <pathelement location="${jar.dir}/junit.jar"/>
39 - <pathelement location="${jar.dir}/asm-3.3.jar"/>
40 - <pathelement location="${jar.dir}/asm-commons-3.3.jar"/>
41 - <pathelement location="${jar.dir}/asm-tree-3.3.jar"/>
42 - <pathelement location="${jar.dir}/jaxen-1.1.6.jar"/>
43 - <pathelement location="${jar.dir}/jsr305.jar"/>
44 - <pathelement location="${jar.dir}/jFormatString.jar"/>
45 - <pathelement location="${jar.dir}/commons-lang-2.6.jar"/>
46 - <pathelement location="${jar.dir}/jcip-annotations.jar"/>
31 <fileset dir="${jar.dir}" includes="*.jar"/>
4732 + <pathelement location="${sys.jar.dir}/bcel.jar"/>
33 + <pathelement location="${sys.jar.dir}/commons-lang.jar"/>
34 + <pathelement location="${sys.jar.dir}/jsr305.jar"/>
35 + <pathelement location="${sys.jar.dir}/junit4.jar"/>
4836 + <pathelement location="${sys.jar.dir}/dom4j.jar"/>
49 + <pathelement location="${sys.jar.dir}/junit4.jar"/>
50 + <pathelement location="${sys.jar.dir}/asm3.jar"/>
51 + <pathelement location="${sys.jar.dir}/asm3-commons.jar"/>
52 + <pathelement location="${sys.jar.dir}/asm3-tree.jar"/>
53 + <pathelement location="${sys.jar.dir}/jaxen.jar"/>
54 + <pathelement location="${sys.jar.dir}/jsr305.jar"/>
37 + <pathelement location="${sys.jar.dir}/jdepend.jar"/>
5538 + <pathelement location="${sys.jar.dir}/jFormatString.jar"/>
56 + <pathelement location="${sys.jar.dir}/commons-lang.jar"/>
39 + <pathelement location="${sys.jar.dir}/asm4.jar"/>
40 + <pathelement location="${sys.jar.dir}/asm4-commons.jar"/>
41 + <pathelement location="${sys.jar.dir}/asm4-tree.jar"/>
5742 + <pathelement location="${sys.jar.dir}/jcip.jar"/>
43 + <pathelement location="${sys.jar.dir}/ant.jar"/>
5844 </path>
5945
6046 <path id="tools.classpath">
6551 <path refid="findbugs.classpath"/>
6652 </path>
6753
68 @@ -124,17 +123,16 @@
69 <target name="mondo" depends="jars">
70 <jar destfile="build/mondo.jar"
71 manifest="etc/MANIFEST-findbugs-mondo.MF">
72 - <zipfileset src="${jar.dir}/bcel.jar"/>
73 - <zipfileset src="${jar.dir}/dom4j-1.6.1.jar"/>
74 - <zipfileset src="${jar.dir}/AppleJavaExtensions.jar"/>
75 - <zipfileset src="${jar.dir}/junit.jar"/>
76 - <zipfileset src="${jar.dir}/asm-3.3.jar"/>
77 - <zipfileset src="${jar.dir}/asm-commons-3.3.jar"/>
78 - <zipfileset src="${jar.dir}/asm-tree-3.3.jar"/>
79 - <zipfileset src="${jar.dir}/jaxen-1.1.6.jar"/>
80 - <zipfileset src="${jar.dir}/jsr305.jar"/>
81 - <zipfileset src="${jar.dir}/jFormatString.jar"/>
82 - <zipfileset src="${jar.dir}/commons-lang-2.6.jar"/>
83 + <zipfileset src="${sys.jar.dir}/bcel.jar"/>
84 + <zipfileset src="${sys.jar.dir}/dom4j.jar"/>
85 + <zipfileset src="${sys.jar.dir}/junit4.jar"/>
86 + <zipfileset src="${sys.jar.dir}/asm3.jar"/>
87 + <zipfileset src="${sys.jar.dir}/asm3-commons.jar"/>
88 + <zipfileset src="${sys.jar.dir}/asm3-tree.jar"/>
89 + <zipfileset src="${sys.jar.dir}/jaxen.jar"/>
90 + <zipfileset src="${sys.jar.dir}/jsr305.jar"/>
91 + <zipfileset src="${sys.jar.dir}/jFormatString.jar"/>
92 + <zipfileset src="${sys.jar.dir}/commons-lang.jar"/>
93 <zipfileset src="${jar.dir}/findbugs.jar"/>
94 </jar>
95 </target>
96 @@ -329,8 +327,8 @@
54 @@ -298,8 +310,8 @@
9755 <fileset dir="${src.dir}">
9856 <include name="**/annotations/*.java"/>
9957 </fileset>
10462 </jar>
10563 </target>
10664
107 @@ -362,20 +360,20 @@
108 <include name="messages*.xml"/>
109 </fileset>
110
111 - <zipfileset src="${jar.dir}/bcel.jar" excludes="META-INF/**"/>
112 + <zipfileset src="${sys.jar.dir}/bcel.jar" excludes="META-INF/**"/>
113
114 - <zipfileset src="${jar.dir}/asm-3.3.jar" excludes="META-INF/**"/>
115 - <zipfileset src="${jar.dir}/asm-analysis-3.3.jar" excludes="META-INF/**"/>
116 - <zipfileset src="${jar.dir}/asm-commons-3.3.jar" excludes="META-INF/**"/>
117 - <zipfileset src="${jar.dir}/asm-tree-3.3.jar" excludes="META-INF/**"/>
118 - <zipfileset src="${jar.dir}/asm-util-3.3.jar" excludes="META-INF/**"/>
119 - <zipfileset src="${jar.dir}/asm-xml-3.3.jar" excludes="META-INF/**"/>
120 -
121 - <zipfileset src="${jar.dir}/dom4j-1.6.1.jar" excludes="META-INF/**"/>
122 - <zipfileset src="${jar.dir}/jaxen-1.1.6.jar" excludes="META-INF/**"/>
123 - <zipfileset src="${jar.dir}/jsr305.jar" excludes="META-INF/**"/>
124 - <zipfileset src="${jar.dir}/jFormatString.jar" excludes="META-INF/**"/>
125 - <zipfileset src="${jar.dir}/commons-lang-2.6.jar" excludes="META-INF/**"/>
126 + <zipfileset src="${sys.jar.dir}/asm3.jar" excludes="META-INF/**"/>
127 + <zipfileset src="${sys.jar.dir}/asm3-analysis.jar" excludes="META-INF/**"/>
128 + <zipfileset src="${sys.jar.dir}/asm3-commons.jar" excludes="META-INF/**"/>
129 + <zipfileset src="${sys.jar.dir}/asm3-tree.jar" excludes="META-INF/**"/>
130 + <zipfileset src="${sys.jar.dir}/asm3-util.jar" excludes="META-INF/**"/>
131 + <zipfileset src="${sys.jar.dir}/asm3-xml.jar" excludes="META-INF/**"/>
132 +
133 + <zipfileset src="${sys.jar.dir}/dom4j.jar" excludes="META-INF/**"/>
134 + <zipfileset src="${sys.jar.dir}/jaxen.jar" excludes="META-INF/**"/>
135 + <zipfileset src="${sys.jar.dir}/jsr305.jar" excludes="META-INF/**"/>
136 + <zipfileset src="${sys.jar.dir}/jFormatString.jar" excludes="META-INF/**"/>
137 + <zipfileset src="${sys.jar.dir}/commons-lang.jar" excludes="META-INF/**"/>
138 </jar>
65 @@ -645,14 +657,12 @@
13966 </target>
14067
141 @@ -511,7 +509,7 @@
142 projectName="Byte code Engineering Library (BCEL)"
143 outputFile="${sampleoutput.dir}/bcel.xml"
144 >
145 - <class location="${jar.dir}/bcel.jar" />
146 + <class location="${sys.jar.dir}/bcel.jar" />
147 </findbugs>
148 <findbugs home="."
149 output="xml:withMessages"
150 @@ -519,7 +517,7 @@
151 jvmargs="-ea -Xmx1200m"
152 projectName="Byte code Engineering Library (BCEL)"
153 outputFile="${sampleoutput.dir}/bcel-cloud-appengine.xml" >
154 - <class location="${jar.dir}/bcel.jar" />
155 + <class location="${jar.dir}/bcel.jar" />
156 </findbugs>
157 <!--
158 <findbugs home="."
159 @@ -1029,16 +1027,15 @@
68
69 - <target name="version" depends="classes,-get-git-revision" >
70 - <echo>${gitrnum}</echo>
71 + <target name="version" depends="classes" >
72 <java classpathref="tools.classpath"
73 output="${version.props.file}"
74 classname="edu.umd.cs.findbugs.Version"
75 failonerror="true">
76 <arg value="-props"/>
77 - <sysproperty key="git.revision" value="${gitrnum}"/>
78 </java>
79
80 <loadproperties srcfile="${version.props.file}"/>
81 @@ -943,16 +953,15 @@
16082 <!-- Generate jnlp jars -->
16183 <target name="jnlp" depends="jars">
16284 <copy todir="${jnlp.dir}" file="${engine.jar}"/>
17294 - <copy todir="${jnlp.dir}" file="${jar.dir}/AppleJavaExtensions.jar"/>
17395 + <copy todir="${jnlp.dir}" file="${sys.jar.dir}/bcel.jar"/>
17496 + <copy todir="${jnlp.dir}" file="${sys.jar.dir}/jsr305.jar"/>
175 + <copy todir="${jnlp.dir}" file="${sys.jar.dir}/asm3.jar"/>
176 + <copy todir="${jnlp.dir}" file="${sys.jar.dir}/asm3-commons.jar"/>
177 + <copy todir="${jnlp.dir}" file="${sys.jar.dir}/asm3-tree.jar"/>
97 + <copy todir="${jnlp.dir}" file="${sys.jar.dir}/asm4.jar"/>
98 + <copy todir="${jnlp.dir}" file="${sys.jar.dir}/asm4-commons.jar"/>
99 + <copy todir="${jnlp.dir}" file="${sys.jar.dir}/asm4-tree.jar"/>
178100 + <copy todir="${jnlp.dir}" file="${sys.jar.dir}/dom4j.jar"/>
179101 + <copy todir="${jnlp.dir}" file="${sys.jar.dir}/jaxen.jar"/>
180102 + <copy todir="${jnlp.dir}" file="${sys.jar.dir}/jFormatString.jar"/>
182104 <copy todir="${jnlp.dir}" file="${docsrc.dir}/buggy-sm.png"/>
183105 <copy todir="${jnlp.dir}">
184106 <fileset refid="plugin.jars"/>
185 @@ -1310,7 +1307,7 @@
107 @@ -1212,7 +1221,7 @@
186108
187109 <target name="annotationJavadoc">
188110 <javadoc access="public"
189111 - classpath="lib/bcel.jar:lib/junit.jar:lib/dom4j-1.6.1.jar:lib/jsr305.jar:lib/AppleJavaExtensions.jar"
190 + classpath="${sys.jar.dir}/bcel.jar:${sys.jar.dir}/junit4.jar:${sys.jar.dir}/dom4j.jar:${sys.jar.dir}/jsr305.jar"
112 + classpath="${sys.jar.dir}/findbugs-bcel.jar:${sys.jar.dir}/junit4.jar:${sys.jar.dir}/dom4j.jar:${sys.jar.dir}/jsr305.jar"
191113 destdir="${annotationDoc.dir}"
192114 packagenames="edu.umd.cs.findbugs.annotations"
193115 doctitle="FindBugs Annotation Documentation"
194 Index: findbugs-2.0.3/.classpath
195 ===================================================================
196 --- findbugs-2.0.3.orig/.classpath 2013-12-17 19:51:22.710196610 +0800
197 +++ findbugs-2.0.3/.classpath 2013-12-17 20:10:22.934187697 +0800
198 @@ -15,32 +15,19 @@
199 <accessrule kind="nonaccessible" pattern="com/apple/**"/>
200 </accessrules>
201 </classpathentry>
202 - <classpathentry exported="true" kind="lib" path="lib/AppleJavaExtensions.jar"/>
203 - <classpathentry exported="true" kind="lib" path="lib/bcel.jar">
204 - <attributes>
205 - <attribute name="javadoc_location" value="http://jakarta.apache.org/bcel/apidocs/"/>
206 - </attributes>
207 - </classpathentry>
208 - <classpathentry exported="true" kind="lib" path="lib/dom4j-1.6.1.jar">
209 - <attributes>
210 - <attribute name="javadoc_location" value="http://dom4j.org/apidocs/"/>
211 - </attributes>
212 - </classpathentry>
213 - <classpathentry exported="true" kind="lib" path="lib/junit.jar"/>
214 - <classpathentry exported="true" kind="lib" path="lib/commons-lang-2.6.jar"/>
215 - <classpathentry exported="true" kind="lib" path="lib/jcip-annotations.jar"/>
216 - <classpathentry exported="true" kind="lib" path="lib/yjp-controller-api-redist.jar"/>
217 <classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins"/>
218 - <classpathentry exported="true" kind="lib" path="lib/jsr305.jar" sourcepath="lib/jsr305.jar"/>
219 - <classpathentry exported="true" kind="lib" path="lib/jaxen-1.1.6.jar"/>
220 - <classpathentry exported="true" kind="lib" path="lib/jFormatString.jar"/>
221 - <classpathentry exported="true" kind="lib" path="lib/jdepend-2.9.jar"/>
222 - <classpathentry exported="true" kind="lib" path="lib/asm-3.3.jar" sourcepath="lib/asm-src-3.3.zip"/>
223 - <classpathentry exported="true" kind="lib" path="lib/asm-commons-3.3.jar" sourcepath="lib/asm-src-3.3.zip"/>
224 - <classpathentry exported="true" kind="lib" path="lib/asm-tree-3.3.jar" sourcepath="lib/asm-src-3.3.zip"/>
225 - <classpathentry exported="true" kind="lib" path="lib/ant.jar"/>
226 - <classpathentry exported="true" kind="lib" path="lib/asm-analysis-3.3.jar" sourcepath="lib/asm-src-3.3.zip"/>
227 - <classpathentry exported="true" kind="lib" path="lib/asm-util-3.3.jar" sourcepath="lib/asm-src-3.3.zip"/>
228 - <classpathentry exported="true" kind="lib" path="lib/asm-xml-3.3.jar" sourcepath="lib/asm-src-3.3.zip"/>
229 + <classpathentry kind="lib" path="/usr/share/java/junit4.jar"/>
230 + <classpathentry kind="lib" path="/usr/share/java/asm3.jar"/>
231 + <classpathentry kind="lib" path="/usr/share/java/asm3-tree.jar"/>
232 + <classpathentry kind="lib" path="/usr/share/java/bcel.jar"/>
233 + <classpathentry kind="lib" path="/usr/share/java/dom4j.jar"/>
234 + <classpathentry kind="lib" path="/usr/share/java/asm3-commons.jar"/>
235 + <classpathentry kind="lib" path="/usr/share/java/jaxen.jar"/>
236 + <classpathentry kind="lib" path="/usr/share/java/jsr305.jar"/>
237 + <classpathentry kind="lib" path="/usr/share/java/jFormatString.jar"/>
238 + <classpathentry kind="lib" path="/usr/share/java/commons-lang.jar"/>
239 + <classpathentry kind="lib" path="/usr/share/java/jcip.jar"/>
240 + <classpathentry kind="lib" path="/usr/share/java/ant.jar"/>
241 + <classpathentry kind="lib" path="/usr/share/java/jdepend.jar"/>
242 <classpathentry kind="output" path="classesEclipse"/>
243 </classpath>
244 Index: findbugs-2.0.3/src/gui/edu/umd/cs/findbugs/gui2/OSXAdapter.java
245 ===================================================================
246 --- findbugs-2.0.3.orig/src/gui/edu/umd/cs/findbugs/gui2/OSXAdapter.java 2010-09-18 15:46:28.000000000 +0800
247 +++ findbugs-2.0.3/src/gui/edu/umd/cs/findbugs/gui2/OSXAdapter.java 2013-12-17 20:04:48.778190308 +0800
116 --- a/src/gui/edu/umd/cs/findbugs/gui2/OSXAdapter.java
117 +++ b/src/gui/edu/umd/cs/findbugs/gui2/OSXAdapter.java
248118 @@ -19,9 +19,6 @@
249119
250120 package edu.umd.cs.findbugs.gui2;
255125 /*
256126 * Based on sample code from Apple.
257127 *
258 @@ -29,91 +26,8 @@
128 @@ -29,13 +26,13 @@
259129 * This class should only ever be referenced via reflection after
260130 * checking that we are running on Mac OS X.
261131 */
262132 -public class OSXAdapter extends ApplicationAdapter {
263 -
264 - // pseudo-singleton model; no point in making multiple instances
265 - // of the EAWT application or our adapter
266 - private static OSXAdapter theAdapter = new OSXAdapter();
267 -
133 +public class OSXAdapter {
134
135 // pseudo-singleton model; no point in making multiple instances
136 // of the EAWT application or our adapter
137 private static OSXAdapter theAdapter = new OSXAdapter();
138
268139 - private static final com.apple.eawt.Application theApplication = new com.apple.eawt.Application();
269 -
270 - // reference to the app where the existing quit, about, prefs code is
271 - private static MainFrame mainApp;
272 -
273 - private OSXAdapter() {
274 - }
275 -
276 - // implemented handler methods. These are basically hooks into
277 - // existing functionality from the main app, as if it came
278 - // over from another platform.
279 -
280 - @Override
281 - public void handleAbout(ApplicationEvent ae) {
282 - if (mainApp != null) {
283 - ae.setHandled(true);
284 - // We need to invoke modal About Dialog asynchronously
285 - // otherwise the Application queue is locked for the duration
286 - // of the about Dialog, which results in a deadlock if a URL is
287 - // selected, and we get a ReOpenApplication event when user
288 - // switches back to Findbugs.
289 - javax.swing.SwingUtilities.invokeLater(new Runnable() {
290 - public void run() {
291 - mainApp.about();
292 - }
293 - });
294 - } else {
295 - throw new IllegalStateException("handleAbout: " + "MyApp instance detached from listener");
296 - }
297 - }
298 -
299 - @Override
300 - public void handlePreferences(ApplicationEvent ae) {
301 - if (mainApp != null) {
302 - mainApp.preferences();
303 - ae.setHandled(true);
304 - } else {
305 - throw new IllegalStateException("handlePreferences: MyApp instance " + "detached from listener");
306 - }
307 - }
308 -
140 + //private static final com.apple.eawt.Application theApplication = new com.apple.eawt.Application();
141
142 // reference to the app where the existing quit, about, prefs code is
143 private static MainFrame mainApp;
144 @@ -47,6 +44,7 @@
145 // existing functionality from the main app, as if it came
146 // over from another platform.
147
148 + /* disabled for Debian build
149 @Override
150 public void handleAbout(ApplicationEvent ae) {
151 if (mainApp != null) {
152 @@ -76,10 +74,12 @@
153 throw new IllegalStateException("handlePreferences: MyApp instance " + "detached from listener");
154 }
155 }
156 + */
157
309158 - @Override
310159 - public void handleQuit(ApplicationEvent ae) {
311160 - if (mainApp != null) {
312 -
313 - /*
314 - * You MUST setHandled(false) if you want to delay or cancel the
315 - * quit. This is important for cross-platform development -- have a
316 - * universal quit routine that chooses whether or not to quit, so
317 - * the functionality is identical on all platforms. This example
318 - * simply cancels the AppleEvent-based quit and defers to that
319 - * universal method.
320 - */
321 -
161 + // disabled for Debian build
162 + //@Override
163 + //public void handleQuit(ApplicationEvent ae) {
164 + // if (mainApp != null) {
165
166 /*
167 * You MUST setHandled(false) if you want to delay or cancel the
168 @@ -90,12 +90,12 @@
169 * universal method.
170 */
171
322172 - ae.setHandled(false);
323173 - mainApp.callOnClose();
324174 - } else {
325175 - throw new IllegalStateException("handleQuit: MyApp instance detached " + "from listener");
326176 - }
327177 - }
328 -
329 - // The main entry-point for this functionality. This is the only method
330 - // that needs to be called at runtime, and it can easily be done using
331 - // reflection (see MyApp.java)
332 - public static void registerMacOSXApplication(MainFrame inApp) {
333 - if (mainApp != null)
334 - throw new IllegalStateException("application already set");
335 -
336 - mainApp = inApp;
337 -
178 + // ae.setHandled(false);
179 + // mainApp.callOnClose();
180 + // } else {
181 + // throw new IllegalStateException("handleQuit: MyApp instance detached " + "from listener");
182 + // }
183 + //}
184
185 // The main entry-point for this functionality. This is the only method
186 // that needs to be called at runtime, and it can easily be done using
187 @@ -107,15 +107,15 @@
188
189 mainApp = inApp;
190
338191 - theApplication.addApplicationListener(theAdapter);
339 -
192 + //theApplication.addApplicationListener(theAdapter);
193
340194 - theApplication.addPreferencesMenuItem();
341 - }
342 -
343 - // Another static entry point for EAWT functionality. Enables the
344 - // "Preferences..." menu item in the application menu.
345 - public static void enablePrefs(boolean enabled) {
346 -
195 + //theApplication.addPreferencesMenuItem();
196 }
197
198 // Another static entry point for EAWT functionality. Enables the
199 // "Preferences..." menu item in the application menu.
200 public static void enablePrefs(boolean enabled) {
201
347202 - theApplication.setEnabledPreferencesMenu(enabled);
348 +public class OSXAdapter {
349 + public OSXAdapter() throws Exception {
350 + throw new Exception("No support for apple in debian.");
203 + //theApplication.setEnabledPreferencesMenu(enabled);
351204 }
352205 }
206 --- a/src/gui/edu/umd/cs/findbugs/gui2/MainFrameComponentFactory.java
207 +++ b/src/gui/edu/umd/cs/findbugs/gui2/MainFrameComponentFactory.java
208 @@ -461,7 +461,7 @@
209 JToolTip tempToolTip = mainFrame.mainFrameTree.getTableheader().createToolTip();
210 UIManager.put("ToolTip.font", new FontUIResource(tempToolTip.getFont().deriveFont(Driver.getFontSize())));
211
212 - setupOSX();
213 + //setupOSX();
214
215 String loadFromURL = SystemProperties.getOSDependentProperty("findbugs.loadBugsFromURL");
216
217 @@ -486,6 +486,7 @@
218 mainFrame.waitForMainFrameInitialized();
219 }
220
221 + /* disabled for Debian
222 private void setupOSX() {
223 if (MainFrame.MAC_OS_X) {
224 try {
225 @@ -514,6 +515,7 @@
226 }
227 }
228 }
229 + */
230 }
231
232 /**
0 Index: findbugs-2.0.3/jnlp/core.jnlp
1 ===================================================================
2 --- findbugs-2.0.3.orig/jnlp/core.jnlp 2013-12-17 17:59:30.626249087 +0800
3 +++ findbugs-2.0.3/jnlp/core.jnlp 2013-12-17 20:24:26.170181104 +0800
0 --- a/jnlp/core.jnlp
1 +++ b/jnlp/core.jnlp
42 @@ -13,15 +13,14 @@
53 <all-permissions/>
64 </security>
75 <resources>
86 - <jar href="AppleJavaExtensions.jar"/>
9 - <jar href="bcel.jar"/>
7 <jar href="bcel.jar"/>
108 - <jar href="dom4j-1.6.1.jar"/>
119 - <jar href="asm-3.3.jar"/>
1210 - <jar href="asm-tree-3.3.jar"/>
1311 - <jar href="asm-commons-3.3.jar"/>
1412 - <jar href="jaxen-1.1.6.jar"/>
15 + <jar href="bcel.jar"/>
1613 + <jar href="dom4j.jar"/>
17 + <jar href="asm3.jar"/>
18 + <jar href="asm3-tree.jar"/>
19 + <jar href="asm3-commons.jar"/>
14 + <jar href="asm4.jar"/>
15 + <jar href="asm4-tree.jar"/>
16 + <jar href="asm4-commons.jar"/>
2017 + <jar href="jaxen.jar"/>
2118 <jar href="jFormatString.jar"/>
2219 - <jar href="commons-lang-2.6.jar"/>
2421 <jar href="jsr305.jar"/>
2522 </resources>
2623 <component-desc />
27 Index: findbugs-2.0.3/jnlp/findbugs.jnlp
28 ===================================================================
29 --- findbugs-2.0.3.orig/jnlp/findbugs.jnlp 2013-12-17 17:59:30.626249087 +0800
30 +++ findbugs-2.0.3/jnlp/findbugs.jnlp 2013-12-17 20:25:08.606180771 +0800
24 --- a/jnlp/findbugs.jnlp
25 +++ b/jnlp/findbugs.jnlp
3126 @@ -18,15 +18,14 @@
3227 <resources>
3328 <j2se version="1.5+" initial-heap-size="300m" max-heap-size="600m"/>
3429 <jar href="findbugs.jar"/>
3530 - <jar href="AppleJavaExtensions.jar"/>
36 - <jar href="bcel.jar"/>
31 <jar href="bcel.jar"/>
3732 - <jar href="dom4j-1.6.1.jar"/>
3833 - <jar href="asm-3.3.jar"/>
3934 - <jar href="asm-tree-3.3.jar"/>
4035 - <jar href="asm-commons-3.3.jar"/>
4136 - <jar href="jaxen-1.1.6.jar"/>
42 + <jar href="bcel.jar"/>
4337 + <jar href="dom4j.jar"/>
44 + <jar href="asm3.jar"/>
45 + <jar href="asm3-tree.jar"/>
46 + <jar href="asm3-commons.jar"/>
38 + <jar href="asm4.jar"/>
39 + <jar href="asm4-tree.jar"/>
40 + <jar href="asm4-commons.jar"/>
4741 + <jar href="jaxen.jar"/>
4842 <jar href="jFormatString.jar"/>
4943 - <jar href="commons-lang-2.6.jar"/>
0 Index: findbugs-2.0.3/etc/script.properties
1 ===================================================================
2 --- findbugs-2.0.3.orig/etc/script.properties 2013-12-17 21:48:57.158141458 +0800
3 +++ findbugs-2.0.3/etc/script.properties 2013-12-17 21:50:54.722140536 +0800
0 --- a/etc/script.properties
1 +++ b/etc/script.properties
42 @@ -76,6 +76,9 @@
53 # This should be done before executing any code that
64 # could override fb_javacmd.
75 script.set.default.java=\
86 + . /usr/lib/java-wrappers/java-wrappers.sh\n\
9 + find_jars dom4j junit4 commons-lang jaxen jdepend asm3 asm3-commons asm3-tree ant jcip jsr305 jFormatString bcel\n\
7 + find_jars dom4j junit4 commons-lang jaxen jdepend asm4 asm4-commons asm4-tree ant jcip jsr305 jFormatString bcel\n\
108 + export CLASSPATH=$JAVA_CLASSPATH\n\
119 # Choose default java binary\n\
1210 fb_javacmd=java\n\
0 Index: findbugs-2.0.3/src/java/edu/umd/cs/findbugs/ShowHelp.java
1 ===================================================================
2 --- findbugs-2.0.3.orig/src/java/edu/umd/cs/findbugs/ShowHelp.java 2011-12-20 16:16:10.000000000 +0800
3 +++ findbugs-2.0.3/src/java/edu/umd/cs/findbugs/ShowHelp.java 2013-12-17 20:42:32.742172610 +0800
4 @@ -32,14 +32,21 @@
5 System.out.println("FindBugs version " + Version.RELEASE + ", " + Version.WEBSITE);
6
7 DetectorFactoryCollection.instance();
8 - System.out.println("Command line options");
9 + //System.out.println("Command line options:");
10
11 TreeSet<FindBugsMain> cmds = new TreeSet<FindBugsMain>();
12 for(Plugin p : Plugin.getAllPlugins())
13 for(FindBugsMain m : p.getAllFindBugsMain())
14 cmds.add(m);
15 - for(FindBugsMain m : cmds)
16 - System.out.printf("fb %-12s %-12s %s%n", m.cmd, m.kind, m.description);
17 + boolean isFirst=true;
18 + for(FindBugsMain m : cmds){
19 + if (isFirst)
20 + System.out.printf("Usage: ");
21 + else
22 + System.out.printf("or: ");
23 + System.out.printf("fb %-12s %-12s %s%n", m.cmd, m.kind, m.description);
24 + isFirst=false;
25 + }
26
27 // System.out.println();
28 // System.out.println("GUI Options:");
22 @@ -1,3 +1,3 @@
33 Manifest-Version: 1.0
44 Main-Class: edu.umd.cs.findbugs.LaunchAppropriateUI
5 -Class-Path: bcel.jar dom4j-1.6.1.jar jaxen-1.1.6.jar asm-3.3.jar asm-tree-3.3.jar asm-commons-3.3.jar jsr305.jar jFormatString.jar commons-lang-2.6.jar plastic.jar
6 +Class-Path: bcel.jar dom4j.jar jaxen.jar asm3.jar asm3-tree.jar asm3-commons.jar jsr305.jar jFormatString.jar commons-lang.jar plastic.jar
5 -Class-Path: bcel-6.0-SNAPSHOT.jar dom4j-1.6.1.jar jaxen-1.1.6.jar asm-debug-all-5.0.2.jar jsr305.jar jFormatString.jar commons-lang-2.6.jar plastic.jar
6 +Class-Path: bcel.jar dom4j.jar jaxen.jar asm4.jar asm4-tree.jar asm4-commons.jar jsr305.jar jFormatString.jar commons-lang.jar plastic.jar
77 --- a/etc/MANIFEST-findbugs.MF
88 +++ b/etc/MANIFEST-findbugs.MF
99 @@ -1,3 +1,3 @@
1010 Manifest-Version: 1.0
1111 Main-Class: edu.umd.cs.findbugs.LaunchAppropriateUI
12 -Class-Path: bcel.jar dom4j-1.6.1.jar jaxen-1.1.6.jar asm-3.3.jar asm-tree-3.3.jar asm-commons-3.3.jar jsr305.jar jFormatString.jar commons-lang-2.6.jar
13 +Class-Path: bcel.jar dom4j.jar jaxen.jar asm3.jar asm3-tree.jar asm3-commons.jar jsr305.jar jFormatString.jar commons-lang.jar
12 -Class-Path: bcel-6.0-SNAPSHOT.jar dom4j-1.6.1.jar jaxen-1.1.6.jar asm-debug-all-5.0.2.jar jsr305.jar jFormatString.jar commons-lang-2.6.jar
13 +Class-Path: bcel.jar dom4j.jar jaxen.jar asm4.jar asm4-tree.jar asm4-commons.jar jsr305.jar jFormatString.jar commons-lang.jar
11 Author: James Page <jamespage@debian.org>
22 Forwarded: no
33
4 --- a/src/doc/manual_ja.xml
5 +++ b/src/doc/manual_ja.xml
6 @@ -1,6 +1,5 @@
7 <?xml version="1.0" encoding="UTF-8"?>
8 -<!DOCTYPE book PUBLIC "-//OASIS//DTD DocBook XML V4.2//EN" "http://findbugs.googlecode.com/svn/trunk/findbugs/etc/docbook/docbookx.dtd"
9 -[
10 +<!DOCTYPE book PUBLIC "-//OASIS//DTD DocBook XML V4.2//EN" "file:../../etc/docbook/docbookx.dtd" [
11 <!ENTITY FindBugs "<application>FindBugs</application>">
12 <!ENTITY Ant "<application>Ant</application>">
13 <!ENTITY Saxon "<application>Saxon</application>">
1919 * clone() is overridden to change access control from protected to public.
2020 --- a/src/java/edu/umd/cs/findbugs/ba/AbstractFrameModelingVisitor.java
2121 +++ b/src/java/edu/umd/cs/findbugs/ba/AbstractFrameModelingVisitor.java
22 @@ -265,6 +265,9 @@
22 @@ -297,6 +297,9 @@
2323 public void visitStackConsumer(StackConsumer obj) {
2424 }
2525
2929 /*
3030 * ----------------------------------------------------------------------
3131 * General instruction handlers
32 @@ -1084,6 +1087,10 @@
33 public void visitFADD(FADD obj) {
34 handleNormalInstruction(obj);
35 }
36 +
37 + public void visitINVOKEDYNAMIC(INVOKEDYNAMIC obj) {
38 + handleNormalInstruction(obj);
39 + }
40 }
41
42 // vim:ts=4
0 --- a/src/java/edu/umd/cs/findbugs/ba/AbstractFrameModelingVisitor.java
1 +++ b/src/java/edu/umd/cs/findbugs/ba/AbstractFrameModelingVisitor.java
2 @@ -50,7 +50,7 @@
3 * @see Frame
4 * @see DataflowAnalysis
5 */
6 -public abstract class AbstractFrameModelingVisitor<Value, FrameType extends Frame<Value>> implements VisitorSupportsInvokeDynamic {
7 +public abstract class AbstractFrameModelingVisitor<Value, FrameType extends Frame<Value>> implements Visitor {
8 private FrameType frame;
9
10 private Location location;
11 --- a/src/java/edu/umd/cs/findbugs/visitclass/BetterVisitor.java
12 +++ b/src/java/edu/umd/cs/findbugs/visitclass/BetterVisitor.java
13 @@ -50,6 +50,7 @@
14 import org.apache.bcel.classfile.LocalVariableTable;
15 import org.apache.bcel.classfile.LocalVariableTypeTable;
16 import org.apache.bcel.classfile.Method;
17 +import org.apache.bcel.classfile.MethodParameters;
18 import org.apache.bcel.classfile.Signature;
19 import org.apache.bcel.classfile.SourceFile;
20 import org.apache.bcel.classfile.StackMap;
21 @@ -352,6 +353,11 @@
22 }
23
24 @Override
25 + public void visitMethodParameters(MethodParameters obj) {
26 + // TODO: should we do something here - implement visit(MethodParameters)
27 + }
28 +
29 + @Override
30 public void visitSignature(Signature obj) {
31 visit(obj);
32 }
0 --- a/src/java/edu/umd/cs/findbugs/detect/CheckRelaxingNullnessAnnotation.java
1 +++ b/src/java/edu/umd/cs/findbugs/detect/CheckRelaxingNullnessAnnotation.java
2 @@ -202,7 +202,8 @@
3 bug.addClassAndMethod(xmethod);
4 LocalVariableAnnotation lva = null;
5 if (localVariables != null) {
6 - for(LocalVariableNode lvn : localVariables) {
7 + for(Object obj : localVariables) {
8 + LocalVariableNode lvn = (LocalVariableNode)obj;
9 if (lvn.index == i+1) {
10 lva = new LocalVariableAnnotation(lvn.name, i+1, 0);
11 lva.setDescription(LocalVariableAnnotation.PARAMETER_NAMED_ROLE);
0 --- a/build.xml
1 +++ b/build.xml
2 @@ -78,6 +78,7 @@
3 <pathelement location="${classes.dir}"/>
4 <pathelement location="${jar.dir}/findbugs.jar"/>
5 <pathelement location="${sys.jar.dir}/jdepend.jar"/>
6 + <pathelement location="${sys.jar.dir}/jaxen.jar"/>
7 <path refid="findbugs.classpath"/>
8 </path>
9
10 @@ -597,7 +598,7 @@
11 <echo>Running JUnit test cases for FindBugs, results will be in: ${junit.dir}</echo>
12 <delete dir="${junit.dir}"/>
13 <mkdir dir="${junit.dir}"/>
14 - <junit fork="yes" printsummary="true" haltonfailure="true" haltonerror="true" dir="${basedir}">
15 + <junit fork="yes" showoutput="true" printsummary="true" haltonfailure="true" haltonerror="true" dir="${basedir}">
16 <jvmarg value="-ea"/>
17 <jvmarg value="-Xmx1200m"/>
18 <jvmarg value="-Dfindbugs.home=${basedir}"/>
11 0002-FixJnlpLibraryDir.patch
22 0003-UseGTKLook.patch
33 0004-FixLibraryInScriptProperties.patch
4 0005-FixShowHelpInFindbugs.patch
4 #0005-FixShowHelpInFindbugs.patch
55 0006-FixLibraryPathInJavaDoc.patch
66 0007-FixManifest.patch
7 0008-fix-docbook-ref.patch
7 #0008-fix-docbook-ref.patch
88 0009-bcel-compatibility.patch
9 0010-bcel-for-version3.patch
10 0011-typecast.patch
11 0012-verbose-tests.patch