Codebase list golang-github-go-kit-kit / 4d9f525
do not prefix metrics with 'p', just like it was previously. Eric Feliksik 6 years ago
2 changed file(s) with 5 addition(s) and 5 deletion(s). Raw diff Collapse all Expand all
+1
-1
metrics/cloudwatch/cloudwatch.go less more
195195 for _, perc := range cw.percentiles {
196196 value := histogram.Quantile(perc)
197197 datums = append(datums, &cloudwatch.MetricDatum{
198 MetricName: aws.String(fmt.Sprintf("%s_p%s", name, formatPerc(perc))),
198 MetricName: aws.String(fmt.Sprintf("%s_%s", name, formatPerc(perc))),
199199 Dimensions: makeDimensions(lvs...),
200200 Value: aws.Float64(value),
201201 Timestamp: aws.Time(now),
+4
-4
metrics/cloudwatch/cloudwatch_test.go less more
160160 svc := newMockCloudWatch()
161161 cw := New(namespace, svc, WithLogger(log.NewNopLogger()))
162162 histogram := cw.NewHistogram(name).With(label, value)
163 n50 := fmt.Sprintf("%s_p50", name)
164 n90 := fmt.Sprintf("%s_p90", name)
165 n95 := fmt.Sprintf("%s_p95", name)
166 n99 := fmt.Sprintf("%s_p99", name)
163 n50 := fmt.Sprintf("%s_50", name)
164 n90 := fmt.Sprintf("%s_90", name)
165 n95 := fmt.Sprintf("%s_95", name)
166 n99 := fmt.Sprintf("%s_99", name)
167167 quantiles := func() (p50, p90, p95, p99 float64) {
168168 err := cw.Send()
169169 if err != nil {