Commit 5a8ac0382ea5c7a109274b656ae8c68adcb56241 - golang-github-go-kit-kit

don't encode json response with http.StatusNoContent 204 status cannot contain a message body: https://tools.ietf.org/html/rfc7231#page-53 Closes #435 Victor Vrantchan 7 years ago

2 changed file(s) with 31 addition(s) and 0 deletion(s). Raw diff Collapse all Expand all

-0

transport/http/server.go less more

150	150	code = sc.StatusCode()
151	151	}
152	152	w.WriteHeader(code)
	153	if code == http.StatusNoContent {
	154	return nil
	155	}
153	156	return json.NewEncoder(w).Encode(response)
154	157	}
155	158

+28

-0

transport/http/server_test.go less more

153	153	buf, _ := ioutil.ReadAll(resp.Body)
154	154	if want, have := `{"foo":"bar"}`, strings.TrimSpace(string(buf)); want != have {
155	155	t.Errorf("Body: want %s, have %s", want, have)
	156	}
	157	}
	158
	159	type noContentResponse struct{}
	160
	161	func (e noContentResponse) StatusCode() int { return http.StatusNoContent }
	162
	163	func TestEncodeNoContent(t *testing.T) {
	164	handler := httptransport.NewServer(
	165	context.Background(),
	166	func(context.Context, interface{}) (interface{}, error) { return noContentResponse{}, nil },
	167	func(context.Context, *http.Request) (interface{}, error) { return struct{}{}, nil },
	168	httptransport.EncodeJSONResponse,
	169	)
	170
	171	server := httptest.NewServer(handler)
	172	defer server.Close()
	173
	174	resp, err := http.Get(server.URL)
	175	if err != nil {
	176	t.Fatal(err)
	177	}
	178	if want, have := http.StatusNoContent, resp.StatusCode; want != have {
	179	t.Errorf("StatusCode: want %d, have %d", want, have)
	180	}
	181	buf, _ := ioutil.ReadAll(resp.Body)
	182	if want, have := 0, len(buf); want != have {
	183	t.Errorf("Body: want no content, have %d bytes", have)
156	184	}
157	185	}
158	186