Codebase list golang-github-go-kit-kit / d5a7c56
Remove redundant statements in profilesvc example (#721) In the profilesvc example, both the request method and URL path are set in each specific encoder. This is not required for the request method as that is specified correctly in the call to `httptransport.NewClient`. Suhas Karanth authored 5 years ago Peter Bourgon committed 5 years ago
2 changed file(s) with 11 addition(s) and 11 deletion(s). Raw diff Collapse all Expand all
+2
-2
examples/profilesvc/endpoints.go less more
6767 options := []httptransport.ClientOption{}
6868
6969 // Note that the request encoders need to modify the request URL, changing
70 // the path and method. That's fine: we simply need to provide specific
71 // encoders for each endpoint.
70 // the path. That's fine: we simply need to provide specific encoders for
71 // each endpoint.
7272
7373 return Endpoints{
7474 PostProfileEndpoint: httptransport.NewClient("POST", tgt, encodePostProfileRequest, decodePostProfileResponse, options...).Endpoint(),
+9
-9
examples/profilesvc/transport.go less more
216216
217217 func encodePostProfileRequest(ctx context.Context, req *http.Request, request interface{}) error {
218218 // r.Methods("POST").Path("/profiles/")
219 req.Method, req.URL.Path = "POST", "/profiles/"
219 req.URL.Path = "/profiles/"
220220 return encodeRequest(ctx, req, request)
221221 }
222222
224224 // r.Methods("GET").Path("/profiles/{id}")
225225 r := request.(getProfileRequest)
226226 profileID := url.QueryEscape(r.ID)
227 req.Method, req.URL.Path = "GET", "/profiles/"+profileID
227 req.URL.Path = "/profiles/" + profileID
228228 return encodeRequest(ctx, req, request)
229229 }
230230
232232 // r.Methods("PUT").Path("/profiles/{id}")
233233 r := request.(putProfileRequest)
234234 profileID := url.QueryEscape(r.ID)
235 req.Method, req.URL.Path = "PUT", "/profiles/"+profileID
235 req.URL.Path = "/profiles/" + profileID
236236 return encodeRequest(ctx, req, request)
237237 }
238238
240240 // r.Methods("PATCH").Path("/profiles/{id}")
241241 r := request.(patchProfileRequest)
242242 profileID := url.QueryEscape(r.ID)
243 req.Method, req.URL.Path = "PATCH", "/profiles/"+profileID
243 req.URL.Path = "/profiles/" + profileID
244244 return encodeRequest(ctx, req, request)
245245 }
246246
248248 // r.Methods("DELETE").Path("/profiles/{id}")
249249 r := request.(deleteProfileRequest)
250250 profileID := url.QueryEscape(r.ID)
251 req.Method, req.URL.Path = "DELETE", "/profiles/"+profileID
251 req.URL.Path = "/profiles/" + profileID
252252 return encodeRequest(ctx, req, request)
253253 }
254254
256256 // r.Methods("GET").Path("/profiles/{id}/addresses/")
257257 r := request.(getAddressesRequest)
258258 profileID := url.QueryEscape(r.ProfileID)
259 req.Method, req.URL.Path = "GET", "/profiles/"+profileID+"/addresses/"
259 req.URL.Path = "/profiles/" + profileID + "/addresses/"
260260 return encodeRequest(ctx, req, request)
261261 }
262262
265265 r := request.(getAddressRequest)
266266 profileID := url.QueryEscape(r.ProfileID)
267267 addressID := url.QueryEscape(r.AddressID)
268 req.Method, req.URL.Path = "GET", "/profiles/"+profileID+"/addresses/"+addressID
268 req.URL.Path = "/profiles/" + profileID + "/addresses/" + addressID
269269 return encodeRequest(ctx, req, request)
270270 }
271271
273273 // r.Methods("POST").Path("/profiles/{id}/addresses/")
274274 r := request.(postAddressRequest)
275275 profileID := url.QueryEscape(r.ProfileID)
276 req.Method, req.URL.Path = "POST", "/profiles/"+profileID+"/addresses/"
276 req.URL.Path = "/profiles/" + profileID + "/addresses/"
277277 return encodeRequest(ctx, req, request)
278278 }
279279
282282 r := request.(deleteAddressRequest)
283283 profileID := url.QueryEscape(r.ProfileID)
284284 addressID := url.QueryEscape(r.AddressID)
285 req.Method, req.URL.Path = "DELETE", "/profiles/"+profileID+"/addresses/"+addressID
285 req.URL.Path = "/profiles/" + profileID + "/addresses/" + addressID
286286 return encodeRequest(ctx, req, request)
287287 }
288288