Codebase list golang-github-vbauerster-mpb / 232c706
refactoring: select on b.ctx.Done() Select on b.ctx.Done() where there is no need to access b.bs afterwards. Vladimir Bauer 1 year, 10 months ago
1 changed file(s) with 13 addition(s) and 13 deletion(s). Raw diff Collapse all Expand all
+13
-13
bar.go less more
9494 select {
9595 case b.operateState <- func(s *bState) { result <- len(s.ewmaDecorators) != 0 }:
9696 return newProxyReader(r, b, <-result)
97 case <-b.done:
97 case <-b.ctx.Done():
9898 return nil
9999 }
100100 }
110110 select {
111111 case b.operateState <- func(s *bState) { result <- len(s.ewmaDecorators) != 0 }:
112112 return newProxyWriter(w, b, <-result)
113 case <-b.done:
113 case <-b.ctx.Done():
114114 return nil
115115 }
116116 }
150150 s.refill = s.current
151151 }
152152 }:
153 case <-b.done:
153 case <-b.ctx.Done():
154154 }
155155 }
156156
169169 for d := range iter {
170170 cb(unwrap(d))
171171 }
172 case <-b.done:
172 case <-b.ctx.Done():
173173 }
174174 }
175175
190190 s.triggerComplete = true
191191 }
192192 }:
193 case <-b.done:
193 case <-b.ctx.Done():
194194 }
195195 }
196196
216216 b.triggerCompletion(s)
217217 }
218218 }:
219 case <-b.done:
219 case <-b.ctx.Done():
220220 }
221221 }
222222
234234 b.triggerCompletion(s)
235235 }
236236 }:
237 case <-b.done:
237 case <-b.ctx.Done():
238238 }
239239 }
240240
254254 b.triggerCompletion(s)
255255 }
256256 }:
257 case <-b.done:
257 case <-b.ctx.Done():
258258 }
259259 }
260260
279279 b.triggerCompletion(s)
280280 }
281281 }:
282 case <-b.done:
282 case <-b.ctx.Done():
283283 }
284284 }
285285
306306 b.triggerCompletion(s)
307307 }
308308 }:
309 case <-b.done:
309 case <-b.ctx.Done():
310310 }
311311 }
312312
316316 func (b *Bar) DecoratorAverageAdjust(start time.Time) {
317317 select {
318318 case b.operateState <- func(s *bState) { s.decoratorAverageAdjust(start) }:
319 case <-b.done:
319 case <-b.ctx.Done():
320320 }
321321 }
322322
341341 s.rmOnComplete = drop
342342 b.triggerCompletion(s)
343343 }:
344 case <-b.done:
344 case <-b.ctx.Done():
345345 }
346346 }
347347
379379
380380 // Wait blocks until bar is completed or aborted.
381381 func (b *Bar) Wait() {
382 <-b.done
382 <-b.ctx.Done()
383383 }
384384
385385 func (b *Bar) serve(bs *bState) {