Codebase list golang-golang-x-sys / e0b2ad0
unix: fix finalizer fd close bug in TestOpenByHandleAt The raw fd is successively wrapped using os.NewFile, so dont defer close the raw fd, but instead use (*os.File).Close. Fixes golang/go#49403 Change-Id: I1f4b12536ff0abea6b1680a4ff932b7eefa57162 Reviewed-on: https://go-review.googlesource.com/c/sys/+/361995 Trust: Tobias Klauser <tobias.klauser@gmail.com> Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> Tobias Klauser authored 2 years ago Tobias Klauser committed 2 years ago
1 changed file(s) with 2 addition(s) and 2 deletion(s). Raw diff Collapse all Expand all
+2
-2
unix/syscall_linux_test.go less more
719719 if err != nil {
720720 t.Fatalf("OpenByHandleAt: %v", err)
721721 }
722 defer unix.Close(fd)
723
724722 t.Logf("opened fd %v", fd)
725723 f := os.NewFile(uintptr(fd), "")
724 defer f.Close()
725
726726 slurp, err := ioutil.ReadAll(f)
727727 if err != nil {
728728 t.Fatal(err)