0 | |
Author: Diane Trout <diane@ghic.org>
|
1 | |
Description: some of the qml signal conections were wrong.
|
2 | |
call-window.cpp: Properly use rootObject for attaching signals
|
3 | |
between C++ & QML.
|
4 | |
Connect showDtmfAction signal to toggleDtmf.
|
5 | |
ToggleButton.qml: use root.checked instead of non-existant
|
6 | |
function root.activate
|
7 | |
Fix doubled // in pathname.
|
8 | |
Applied-Upstream: commit fc0392318f89b22d89e20cd66abd09b265768be9
|
9 | |
--- a/src/call-window.cpp
|
10 | |
+++ b/src/call-window.cpp
|
11 | |
@@ -237,12 +237,15 @@ void CallWindow::onContentAdded(CallContentHandler *contentHandler)
|
12 | |
|
13 | |
checkEnableDtmf();
|
14 | |
|
15 | |
+ // grab root object so we can access QML signals.
|
16 | |
+ QObject *root = d->qmlUi->rootObject();
|
17 | |
+
|
18 | |
VolumeController *vol = audioContentHandler->inputVolumeControl();
|
19 | |
d->muteAction->setEnabled(vol->volumeControlSupported());
|
20 | |
connect(vol, SIGNAL(volumeControlSupportedChanged(bool)),
|
21 | |
d->muteAction, SLOT(setEnabled(bool)));
|
22 | |
connect(vol, SIGNAL(volumeControlSupportedChanged(bool)),
|
23 | |
- d->qmlUi, SLOT(setSoundEnabled(bool)));
|
24 | |
+ root, SLOT(setSoundEnabled(bool)));
|
25 | |
d->muteAction->setChecked(vol->isMuted());
|
26 | |
connect(vol, SIGNAL(mutedChanged(bool)), d->muteAction, SLOT(setChecked(bool)));
|
27 | |
d->muteAction->setProperty("volumeController", QVariant::fromValue<QObject*>(vol));
|
28 | |
@@ -369,6 +372,7 @@ void CallWindow::setupActions()
|
29 | |
d->showDtmfAction = new KToggleAction(i18nc("@action", "Show dialpad"), this);
|
30 | |
d->showDtmfAction->setIcon(KIcon("phone"));
|
31 | |
d->showDtmfAction->setEnabled(false);
|
32 | |
+ connect(d->showDtmfAction, SIGNAL(toggled(bool)), SLOT(toggleDtmf(bool)));
|
33 | |
actionCollection()->addAction("showDtmf", d->showDtmfAction);
|
34 | |
|
35 | |
d->goToSystemTrayAction = new KAction(i18nc("@action", "Hide window"), this);
|
36 | |
@@ -608,11 +612,11 @@ void CallWindow::setupQmlUi()
|
37 | |
//QML-UI <---> Actions
|
38 | |
//Show dialpad
|
39 | |
connect(root, SIGNAL(showDialpadClicked(bool)), SLOT(toggleDtmf(bool)));
|
40 | |
- connect(d->showDtmfAction, SIGNAL(toggled(bool)), d->qmlUi, SIGNAL(showDialpadChangeState(bool)));
|
41 | |
+ connect(d->showDtmfAction, SIGNAL(toggled(bool)), root, SIGNAL(showDialpadChangeState(bool)));
|
42 | |
connect(root, SIGNAL(showDialpadClicked(bool)), d->showDtmfAction, SLOT(setChecked(bool)));
|
43 | |
//Mute <-> Sound activated
|
44 | |
connect(root,SIGNAL(muteClicked(bool)), SLOT(toggleMute(bool)));
|
45 | |
- connect(d->muteAction, SIGNAL(toggled(bool)), d->qmlUi, SIGNAL(soundChangeState(bool)));
|
46 | |
+ connect(d->muteAction, SIGNAL(toggled(bool)), root, SIGNAL(muteClicked(bool)));
|
47 | |
connect(root,SIGNAL(muteClicked(bool)), d->muteAction, SLOT(setChecked(bool)));
|
48 | |
//Hold
|
49 | |
connect(root,SIGNAL(holdClicked()),SLOT(hold()));
|
50 | |
diff --git a/src/qml/core/ToggleButton.qml b/src/qml/core/ToggleButton.qml
|
51 | |
index 8ca1e65..c760944 100644
|
52 | |
--- a/src/qml/core/ToggleButton.qml
|
53 | |
+++ b/src/qml/core/ToggleButton.qml
|
54 | |
@@ -76,11 +76,11 @@ Item {
|
55 | |
onClicked: {
|
56 | |
if (root.enabled) {
|
57 | |
if (activated.state == "checked") {
|
58 | |
- root.buttonClick(false);
|
59 | |
- root.activate(false);
|
60 | |
+ root.buttonClick(false)
|
61 | |
+ root.checked = false
|
62 | |
} else {
|
63 | |
root.buttonClick(true)
|
64 | |
- root.activate(true)
|
65 | |
+ root.checked = true
|
66 | |
}
|
67 | |
}
|
68 | |
}
|
69 | |
diff --git a/src/qml/core/Toolbar.qml b/src/qml/core/Toolbar.qml
|
70 | |
index 18fb3fc..7192ea9 100644
|
71 | |
--- a/src/qml/core/Toolbar.qml
|
72 | |
+++ b/src/qml/core/Toolbar.qml
|
73 | |
@@ -36,7 +36,7 @@ Item {
|
74 | |
if (icon == "start") {
|
75 | |
hold.iconSource= "image://icon/media-playback-start.png"
|
76 | |
} else {
|
77 | |
- hold.iconSource= "image://icon//media-playback-pause.png"
|
78 | |
+ hold.iconSource= "image://icon/media-playback-pause.png"
|
79 | |
}
|
80 | |
}
|
81 | |
|