Codebase list mozc / 86432d5
Remove an incorrect conversion from HKL to LANGID This CL fixes the following warning C4302: 'reinterpret_cast': truncation from 'HKL' to 'LANGID' by removing the code in question. This is actually an unintentional operation, which was introduced for a long time ago. KLID and HKL are two different concepts. Converting one with reinterpret_cast to the other is indeed an mistake. That said, the impact on this code in question is supposed to be limited, because it is only used for an early exit path. The likelihood of accidentally falling into that path is not so high. BUG= TEST= REF_BUG=26932823 REF_CL=114656281 REF_TIME=2016-02-14T17:44:54-08:00 REF_TIME_RAW=1455500694 -0800 Yohei Yukawa 8 years ago
2 changed file(s) with 1 addition(s) and 9 deletion(s). Raw diff Collapse all Expand all
00 MAJOR=2
11 MINOR=17
2 BUILD=2483
2 BUILD=2484
33 REVISION=102
44 # NACL_DICTIONARY_VERSION is the target version of the system dictionary to be
55 # downloaded by NaCl Mozc.
198198 LOG(ERROR) << "SystemParameterInfo failed: " << GetLastError();
199199 return false;
200200 }
201 const LANGID langage_id = reinterpret_cast<LANGID>(hkl);
202 const LANGID kJapaneseLangID =
203 MAKELANGID(LANG_JAPANESE, SUBLANG_JAPANESE_JAPAN);
204
205 if (langage_id != kJapaneseLangID) {
206 return false;
207 }
208
209201 return ImmRegistrar::IsIME(hkl, ImmRegistrar::GetFileNameForIME());
210202 }
211203