const void* overload of StringPiece::set must die
This mutator must be removed. It is the only way to get a negative
length into a StringPiece without triggering an assert, it hides a
reinterpret_cast that should be visible at call sites, and it isn't
present in std::string_view.
BUG=
TEST=
REF_BUG=30675259
REF_CL=129656305
REF_TIME=2016-08-08T12:03:11-07:00
REF_TIME_RAW=1470682991 -0700
Yohei Yukawa
7 years ago
| 0 | 0 |
MAJOR=2
|
| 1 | 1 |
MINOR=18
|
| 2 | |
BUILD=2589
|
|
2 |
BUILD=2590
|
| 3 | 3 |
REVISION=102
|
| 4 | 4 |
# CAUTION: NACL_DICTIONARY_VERSION is going to be migrated to ENGINE_VERSION.
|
| 5 | 5 |
# NACL_DICTIONARY_VERSION is the target version of the system dictionary to be
|
| 160 | 160 |
}
|
| 161 | 161 |
output_token_array_buf->reset(new uint32[(buf.size() + 3) / 4]);
|
| 162 | 162 |
memcpy(output_token_array_buf->get(), buf.data(), buf.size());
|
| 163 | |
token_array.set(output_token_array_buf->get(), buf.size());
|
|
163 |
token_array = StringPiece(
|
|
164 |
reinterpret_cast<const char*>(output_token_array_buf->get()),
|
|
165 |
buf.size());
|
| 164 | 166 |
}
|
| 165 | 167 |
|
| 166 | 168 |
// Build a string array.
|