Codebase list mozc / cfe5f66
Fix a runtime error on Android OSS build This is a follow up CL to 1aa25f461b823a43b1b92e4c4234a5bb0d0f2a80, which broke OSS build. Closes #432. Closed #434. BUG=#432, #434 TEST=manually done REF_BUG=71956804 REF_CL=186248754 REF_TIME=2018-02-20T10:19:45+09:00 REF_TIME_RAW=1519089585 +0900 Hiroyuki Komatsu 6 years ago
2 changed file(s) with 13 addition(s) and 1 deletion(s). Raw diff Collapse all Expand all
5454 #if !defined(MOZC_USE_CUSTOM_DATA_MANAGER)
5555 // Use plain DataManager, which needs to be manually initialized.
5656 using TargetDataManager = ::mozc::DataManager;
57 constexpr bool kEmbeddedData = false;
58
59
5760 #else
5861 // Use OssDataManager, which is embedding data by default.
5962 #include "data_manager/oss/oss_data_manager.h"
6063 using TargetDataManager = ::mozc::oss::OssDataManager;
64 constexpr bool kEmbeddedData = true;
65
6166 #endif
6267
6368 namespace mozc {
124129
125130 std::unique_ptr<DataManager> CreateDataManager(JNIEnv *env,
126131 jstring j_data_file_path) {
132 if (kEmbeddedData) {
133 // If the data manager uses embedded data like OSS version,
134 // j_data_file_path is validly nullptr.
135 std::unique_ptr<DataManager> data_manager(new TargetDataManager());
136 return data_manager;
137 }
138
127139 if (j_data_file_path == nullptr) {
128140 return nullptr;
129141 }
2929
3030 MAJOR=2
3131 MINOR=23
32 BUILD=2809
32 BUILD=2810
3333 REVISION=102
3434 # This version represents the version of Mozc IME engine (converter, predictor,
3535 # etc.). This version info is included both in the Mozc server and in the Mozc