Import upstream version 1.2.2+git20210825.1.dcc96cb
Debian Janitor
2 years ago
|
0 |
Please use a dedicated feature branch. This is why:
|
|
1 |
|
|
2 |
https://github.com/magit/magit/wiki/Dedicated-pull-request-branches
|
|
3 |
|
|
4 |
Please try to follow the conventions.
|
|
5 |
|
|
6 |
https://github.com/tarsius/no-littering#conventions
|
|
7 |
|
|
8 |
In the past the majority of contributors have ignored at least some of the conventions. Others did not fully understand them or had a good reason to depart from the conventions but did not explain why that is so. Unfortunately it is hard for me as the maintainer to tell whether a contributor did not invest enough time to get things right or just forgot to be explicit about their thought process. The result is that a pull request is actually more work for me than a simple "please theme PACKAGE from URL".
|
|
9 |
|
|
10 |
Going forward contributors are expected to follow the conventions more closely from the get-go and to be explicit about their thought process. Adding such statements to commit messages, would be helpful for example:
|
|
11 |
|
|
12 |
- This file is used to store an s-expression.
|
|
13 |
- This file is used to store raw text.
|
|
14 |
- This is the only configuration/data file of the package.
|
|
15 |
- This package does/doesn't take care of creating the containing
|
|
16 |
directory if necessary. (If the package does not do it, then you
|
|
17 |
should also fix that and submit an upstream pull request.)
|
|
18 |
|
|
19 |
Also please link to the repository of the package that your pull request is theming.
|
|
20 |
|
|
21 |
Thanks!
|
|
0 |
/*.elc
|
|
1 |
/*-autoloads.el
|
|
2 |
/.config.mk
|
234 | 234 |
(setq eww-bookmarks-directory (var "eww/"))
|
235 | 235 |
(setq filesets-menu-cache-file (var "filesets-menu-cache.el"))
|
236 | 236 |
(setq gamegrid-user-score-file-directory (var "gamegrid-user-score/"))
|
|
237 |
(eval-after-load 'gnus
|
|
238 |
`(make-directory ,(var "gnus/dribble/") t))
|
|
239 |
(setq gnus-dribble-directory (var "gnus/dribble/"))
|
|
240 |
(setq gnus-init-file (etc "gnus/init.el"))
|
237 | 241 |
(setq ido-save-directory-list-file (var "ido-save-directory-list.el"))
|
238 | 242 |
(setq image-dired-db-file (var "image-dired/db.el"))
|
239 | 243 |
(setq image-dired-dir (var "image-dired/"))
|
|
267 | 271 |
(setq tramp-persistency-file-name (var "tramp/persistency.el"))
|
268 | 272 |
(setq type-break-file-name (var "type-break.el"))
|
269 | 273 |
(setq url-cache-directory (var "url/cache/"))
|
270 | |
(setq url-configuration-directory (var "url/configuration/"))
|
|
274 |
(setq url-configuration-directory (var "url/"))
|
|
275 |
(setq url-cookie-file (var "url/cookies.el"))
|
|
276 |
(setq url-history-file (var "url/history.el"))
|
271 | 277 |
|
272 | 278 |
;;; Third-party packages
|
273 | 279 |
|
|
300 | 306 |
(setq dap-java-test-runner (var "lsp-java/eclipse.jdt.ls/test-runner/junit-platform-console-standalone.jar"))
|
301 | 307 |
(setq dap-utils-extension-path (var "dap/extensions/"))
|
302 | 308 |
(setq debbugs-gnu-persistency-file (var "debbugs.el"))
|
|
309 |
(setq devdocs-browser-cache-directory (var "devdocs/browser-cache/"))
|
|
310 |
(setq devdocs-data-dir (var "devdocs/data/"))
|
303 | 311 |
(setq dired-recent-directories-file (var "dired-recent-directories.el"))
|
304 | 312 |
(setq elbank-data-file (var "elbank-data.el"))
|
305 | 313 |
(setq elmo-msgdb-directory (var "elmo/"))
|