Import upstream version 1.2.3+git20211110.1.4a7bcaf
Debian Janitor
2 years ago
| 0 | Please use a dedicated feature branch. This is why: | |
| 1 | ||
| 2 | https://github.com/magit/magit/wiki/Dedicated-pull-request-branches | |
| 3 | ||
| 4 | Please try to follow the conventions. | |
| 5 | ||
| 6 | https://github.com/tarsius/no-littering#conventions | |
| 7 | ||
| 8 | In the past the majority of contributors have ignored at least some of the conventions. Others did not fully understand them or had a good reason to depart from the conventions but did not explain why that is so. Unfortunately it is hard for me as the maintainer to tell whether a contributor did not invest enough time to get things right or just forgot to be explicit about their thought process. The result is that a pull request is actually more work for me than a simple "please theme PACKAGE from URL". | |
| 9 | ||
| 10 | Going forward contributors are expected to follow the conventions more closely from the get-go and to be explicit about their thought process. Adding such statements to commit messages, would be helpful for example: | |
| 11 | ||
| 12 | - This file is used to store an s-expression. | |
| 13 | - This file is used to store raw text. | |
| 14 | - This is the only configuration/data file of the package. | |
| 15 | - This package does/doesn't take care of creating the containing | |
| 16 | directory if necessary. (If the package does not do it, then you | |
| 17 | should also fix that and submit an upstream pull request.) | |
| 18 | ||
| 19 | Also please link to the repository of the package that your pull request is theming. | |
| 20 | ||
| 21 | Thanks! |
| 254 | 254 | `(make-directory ,(var "org/") t)) |
| 255 | 255 | (setq org-clock-persist-file (var "org/clock-persist.el")) |
| 256 | 256 | (setq org-id-locations-file (var "org/id-locations.el")) |
| 257 | (setq org-persist-directory (var "org/persist/")) | |
| 257 | 258 | (setq org-publish-timestamp-directory (var "org/timestamps/")) |
| 258 | 259 | (setq project-list-file (var "project-list.el")) |
| 259 | 260 | (setq quickurl-url-file (var "quickurl-url.el")) |
| 265 | 266 | (setq savehist-file (var "savehist.el")) |
| 266 | 267 | (setq srecode-map-save-file (var "srecode-map.el")) |
| 267 | 268 | (setq semanticdb-default-save-directory (var "semantic/")) |
| 269 | (eval-after-load 'shadowfile | |
| 270 | `(make-directory ,(var "shadow/") t)) | |
| 271 | (setq shadow-info-file (var "shadow/info.el")) | |
| 272 | (setq shadow-todo-file (var "shadow/todo.el")) | |
| 268 | 273 | (setq shared-game-score-directory (var "shared-game-score/")) |
| 269 | 274 | (setq timeclock-file (var "timeclock")) |
| 270 | 275 | (setq tramp-auto-save-directory (var "tramp/auto-save/")) |
| 302 | 307 | `(make-directory ,(var "company/") t)) |
| 303 | 308 | (setq company-statistics-file (var "company/statistics.el")) |
| 304 | 309 | (setq company-tabnine-binaries-folder (var "company/tabnine-binaries")) |
| 310 | (setq conventional-changelog-tmp-dir (var "conventional-changelog/")) | |
| 305 | 311 | (setq dap-breakpoints-file (var "dap/breakpoints.el")) |
| 306 | 312 | (setq dap-java-test-runner (var "lsp-java/eclipse.jdt.ls/test-runner/junit-platform-console-standalone.jar")) |
| 307 | 313 | (setq dap-utils-extension-path (var "dap/extensions/")) |