Add strict validation about boolean parameters
This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.
Change-Id: I5d448885136f38b442aeca3feff75e288b00cc0c
Takashi Kajinami
1 year, 1 month ago
| 71 | 71 |
include gnocchi::deps
|
| 72 | 72 |
include gnocchi::policy
|
| 73 | 73 |
|
|
74 |
validate_legacy(Boolean, 'validate_bool', $manage_service)
|
|
75 |
validate_legacy(Boolean, 'validate_bool', $enabled)
|
|
76 |
validate_legacy(Boolean, 'validate_bool', $sync_db)
|
|
77 |
|
| 74 | 78 |
package { 'gnocchi-api':
|
| 75 | 79 |
ensure => $package_ensure,
|
| 76 | 80 |
name => $::gnocchi::params::api_package_name,
|
| 52 | 52 |
|
| 53 | 53 |
include gnocchi::deps
|
| 54 | 54 |
|
|
55 |
validate_legacy(Boolean, 'validate_bool', $manage_service)
|
|
56 |
validate_legacy(Boolean, 'validate_bool', $enabled)
|
|
57 |
|
| 55 | 58 |
gnocchi_config {
|
| 56 | 59 |
'metricd/workers': value => $workers;
|
| 57 | 60 |
'metricd/metric_processing_delay': value => $metric_processing_delay;
|
| 50 | 50 |
|
| 51 | 51 |
include gnocchi::deps
|
| 52 | 52 |
|
|
53 |
validate_legacy(Boolean, 'validate_bool', $manage_service)
|
|
54 |
validate_legacy(Boolean, 'validate_bool', $enabled)
|
|
55 |
|
| 53 | 56 |
package { 'gnocchi-statsd':
|
| 54 | 57 |
ensure => $package_ensure,
|
| 55 | 58 |
name => $::gnocchi::params::statsd_package_name,
|
| 64 | 64 |
|
| 65 | 65 |
include gnocchi::deps
|
| 66 | 66 |
|
|
67 |
validate_legacy(Boolean, 'validate_bool', $manage_rados)
|
|
68 |
|
| 67 | 69 |
if (is_service_default($ceph_keyring) and is_service_default($ceph_secret)) or (! $ceph_keyring and ! $ceph_secret) {
|
| 68 | 70 |
fail('You need to specify either gnocchi::storage::ceph::ceph_keyring or gnocchi::storage::ceph::ceph_secret.')
|
| 69 | 71 |
}
|
| 45 | 45 |
include gnocchi::deps
|
| 46 | 46 |
include gnocchi::params
|
| 47 | 47 |
|
|
48 |
validate_legacy(Boolean, 'validate_bool', $manage_boto3)
|
|
49 |
|
| 48 | 50 |
if $manage_boto3 {
|
| 49 | 51 |
ensure_packages('python-boto3', {
|
| 50 | 52 |
'ensure' => $package_ensure,
|