Commit 2e4a06604297d5b0164c52101bdde17581d361f1 - python-osprofiler

Improve error reporting for Ceilometer driver Currently we print a generic message if something goes wrong with ceilometer client initialization. Adding the exception message to improve the error message printed. Change-Id: I1b0dbb3951875597bfe3d8ef36626cd798e62e09 Vipin Balachandran 6 years ago

2 changed file(s) with 3 addition(s) and 7 deletion(s). Raw diff Collapse all Expand all

-2

osprofiler/drivers/ceilometer.py less more

35	35	if hasattr(e, "http_status") and e.http_status == 401:
36	36	msg = "Invalid OpenStack Identity credentials."
37	37	else:
38		msg = ("Something has gone wrong. See ceilometer logs "
39		"for more details")
	38	msg = "Error occurred while connecting to Ceilometer: %s." % e
40	39	raise exc.CommandError(msg)
41	40
42	41	@classmethod

-5

osprofiler/tests/unit/cmd/test_shell.py less more

144	144	self._test_with_command_error(self._trace_show_cmd(), msg)
145	145
146	146	def test_trace_show_unknown_error(self):
147		class FakeException(Exception):
148		pass
149
150		self.ceiloclient.client.get_client.side_effect = FakeException
151		msg = "Something has gone wrong. See ceilometer logs for more details"
	147	self.ceiloclient.client.get_client.side_effect = Exception("test")
	148	msg = "Error occurred while connecting to Ceilometer: test."
152	149	self._test_with_command_error(self._trace_show_cmd(), msg)
153	150
154	151	@mock.patch("osprofiler.drivers.ceilometer.Ceilometer.get_report")