Commit 2de8e138d4233624d419c09d0b47d6b347c87d19 - ruby-omniauth-facebook

[skip ci] Unify ENV name to "FACEBOOK_KEY" and "FACEBOOK_SECRET" (#328) * Use "FACEBOOK_APP_ID" and "FACEBOOK_APP_SECRET" in README "APP_ID" is not a good name since users might use more than two auth providers and then it doesn't make sense. "FACEBOOK_APP_ID" and "FACEBOOK_APP_SECRET" is more reasonable. * Rename ENV in examples as well OKURA Masafumi authored 3 years ago Josef Šimánek committed 3 years ago

3 changed file(s) with 5 addition(s) and 5 deletion(s). Raw diff Collapse all Expand all

-3

README.md less more

25	25
26	26	```ruby
27	27	Rails.application.config.middleware.use OmniAuth::Builder do
28		provider :facebook, ENV['FACEBOOK_KEY'], ENV['FACEBOOK_SECRET']
	28	provider :facebook, ENV['FACEBOOK_APP_ID'], ENV['FACEBOOK_APP_SECRET']
29	29	end
30	30	```
31	31

50	50
51	51	```ruby
52	52	Rails.application.config.middleware.use OmniAuth::Builder do
53		provider :facebook, ENV['APP_ID'], ENV['APP_SECRET'],
	53	provider :facebook, ENV['FACEBOOK_APP_ID'], ENV['FACEBOOK_APP_SECRET'],
54	54	scope: 'email,user_birthday,read_stream', display: 'popup'
55	55	end
56	56	```

61	61
62	62	```ruby
63	63	use OmniAuth::Builder do
64		provider :facebook, ENV['APP_ID'], ENV['APP_SECRET'],
	64	provider :facebook, ENV['FACEBOOK_APP_ID'], ENV['FACEBOOK_APP_SECRET'],
65	65	client_options: {
66	66	site: 'https://graph.facebook.com/v3.0',
67	67	authorize_url: "https://www.facebook.com/v3.0/dialog/oauth"

-1

example/app.rb less more

26	26	<script type="text/javascript">
27	27	window.fbAsyncInit = function() {
28	28	FB.init({
29		appId: '#{ENV['APP_ID']}',
	29	appId: '#{ENV['FACEBOOK_APP_ID']}',
30	30	version: 'v2.10',
31	31	cookie: true // IMPORTANT must enable cookies to allow the server to access the session
32	32	});

-1

example/config.ru less more

4	4	use Rack::Session::Cookie, secret: 'abc123'
5	5
6	6	use OmniAuth::Builder do
7		provider :facebook, ENV['APP_ID'], ENV['APP_SECRET']
	7	provider :facebook, ENV['FACEBOOK_APP_ID'], ENV['FACEBOOK_APP_SECRET']
8	8	end
9	9
10	10	run Sinatra::Application