Codebase list ruby-omniauth-facebook / 8828dea
add tests for removing query string and prep for 3.0.0 release Mark Dodwell 8 years ago
2 changed file(s) with 8 addition(s) and 3 deletion(s). Raw diff Collapse all Expand all
0 ## 2.1.0 (unreleased)
0 ## 3.0.0 (2015-10-26)
11
2 Changes:
3
4 - Remove query string from redirect_uri on callback by default (#221, @gioblu)
25 - Signed request parsing extracted to `OmniAuth::Facebook::SignedRequest` class. (#183, @simi, @Vrael)
36 - Change default value of `info_fields` to `name,email` for the [graph-api-v2.4](https://developers.facebook.com/blog/post/2015/07/08/graph-api-v2.4/). ([#209](https://github.com/mkdynamic/omniauth-facebook/pull/209))
47
2323 end
2424
2525 class CallbackUrlTest < StrategyTestCase
26 test "returns the default callback url" do
26 test "returns the default callback url (omitting querystring)" do
2727 url_base = 'http://auth.request.com'
2828 @request.stubs(:url).returns("#{url_base}/some/page")
2929 strategy.stubs(:script_name).returns('') # as not to depend on Rack env
30 strategy.stubs(:query_string).returns('?foo=bar')
3031 assert_equal "#{url_base}/auth/facebook/callback", strategy.callback_url
3132 end
3233
33 test "returns path from callback_path option" do
34 test "returns path from callback_path option (omitting querystring)" do
3435 @options = { :callback_path => "/auth/FB/done"}
3536 url_base = 'http://auth.request.com'
3637 @request.stubs(:url).returns("#{url_base}/page/path")
3738 strategy.stubs(:script_name).returns('') # as not to depend on Rack env
39 strategy.stubs(:query_string).returns('?foo=bar')
3840 assert_equal "#{url_base}/auth/FB/done", strategy.callback_url
3941 end
4042