Lintian Fixes - gitlab

• QA Page
• Maintainer email: pkg-ruby-extras-maintainers@lists.alioth.debian.org
• Last processed: 2023-05-31T01:32 (took 28m43s)
• Branch URL: https://salsa.debian.org/ruby-team/gitlab.git -b master (taken from version 16.8.4-1)
• Queue position: 131107 (a 55w2d wait)

Schedule a new run

Ready changes

Publish now

Summary

• Update lintian override info to new format: ( mismatched-override )
• Trim trailing whitespace. ( trailing-whitespace )
• Add missing colon in closes line. ( possible-missing-colon-in-closes )
• Set upstream metadata fields: Bug-Database, Bug-Submit, Repository-Browse. ( upstream-metadata-file-is-missing , upstream-metadata-missing-bug-tracking )
• Update standards version to 4.6.2, no changes needed. ( out-of-date-standards-version )
• Replace use of deprecated $ADTTMP with $AUTOPKGTEST_TMP. ( uses-deprecated-adttmp )
• Remove field Section on binary package gitlab-workhorse that duplicates source. ( installable-field-mirrors-source )

Diff

diff --git a/debian/changelog b/debian/changelog
index 04b1f0a399..0927646415 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -397,7 +397,7 @@ gitlab (15.2.2+ds1-1) experimental; urgency=medium
  -- Pirate Praveen <praveen@debian.org>  Sun, 14 Aug 2022 22:23:08 +0530
 
 gitlab (15.1.4+ds1-1) experimental; urgency=medium
-  
+
   [ Pirate Praveen ]
   * Update minimum version of ruby-bootsnap to 1.9.4
   * New upstream version 15.1.3+ds1
@@ -409,7 +409,7 @@ gitlab (15.1.4+ds1-1) experimental; urgency=medium
   * New upstream version 15.1.4+ds1
   * Refresh patches
   * Add debian/salsa-ci.yml
-  * Switched to golang-go from golang-any as work around (Closes #1016217)
+  * Switched to golang-go from golang-any as work around (Closes: #1016217)
   * Install patches directory now present upstream
   * Install more new gems from rubygems.org (packaged versions need update)
   * Update dependencies
diff --git a/debian/control b/debian/control
index a21dce0c48..aebe9639f9 100644
--- a/debian/control
+++ b/debian/control
@@ -69,7 +69,7 @@ Build-Depends: debhelper-compat (= 13),
                libimage-exiftool-perl,
                golang-github-kylelemons-godebug-dev,
                golang-github-cli-browser-dev
-Standards-Version: 4.6.1
+Standards-Version: 4.6.2
 Vcs-Git: https://salsa.debian.org/ruby-team/gitlab.git
 Vcs-Browser: https://salsa.debian.org/ruby-team/gitlab
 Homepage: https://about.gitlab.com/
@@ -568,7 +568,6 @@ Description: git powered software platform to collaborate on code (non-omnibus)
  some of its front end dependencies.
 
 Package: gitlab-workhorse
-Section: net
 Architecture: any
 Depends: ${misc:Depends},
          ${shlibs:Depends}
diff --git a/debian/gitlab.lintian-overrides b/debian/gitlab.lintian-overrides
index 11842207b0..03adb59904 100644
--- a/debian/gitlab.lintian-overrides
+++ b/debian/gitlab.lintian-overrides
@@ -2,17 +2,17 @@
 gitlab: init.d-script-has-unknown-lsb-keyword etc/init.d/gitlab:15 chkconfig
 
 # just an example, not used directly
-gitlab: executable-not-elf-or-script usr/share/gitlab/lib/support/init.d/gitlab.default.example
+gitlab: executable-not-elf-or-script [usr/share/gitlab/lib/support/init.d/gitlab.default.example]
 
 # just an example, not used directly
-gitlab: executable-not-elf-or-script usr/share/gitlab/lib/support/deploy/deploy.sh
+gitlab: executable-not-elf-or-script [usr/share/gitlab/lib/support/deploy/deploy.sh]
 
 # comes from upstream, timestamp will not change on rebuilds
 gitlab: package-contains-timestamped-gzip usr/share/gitlab/spec/fixtures/ci_build_artifacts_metadata.gz
 
 # upgrade handled via apt, script not required
-gitlab: executable-not-elf-or-script usr/share/gitlab/bin/upgrade.rb
-gitlab: executable-not-elf-or-script usr/share/gitlab/bin/ci/upgrade.rb
+gitlab: executable-not-elf-or-script [usr/share/gitlab/bin/upgrade.rb]
+gitlab: executable-not-elf-or-script [usr/share/gitlab/bin/ci/upgrade.rb]
 
 # False-positives: there are no init.d files for those services:
 init.d-script-not-marked-as-conffile etc/init.d/gitlab-sidekiq
diff --git a/debian/source/lintian-overrides b/debian/source/lintian-overrides
index 871842f70c..4a6f9c5a60 100644
--- a/debian/source/lintian-overrides
+++ b/debian/source/lintian-overrides
@@ -1,5 +1,5 @@
 # source is provided as snowplow-javascript-tracker component
-gitlab source: source-is-missing vendor/assets/javascripts/snowplow/sp.js line length is 32154 characters (>512)
+gitlab source: source-is-missing [vendor/assets/javascripts/snowplow/sp.js]
 
 # json evil license is listed as an example
 gitlab source: license-problem-json-evil doc/development/licensing.md
@@ -9,44 +9,44 @@ gitlab source: license-problem-json-evil doc/development/licensing.md
 gitlab source: missing-templates-pot
 
 # False positive
-gitlab source: source-is-missing app/assets/javascripts/editor/editor_lite.js
-gitlab source: source-is-missing spec/javascripts/vue_mr_widget/mock_data.js line length is 518 characters (>512)
-gitlab source: source-is-missing spec/frontend/vue_mr_widget/mock_data.js line length is 518 characters (>512)
-gitlab source: source-is-missing vendor/assets/javascripts/fuzzaldrin-plus.js line length is 480 characters (>256)
-gitlab source: source-is-missing app/assets/javascripts/labels_select.js line length is 407 characters (>256)
-gitlab source: source-is-missing app/assets/javascripts/shortcuts_blob.js line length is 289 characters (>256)
-gitlab source: source-is-missing app/assets/javascripts/shortcuts_dashboard_navigation.js line length is 289 characters (>256)
-gitlab source: source-is-missing app/assets/javascripts/shortcuts_find_file.js line length is 289 characters (>256)
-gitlab source: source-is-missing app/assets/javascripts/shortcuts_issuable.js line length is 289 characters (>256)
-gitlab source: source-is-missing app/assets/javascripts/shortcuts_navigation.js line length is 289 characters (>256)
-gitlab source: source-is-missing app/assets/javascripts/shortcuts_network.js line length is 289 characters (>256)
-gitlab source: source-is-missing spec/javascripts/fixtures/emoji_menu.js line length is 32752 characters (>512)
-gitlab source: source-is-missing app/assets/javascripts/blob/blob_gitignore_selector.js line length is 289 characters (>256)
-gitlab source: source-is-missing app/assets/javascripts/blob/blob_license_selector.js line length is 289 characters (>256)
-gitlab source: source-is-missing app/assets/javascripts/pages/projects/graphs/show/stat_graph_contributors_graph.js line length is 291 characters (>256)
-gitlab source: source-is-missing app/assets/javascripts/issuable_index.js line length is 603 characters (>512)
-gitlab source: source-is-missing spec/javascripts/vue_mr_widget/mock_data.js line length is 546 characters (>512)
-gitlab source: source-is-missing app/assets/javascripts/pages/projects/graphs/show/stat_graph_contributors_graph.js line length is 289 characters (>256)
-gitlab source: source-is-missing spec/javascripts/diffs/mock_data/diff_discussions.js line length is 594 characters (>512)
-gitlab source: source-is-missing app/assets/javascripts/labels_select.js line length is 271 characters (>256)
-gitlab source: source-is-missing spec/javascripts/diffs/mock_data/diff_discussions.js line length is 566 characters (>512)
-gitlab source: source-is-missing app/assets/javascripts/visual_review_toolbar/components/wrapper_icons.js line length is 519 characters (>512)
-gitlab source: source-is-missing spec/frontend/diffs/mock_data/diff_discussions.js line length is 566 characters (>512)
-gitlab source: source-is-missing spec/frontend/monitoring/mock_data.js line length is 774 characters (>512)
+gitlab source: source-is-missing [app/assets/javascripts/editor/editor_lite.js]
+gitlab source: source-is-missing [spec/javascripts/vue_mr_widget/mock_data.js]
+gitlab source: source-is-missing [spec/frontend/vue_mr_widget/mock_data.js]
+gitlab source: source-is-missing [vendor/assets/javascripts/fuzzaldrin-plus.js]
+gitlab source: source-is-missing [app/assets/javascripts/labels_select.js]
+gitlab source: source-is-missing [app/assets/javascripts/shortcuts_blob.js]
+gitlab source: source-is-missing [app/assets/javascripts/shortcuts_dashboard_navigation.js]
+gitlab source: source-is-missing [app/assets/javascripts/shortcuts_find_file.js]
+gitlab source: source-is-missing [app/assets/javascripts/shortcuts_issuable.js]
+gitlab source: source-is-missing [app/assets/javascripts/shortcuts_navigation.js]
+gitlab source: source-is-missing [app/assets/javascripts/shortcuts_network.js]
+gitlab source: source-is-missing [spec/javascripts/fixtures/emoji_menu.js]
+gitlab source: source-is-missing [app/assets/javascripts/blob/blob_gitignore_selector.js]
+gitlab source: source-is-missing [app/assets/javascripts/blob/blob_license_selector.js]
+gitlab source: source-is-missing [app/assets/javascripts/pages/projects/graphs/show/stat_graph_contributors_graph.js]
+gitlab source: source-is-missing [app/assets/javascripts/issuable_index.js]
+gitlab source: source-is-missing [spec/javascripts/vue_mr_widget/mock_data.js]
+gitlab source: source-is-missing [app/assets/javascripts/pages/projects/graphs/show/stat_graph_contributors_graph.js]
+gitlab source: source-is-missing [spec/javascripts/diffs/mock_data/diff_discussions.js]
+gitlab source: source-is-missing [app/assets/javascripts/labels_select.js]
+gitlab source: source-is-missing [spec/javascripts/diffs/mock_data/diff_discussions.js]
+gitlab source: source-is-missing [app/assets/javascripts/visual_review_toolbar/components/wrapper_icons.js]
+gitlab source: source-is-missing [spec/frontend/diffs/mock_data/diff_discussions.js]
+gitlab source: source-is-missing [spec/frontend/monitoring/mock_data.js]
 # unicode data
-gitlab source: source-is-missing app/assets/javascripts/lib/utils/regexp.js line length is 4905 characters (>512)
+gitlab source: source-is-missing [app/assets/javascripts/lib/utils/regexp.js]
 # test data
-gitlab source: source-is-missing spec/fixtures/not_a_png.png
-gitlab source: source-is-missing spec/javascripts/lib/utils/mock_data.js line length is 2173 characters (>512)
-gitlab source: source-is-missing spec/frontend/lib/utils/mock_data.js line length is 2173 characters (>512)
+gitlab source: source-is-missing [spec/fixtures/not_a_png.png]
+gitlab source: source-is-missing [spec/javascripts/lib/utils/mock_data.js]
+gitlab source: source-is-missing [spec/frontend/lib/utils/mock_data.js]
 # encoding data
-gitlab source: source-is-missing vendor/assets/javascripts/xterm/encoding-indexes.js line length is 32697 characters (>512)
+gitlab source: source-is-missing [vendor/assets/javascripts/xterm/encoding-indexes.js]
 # Source is provided by jquery-at.js
-gitlab source: source-is-missing vendor/assets/javascripts/jquery.atwho.js line length is 285 characters (>256)
+gitlab source: source-is-missing [vendor/assets/javascripts/jquery.atwho.js]
 # Source is provided by jquery-caret.js
-gitlab source: source-is-missing vendor/assets/javascripts/jquery.caret.js line length is 538 characters (>512)
+gitlab source: source-is-missing [vendor/assets/javascripts/jquery.caret.js]
 # Source is provided by pdf.js
-gitlab source: source-is-missing vendor/assets/javascripts/pdf.js line length is 695 characters (>512)
-gitlab source: source-is-missing vendor/assets/javascripts/pdf.worker.js line length is 695 characters (>512)
+gitlab source: source-is-missing [vendor/assets/javascripts/pdf.js]
+gitlab source: source-is-missing [vendor/assets/javascripts/pdf.worker.js]
 # Source provided by node-xterm
-gitlab source: source-is-missing vendor/assets/javascripts/xterm/xterm.js line length is 848 characters (>512)
+gitlab source: source-is-missing [vendor/assets/javascripts/xterm/xterm.js]
diff --git a/debian/tests/spec b/debian/tests/spec
index 3efb29a614..b1f20dd7af 100755
--- a/debian/tests/spec
+++ b/debian/tests/spec
@@ -2,15 +2,15 @@
 
 export SOURCE_TREE=${PWD}
 
-if [ -z "$ADTTMP" ]; then
-  ADTTMP=$(mktemp -d)
+if [ -z "$AUTOPKGTEST_TMP" ]; then
+  AUTOPKGTEST_TMP=$(mktemp -d)
   cleanup() {
-    rm -rf "$ADTTMP"
+    rm -rf "$AUTOPKGTEST_TMP"
   }
   trap cleanup INT TERM EXIT
 fi
 
-cd $ADTTMP
+cd $AUTOPKGTEST_TMP
 
 exec 2>&1
 set -ex
diff --git a/debian/upstream/metadata b/debian/upstream/metadata
new file mode 100644
index 0000000000..00e19a6640
--- /dev/null
+++ b/debian/upstream/metadata
@@ -0,0 +1,4 @@
+---
+Bug-Database: https://gitlab.com/gitlab-org/gitlab-foss/-/issues
+Bug-Submit: https://gitlab.com/gitlab-org/gitlab-foss/-/issues/new
+Repository-Browse: https://gitlab.com/gitlab-org/gitlab-foss

Run locally

More details

Full run details

Historical runs

• patch-application-failed: Patch application failed: tweaks/0090-cross-platform-text.patch
• patch-application-failed: Patch application failed: tweaks/0090-cross-platform-text.patch
• worker-timeout: No keepalives received in 1:00:58.695034.
• worker-timeout: No keepalives received in 3:01:48.968096.
• patch-application-failed: Patch application failed: Gemfile/0010-relax-stable-libs.patch
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• patch-application-failed: Patch application failed: tweaks/0090-cross-platform-text.patch
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• unsatisfied-apt-dependencies: Unsatisfied APT dependencies: golang-gitlab-gitlab-org-gitaly-dev:amd64 (>= 15.2~)
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• aborted: Killed by signal
• run-disappeared: Worker started processing new run rather than c9ce0200-03f9-404c-b54b-75de227a9fef
• run-disappeared: Worker started processing new run rather than 4261eec1-d056-429b-accf-bbbc01a327a6
• run-disappeared: Worker started processing new run rather than 0be1618f-dd9d-4b99-a9e4-61a53a1089f4
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• worker-timeout: No keepalives received in 10:20:50.207717.
• worker-failure: ImportError: cannot import name 'MissingBoostComponents' from 'buildlog_consultant.common' (/code/buildlog-consultant/buildlog_consultant/common.py)
• worker-timeout: No keepalives received in 10:00:10.928769.
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• unrepresentable-local-changes: Tree has unrepresentable local changes.
• unrepresentable-local-changes: Tree has unrepresentable local changes.