Lintian Fixes - libminc

Ready changes

Merge these changes:

git pull https://janitor.debian.net/git/libminc lintian-fixes/main

Summary

Diff

diff --git a/debian/changelog b/debian/changelog
index ae90611..d72e7c4 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,18 @@
+libminc (2.4.03-3) UNRELEASED; urgency=medium
+
+  * Trim trailing whitespace.
+  * debian/copyright: use spaces rather than tabs to start continuation
+    lines.
+  * Bump debhelper from old 10 to 12.
+  * Set debhelper-compat version in Build-Depends.
+  * Set upstream metadata fields: Bug-Database, Bug-Submit, Repository,
+    Repository-Browse.
+
+ -- Debian Janitor <janitor@jelmer.uk>  Sat, 25 Apr 2020 07:17:21 +0000
+
 libminc (2.4.03-2) unstable; urgency=medium
 
-  * Team upload 
+  * Team upload
   * d/: Install cmake file in the correct location Closes: #907553
         (locutusofborg)
 
@@ -8,13 +20,13 @@ libminc (2.4.03-2) unstable; urgency=medium
 
 libminc (2.4.03-1) unstable; urgency=medium
 
-  * re-upload to sid 
+  * re-upload to sid
 
  -- Gert Wollny <gewo@debian.org>  Sun, 26 Aug 2018 19:10:28 +0200
 
 libminc (2.4.03-1~exp3) experimental; urgency=medium
 
-  * Team upload 
+  * Team upload
   * d/p/disable: avoid FTBFS on powerpc
 
  -- Gert Wollny <gewo@debian.org>  Thu, 16 Aug 2018 17:46:26 +0200
@@ -36,7 +48,7 @@ libminc (2.4.03-1~exp1) experimental; urgency=medium
   * d/p/remove-rpath: Don't set rpath when installing
   * Correct *.cmake install location
   * d/rules: add -ffloat-store in i386 build to pass tests
-  * d/copyright: Add some contributor names that were missing 
+  * d/copyright: Add some contributor names that were missing
 
  -- Gert Wollny <gewo@debian.org>  Sat, 19 May 2018 22:12:40 +0200
 
@@ -130,7 +142,7 @@ minc (2.2.00-2) unstable; urgency=low
     stricter parsing of perl 5.18.  Closes: #719502.
 
   * rules: disable parallel build; causes tests to fail inexplicably.
-  
+
  -- Steve M. Robbins <smr@debian.org>  Fri, 13 Sep 2013 23:22:53 -0500
 
 minc (2.2.00-1) unstable; urgency=low
@@ -144,7 +156,7 @@ minc (2.2.00-1) unstable; urgency=low
 
   * rules: Use "--with autoreconf" since new patches affect Makefile.am.
 
-  * rules:  
+  * rules:
   * control: SOVERSION bump to 3; new package name libminc2-3.
 
  -- Steve M. Robbins <smr@debian.org>  Sat, 13 Oct 2012 23:09:25 -0500
@@ -152,16 +164,16 @@ minc (2.2.00-1) unstable; urgency=low
 minc (2.1.10-1) unstable; urgency=low
 
   * New upstream.
-  
+
   * patches/03_mincview.diff: Remove.  Script mincview rewritten to use
     Imagemagick
-  
+
   * patches/decompress-whole-file.diff:
   * patches/read_file_names-refactor.patch: Remove.  Applied upstream.
   * rules: Remove use of dh_autoreconf.
 
   * patches/hdfv2-fixes.patch: New.  Ensure using HDF5 v2 API.
-  
+
   * control: Remove dependency and build-dependency on csh.
 
  -- Steve M. Robbins <smr@debian.org>  Sun, 26 Feb 2012 01:37:47 -0600
@@ -172,7 +184,7 @@ minc (2.1.00-5) unstable; urgency=low
   * patches/read_file_names-refactor.patch: New.  Refactored duplicated
     PATH_MAX-using code into library.  Need to run autoreconf because
     Makefile.am changed.
-  
+
   * rules: Fix errors and really disable tests on sparc.
 
  -- Steve M. Robbins <smr@debian.org>  Mon, 20 Feb 2012 15:00:32 -0600
@@ -180,10 +192,10 @@ minc (2.1.00-5) unstable; urgency=low
 minc (2.1.00-4) unstable; urgency=low
 
   * source/format: Set to 3.0 (quilt), so that patches are applied.
-  
+
   * patches/mincaverage-pathmax.patch: New.  Work around missing PATH_MAX
     definition; fixes FTBFS on hurd.
-  
+
   * rules: Tests are buggy, but do work on most architectures.  Disable on
     sparc.
 
@@ -193,7 +205,7 @@ minc (2.1.00-3) unstable; urgency=low
 
   * control: Switch to (serial) libhdf5-dev, to avoid conflict with serial
     netcdf.  Closes: #658307.
-  
+
   * control:
   * rules: Switch from cdbs to debhelper's dh (compat level 9).
 
@@ -216,7 +228,7 @@ minc (2.0.18+cvs20100518-1) unstable; urgency=low
 
   * Pull upstream CVS, contains fixes for netcdf 4.  Closes: #577060,
     #581296.
-  
+
   * control: replace libhdf5-*-dev (differing by architecture) by
     libhdf5-mpi-dev.
 
@@ -234,7 +246,7 @@ minc (2.0.17-1) unstable; urgency=low
 
   * patches/04_manpages.diff:
   * debian/patches/05_parseargv.diff: Remove; applied upstream.
-  
+
  -- Steve M. Robbins <smr@debian.org>  Tue, 20 Jan 2009 19:37:41 -0600
 
 minc (2.0.16-4) unstable; urgency=low
@@ -242,9 +254,9 @@ minc (2.0.16-4) unstable; urgency=low
   * debian/patches/05_parseargv.diff: New.  Patch from upstream to fix arg
     parsing on 64bits.  Closes: #510629.  This was also the root cause of
     mincheader and mincdiff failing.  Closes: #506276.
-  
+
   * debian/control: Add ${misc:Depends}, since we use debhelper.
-  
+
   * debian/rules: Do not install test code acr_test, dicom_test.
 
  -- Steve M. Robbins <smr@debian.org>  Sat, 03 Jan 2009 16:29:06 -0600
@@ -268,7 +280,7 @@ minc (2.0.16-1) unstable; urgency=low
 
   * New upstream release.
     - debian/patches/02_mincedit-no-escape-chars: Remove.  Applied upstream.
-  
+
   * debian/control: Switch dependencies from libhdf5-serial-dev to
     libhdf5-openmpi-dev.
   * debian/rules: Add CFLAGS=-I/usr/include/mpi to configure step so that
@@ -277,10 +289,10 @@ minc (2.0.16-1) unstable; urgency=low
   * debian/control: Remove tetex-bin from build-depends (was alternative
     to texlive-latex-base).  Update Standards-Version to 3.8.0 (no
     changes).
-  
+
   * debian/patches/04_manpages.diff: Fix errors in manpages, mainly
     removal of trailing TAB characters.
-  
+
   * debian/rules: Adhere to parallel keyword in DEB_BUILD_OPTIONS.
 
  -- Steve M. Robbins <smr@debian.org>  Sat, 11 Oct 2008 23:55:42 -0500
@@ -302,12 +314,12 @@ minc (2.0.15-2) unstable; urgency=low
   [ David Paleino ]
   * debian/rules:
     - conditionally add -mieee on Alpha (Closes: #368263)
-  
+
   [ Steve M. Robbins ]
   * debian/rules: Do not run the tests, since they are broken in many
     ways; e.g. int functions without a return statement, checking
     floating-point values without a tolerance, and some that require a
-    list of files on the command line but are given none.  
+    list of files on the command line but are given none.
     Closes: #475808.
 
  -- Steve M. Robbins <smr@debian.org>  Thu, 05 Jun 2008 09:24:59 -0500
@@ -329,7 +341,7 @@ minc (2.0.14-2) unstable; urgency=low
 
   * rules: Don't install byte_swap or extract; can use "dd" instead of
     these tools.  Closes: #459834.
-  
+
   * control: Package minc-tools depends on libgetopt-tabular-perl.
   * rules: Don't install Tabular.pm.
   * Getopt-Tabular-0.3/Tabular.pm: Remove.
@@ -341,21 +353,21 @@ minc (2.0.14-2) unstable; urgency=low
 minc (2.0.14-1) unstable; urgency=low
 
   * New upstream version.  Closes: #450922.
-  
+
   * control: Set Maintainer to debian-med-packaging.
     Add build-depends for libhdf5-serial-dev, texlive-latex-base.
     Rename package libminc0 --> libminc2-1.
     Rename package libminc0-dev --> libminc-dev.
     Package libminc-dev depends on libhdf5-serial-dev.
     Package minc-tools depends on imagemagick.
-  
+
   * rules: Configure with --enable-minc2 and --enable-acr-nema.
 
   * Getopt-Tabular-0.3/Tabular.pm: New.  Perl module required
     for mincpik and xfmflip.  Closes: #457074.
 
   * patches/02_testdir-runtests.diff: New.  Fix test scripts.
-  
+
   * patches/03_mincview.diff: New.  Use 'display' from ImageMagick rather
     than 'xv' to view images.  Closes: #457072.
 
@@ -369,7 +381,7 @@ minc (1.5-2) NEVER UPLOADED; urgency=low
   * Rewrite build system using cdbs.
     - patches/01_mincedit-sensible-viewer.diff: New.  Obtained from
       existing Debian diff.
-  
+
   * control: Build-depend on texlive-latex-base | tetex-bin, rather
     than just tetex-bin.  Update to Standards-Version 3.7.3 (no change
     required).  Use ${binary:Version} rather than ${Source-Version}
@@ -413,7 +425,7 @@ minc (1.4-2) unstable; urgency=low
 minc (1.4-1) unstable; urgency=low
 
   * New upstream version.
-  
+
   * Omit dependency on essential package debianutils (for sensible-editor).
   Closes: #316425.
 
@@ -441,7 +453,7 @@ minc (1.3-1) unstable; urgency=low
   * configure.in: Don't use AC_CONFIG_LINKS to generate link
     volume_io/Include/volume_io to directory volume_io/Include as
     autoconf 2.59 chokes on it.  Use shell commands instead.
-  
+
   * volume_io/Include/internal_volume_io.h: Do not include "config.h".
   * volume_io/Prog_utils/files.c: Do include "config.h".
   * volume_io/Prog_utils/time.c: Restore call to sysconf( _SC_CLK_TCK ),
@@ -485,4 +497,3 @@ minc (1.0-1) unstable; urgency=low
     - progs/mincstats/mincstats.c: fix segfault
 
  -- Steve M. Robbins <smr@debian.org>  Mon, 29 Jul 2002 16:06:56 -0400
-
diff --git a/debian/compat b/debian/compat
deleted file mode 100644
index f599e28..0000000
--- a/debian/compat
+++ /dev/null
@@ -1 +0,0 @@
-10
diff --git a/debian/control b/debian/control
index 4e0de5a..9b4c4a4 100644
--- a/debian/control
+++ b/debian/control
@@ -4,8 +4,8 @@ Uploaders: Steve M. Robbins <smr@debian.org>,
            Andreas Tille <tille@debian.org>
 Section: science
 Priority: optional
-Build-Depends: debhelper (>= 10),
-               dh-exec (>=0.3),
+Build-Depends: debhelper-compat (= 12),
+               dh-exec (>= 0.3),
                cmake,
                libnetcdf-dev,
                libnifti-dev,
@@ -27,7 +27,7 @@ Description: MNI medical image format library
  This package contains the libraries libminc2 and libminc_io.
  .
  The Minc file format is a highly flexible medical image file format.
- Minc version 1 is built on top of the NetCDF generalized data format. 
+ Minc version 1 is built on top of the NetCDF generalized data format.
  Minc version 2 is built on top of the HDF data format.  This library
  handles both formats.  In each case the format is
  simple, self-describing, extensible, portable and N-dimensional, with
@@ -52,7 +52,7 @@ Description: MNI medical image format development environment
  libminc_io.
  .
  The Minc file format is a highly flexible medical image file format.
- Minc version 1 is built on top of the NetCDF generalized data format. 
+ Minc version 1 is built on top of the NetCDF generalized data format.
  Minc version 2 is built on top of the HDF data format.  This library
  handles both formats.  In each case the format is
  simple, self-describing, extensible, portable and N-dimensional, with
diff --git a/debian/copyright b/debian/copyright
index afede8c..1676188 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -7,10 +7,10 @@ Source: http://packages.bic.mni.mcgill.ca/tgz/
 Files: *
 Copyright:1993-1995 David MacDonald
           1993-1994 Peter Neelin
-	  2006-2013 Vladimir Fonov
-	  2003-2004 Robert Vincent 
-	  1993-2013 McConnell Brain Imaging Centre, Montreal Neurological
-	    Institute, McGill University.
+          2006-2013 Vladimir Fonov
+          2003-2004 Robert Vincent 
+          1993-2013 McConnell Brain Imaging Centre, Montreal Neurological
+ 	    Institute, McGill University.
 License: as_is
  Permission to use, copy, modify, and distribute this software and its
  documentation for any purpose and without fee is hereby granted,
diff --git a/debian/rules b/debian/rules
index 2432f3c..cf5db5d 100755
--- a/debian/rules
+++ b/debian/rules
@@ -7,7 +7,7 @@ export DEB_BUILD_MAINT_OPTIONS=hardening=+all
 ifeq ($(DEB_BUILD_ARCH),i386)
   export DEB_CXXFLAGS_MAINT_APPEND=-ffloat-store
   export DEB_CFLAGS_MAINT_APPEND=-ffloat-store
-endif 
+endif
 
 ARCH = $(shell dpkg-architecture -qDEB_TARGET_MULTIARCH)
 
diff --git a/debian/upstream/metadata b/debian/upstream/metadata
new file mode 100644
index 0000000..53f62be
--- /dev/null
+++ b/debian/upstream/metadata
@@ -0,0 +1,4 @@
+Bug-Database: https://github.com/BIC-MNI/libminc/issues
+Bug-Submit: https://github.com/BIC-MNI/libminc/issues/new
+Repository: https://github.com/BIC-MNI/libminc.git
+Repository-Browse: https://github.com/BIC-MNI/libminc

Debdiff

[The following lists of changes regard files as different if they have different names, permissions or owners.]

Files in second set of .debs but not in first

-rw-r--r--  root/root   /usr/lib/debug/.build-id/57/569a134cecb31e4624e49c959417b82cb40ca0.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/9e/c99b387a9cb6ca35a4f4a160545067731c082a.debug
-rw-r--r--  root/root   /usr/lib/debug/.dwz/x86_64-linux-gnu/libminc2-5.2.0.debug

Files in first set of .debs but not in second

-rw-r--r--  root/root   /usr/lib/debug/.build-id/1f/4f26e4025234414be7e413256326be0546a6fa.debug
-rw-r--r--  root/root   /usr/lib/debug/.build-id/95/d9239ed8159c53bf60a66a56b1d72cb0e30ca6.debug

No differences were encountered between the control files of package libminc-dev

No differences were encountered between the control files of package libminc2-5.2.0

Control files of package libminc2-5.2.0-dbgsym: lines which differ (wdiff format)

  • Build-Ids: 1f4f26e4025234414be7e413256326be0546a6fa 95d9239ed8159c53bf60a66a56b1d72cb0e30ca6 57569a134cecb31e4624e49c959417b82cb40ca0 9ec99b387a9cb6ca35a4f4a160545067731c082a

Run locally

Try this locally (using the lintian-brush package):

debcheckout libminc
cd libminc
lintian-brush

More details

Full run details