Lintian Fixes - manila-ui

• QA Page
• Maintainer email: team+openstack@tracker.debian.org
• Automatic publish policy: main: push-derived , pristine-tar: push-derived , upstream: push-derived
• Last processed: 2023-08-17T23:33 (took 11m44s)
• Branch URL: https://salsa.debian.org/openstack-team/horizon-plugins/manila-ui.git -b debian/caracal (taken from version 11.0.0-1)
• Tags that might be fixable: out-of-date-standards-version older-debian-watch-file-standard debian-watch-does-not-check-openpgp-signature silent-on-rules-requiring-root
• Queue position: 163537 (a 96w3d wait)

Schedule a new run

Recent merge proposals

• https://salsa.debian.org/openstack-team/horizon-plugins/manila-ui/-/merge_requests/2 (open)

Ready changes

Publish now

Summary

• Bump debhelper from old 11 to 13. ( package-uses-old-debhelper-compat-version )
• Set upstream metadata fields: Repository-Browse. ( upstream-metadata-file-is-missing )

Lintian Result

• manila-ui_9.0.0-4~jan+lint1.dsc
• manila-ui_9.0.0-4~jan+lint1_amd64.buildinfo
• python3-manila-ui_9.0.0-4~jan+lint1_all.deb
• manila-ui_9.0.0-4~jan+lint1_amd64.changes

Diff

diff --git a/debian/changelog b/debian/changelog
index 652956b..1705793 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,15 @@
+manila-ui (9.0.0-4) UNRELEASED; urgency=medium
+
+  * Bump debhelper from old 11 to 13.
+    + Drop check for DEB_BUILD_OPTIONS containing "nocheck", since debhelper now
+      does this.
+    + Replace python_distutils buildsystem with pybuild.
+    + debian/rules: Drop --fail-missing argument to dh_missing, which is now the
+      default.
+  * Set upstream metadata fields: Repository-Browse.
+
+ -- Debian Janitor <janitor@jelmer.uk>  Thu, 17 Aug 2023 23:22:11 -0000
+
 manila-ui (9.0.0-3) unstable; urgency=medium
 
   * Cleans better (Closes: #1046384).
diff --git a/debian/control b/debian/control
index 015d400..df2e60e 100644
--- a/debian/control
+++ b/debian/control
@@ -6,7 +6,7 @@ Uploaders:
  Thomas Goirand <zigo@debian.org>,
  Michal Arbet <michal.arbet@ultimum.io>,
 Build-Depends:
- debhelper-compat (= 11),
+ debhelper-compat (= 13),
  dh-python,
  openstack-pkg-tools,
  python3-all,
diff --git a/debian/rules b/debian/rules
index e7b1627..2c4ca01 100755
--- a/debian/rules
+++ b/debian/rules
@@ -3,7 +3,7 @@
 include /usr/share/openstack-pkg-tools/pkgos.make
 
 %:
-	dh $@ --buildsystem=python_distutils --with python3
+	dh $@ --buildsystem=pybuild --with python3
 
 override_dh_auto_clean:
 	rm -rf build .stestr *.egg-info .coverage
@@ -32,10 +32,9 @@ override_dh_install:
 	cp $(CURDIR)/debian/tmp/usr/lib/python3/dist-packages/manila_ui/local/local_settings.d/_[0-9]*.py $(CURDIR)/debian/tmp/etc/openstack-dashboard/local_settings.d/
 
 	dh_install
-	dh_missing --fail-missing
+	dh_missing
 
 override_dh_auto_test:
-ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
 	set -e ; for i in $(PYTHON3S) ; do \
 		PYTHON=python3 PYTHONPATH=$(CURDIR)/debian/tmp/usr/lib/python3/dist-packages \
 			DJANGO_SETTINGS_MODULE=manila_ui.tests.settings \
@@ -44,4 +43,3 @@ ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
 	done
 	## Delete __pycache__
 	find . -name __pycache__ -prune -exec rm -rf {} +;
-endif
diff --git a/debian/upstream/metadata b/debian/upstream/metadata
new file mode 100644
index 0000000..67576f8
--- /dev/null
+++ b/debian/upstream/metadata
@@ -0,0 +1,2 @@
+---
+Repository-Browse: https://github.com/openstack/manila-ui

Debdiff

File lists identical (after any substitutions)

No differences were encountered in the control files

Run locally

More details

Full run details