Lintian Fixes - osmo-trx

Ready changes

Merge these changes:

git pull https://janitor.debian.net/git/osmo-trx lintian-fixes/main

Summary

Diff

diff --git a/debian/changelog b/debian/changelog
index 7c0ab15..513e1bd 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+osmo-trx (1.2.0-3) UNRELEASED; urgency=medium
+
+  * Drop unnecessary dependency on dh-autoreconf.
+  * Add patch ac-path-pkgconfig.patch: Use cross-build compatible macro for
+    finding pkg-config.
+
+ -- Debian Janitor <janitor@jelmer.uk>  Sun, 17 Jan 2021 02:42:29 -0000
+
 osmo-trx (1.2.0-2) unstable; urgency=medium
 
   * upload to unstable
diff --git a/debian/patches/ac-path-pkgconfig.patch b/debian/patches/ac-path-pkgconfig.patch
new file mode 100644
index 0000000..04b2282
--- /dev/null
+++ b/debian/patches/ac-path-pkgconfig.patch
@@ -0,0 +1,24 @@
+Description: Use cross-build compatible macro for finding pkg-config.
+ .
+ The package uses AC_PATH_PROG to discover the location of pkg-config(1). This
+ macro fails to select the correct version to support cross-compilation.
+ .
+ This patch changes it to use AC_PATH_TOOL.
+ .
+ Refer to https://bugs.debian.org/884798 for details.
+Origin: other
+Last-Update: 2021-01-17
+
+=== modified file 'configure.ac'
+--- a/configure.ac	2020-08-17 19:05:12 +0000
++++ b/configure.ac	2021-01-17 02:43:48 +0000
+@@ -52,7 +52,7 @@
+ AC_LANG([C++])
+ 
+ dnl check for pkg-config (explained in detail in libosmocore/configure.ac)
+-AC_PATH_PROG(PKG_CONFIG_INSTALLED, pkg-config, no)
++AC_PATH_TOOL(PKG_CONFIG_INSTALLED, pkg-config, no)
+ if test "x$PKG_CONFIG_INSTALLED" = "xno"; then
+         AC_MSG_WARN([You need to install pkg-config])
+ fi
+
diff --git a/debian/patches/series b/debian/patches/series
index e69de29..cb99cc8 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -0,0 +1 @@
+ac-path-pkgconfig.patch
diff --git a/debian/rules b/debian/rules
index 173f992..cd2aec8 100755
--- a/debian/rules
+++ b/debian/rules
@@ -9,7 +9,7 @@ export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 
 %:
-	dh $@ --with autoreconf
+	dh $@
 
 
 override_dh_auto_clean:

Debdiff

File lists identical (after any substitutions)

No differences were encountered between the control files of package osmo-trx

No differences were encountered between the control files of package osmo-trx-dbgsym

Run locally

Try this locally (using the lintian-brush package):

debcheckout osmo-trx
cd osmo-trx
lintian-brush

More details

Full run details