New Upstream Release - ruby-rubocop-packaging

Ready changes

Summary

Merged new upstream version: 0.5.2 (was: 0.5.1).

Resulting package

Built on 2022-12-29T15:34 (took 6m20s)

The resulting binary packages can be installed (if you have the apt repository enabled) by running one of:

apt install -t fresh-releases ruby-rubocop-packaging

Lintian Result

Diff

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
new file mode 100644
index 0000000..7440064
--- /dev/null
+++ b/.github/workflows/ci.yml
@@ -0,0 +1,23 @@
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: ["2.6", "2.7", "3.0", "3.1", ruby-head]
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        bundler-cache: true # 'bundle install' and cache gems
+        ruby-version: ${{ matrix.ruby }}
+    - name: Run tests
+      run: bundle exec rake
diff --git a/.rubocop.yml b/.rubocop.yml
index de56b9d..edaa007 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -3,12 +3,13 @@ require:
 
 AllCops:
   NewCops: enable
+  SuggestExtensions: false
   Exclude:
     - '.bundle/**/*'
     - 'spec/fixtures/**/*'
     - 'tmp/**/*'
     - 'vendor/**/*'
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.6
 
 Naming/FileName:
   Exclude:
@@ -17,7 +18,7 @@ Naming/FileName:
 Metrics/BlockLength:
   Exclude:
     - tasks/*.rake
-  ExcludedMethods:
+  IgnoredMethods:
     - configure
     - describe
     - context
diff --git a/.travis.yml b/.travis.yml
index a97fbe7..d3d9739 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -6,6 +6,7 @@ rvm:
   - 2.5.8
   - 2.6.6
   - 2.7.2
+  - 3.0.0
   - ruby-head
 allow_failures:
   - ruby-head
diff --git a/debian/changelog b/debian/changelog
index 0863e0c..e3d0312 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+ruby-rubocop-packaging (0.5.2-1) UNRELEASED; urgency=low
+
+  * New upstream release.
+
+ -- Debian Janitor <janitor@jelmer.uk>  Thu, 29 Dec 2022 15:28:55 -0000
+
 ruby-rubocop-packaging (0.5.1-1) unstable; urgency=medium
 
   * New upstream version 0.5.1
diff --git a/lib/rubocop/cop/packaging/gemspec_git.rb b/lib/rubocop/cop/packaging/gemspec_git.rb
index 4cb5471..7b2ecdc 100644
--- a/lib/rubocop/cop/packaging/gemspec_git.rb
+++ b/lib/rubocop/cop/packaging/gemspec_git.rb
@@ -11,14 +11,12 @@ module RuboCop # :nodoc:
       #
       #   # bad
       #   Gem::Specification.new do |spec|
-      #     spec.files         = `git ls-files`.split("\n")
-      #     spec.test_files    = `git ls-files -- spec`.split("\n")
+      #     spec.files = `git ls-files`.split("\n")
       #   end
       #
       #   # good
       #   Gem::Specification.new do |spec|
-      #     spec.files         = Dir["lib/**/*", "LICENSE", "README.md"]
-      #     spec.test_files    = Dir["spec/**/*"]
+      #     spec.files = Dir["lib/**/*", "LICENSE", "README.md"]
       #   end
       #
       #   # bad
@@ -32,21 +30,19 @@ module RuboCop # :nodoc:
       #   require "rake/file_list"
       #
       #   Gem::Specification.new do |spec|
-      #     spec.files         = Rake::FileList["**/*"].exclude(*File.read(".gitignore").split)
+      #     spec.files = Rake::FileList["**/*"].exclude(*File.read(".gitignore").split)
       #   end
       #
       #   # bad
       #   Gem::Specification.new do |spec|
-      #     spec.files         = `git ls-files -- lib/`.split("\n")
-      #     spec.test_files    = `git ls-files -- test/{functional,unit}/*`.split("\n")
-      #     spec.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+      #     spec.files        = `git ls-files -- lib/`.split("\n")
+      #     spec.executables  = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
       #   end
       #
       #   # good
       #   Gem::Specification.new do |spec|
-      #     spec.files         = Dir.glob("lib/**/*")
-      #     spec.test_files    = Dir.glob("test/{functional,test}/*")
-      #     spec.executables   = Dir.glob("bin/*").map{ |f| File.basename(f) }
+      #     spec.files        = Dir.glob("lib/**/*")
+      #     spec.executables  = Dir.glob("bin/*").map{ |f| File.basename(f) }
       #   end
       #
       class GemspecGit < Base
diff --git a/lib/rubocop/packaging/lib_helper_module.rb b/lib/rubocop/packaging/lib_helper_module.rb
index a9ba700..ecd5ad4 100644
--- a/lib/rubocop/packaging/lib_helper_module.rb
+++ b/lib/rubocop/packaging/lib_helper_module.rb
@@ -7,7 +7,7 @@ module RuboCop # :nodoc:
     module LibHelperModule
       # For determining the root directory of the project.
       def root_dir
-        RuboCop::ConfigLoader.project_root
+        RuboCop::ConfigFinder.project_root
       end
 
       # This method determines if the calls are made to the "lib" directory.
diff --git a/lib/rubocop/packaging/version.rb b/lib/rubocop/packaging/version.rb
index 4aab827..13da248 100644
--- a/lib/rubocop/packaging/version.rb
+++ b/lib/rubocop/packaging/version.rb
@@ -2,6 +2,6 @@
 
 module RuboCop
   module Packaging
-    VERSION = "0.5.1"
+    VERSION = "0.5.2"
   end
 end
diff --git a/rubocop-packaging.gemspec b/rubocop-packaging.gemspec
index ed89dca..7d527f3 100644
--- a/rubocop-packaging.gemspec
+++ b/rubocop-packaging.gemspec
@@ -9,24 +9,25 @@ Gem::Specification.new do |spec|
   spec.email         = ["utkarsh@debian.org"]
   spec.license       = "MIT"
   spec.homepage      = "https://github.com/utkarsh2102/rubocop-packaging"
-  spec.summary       = "Automatic downstream compatability checking tool for Ruby code"
+  spec.summary       = "Automatic downstream compatibility checking tool for Ruby code"
   spec.description   = <<~DESCRIPTION
-    A collection of RuboCop cops to check for downstream compatability issues in the
+    A collection of RuboCop cops to check for downstream compatibility issues in the
     Ruby code.
   DESCRIPTION
 
   spec.metadata["homepage_uri"]    = spec.homepage
   spec.metadata["source_code_uri"] = "https://github.com/utkarsh2102/rubocop-packaging"
+  spec.metadata["rubygems_mfa_required"] = "true"
 
   spec.files         = Dir["config/default.yml", "lib/**/*", "LICENSE", "README.md"]
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = Gem::Requirement.new(">= 2.4.0")
+  spec.required_ruby_version = Gem::Requirement.new(">= 2.6.0")
 
   spec.add_development_dependency   "bump", "~> 0.8"
   spec.add_development_dependency   "pry", "~> 0.13"
   spec.add_development_dependency   "rake", "~> 13.0"
   spec.add_development_dependency   "rspec", "~> 3.0"
   spec.add_development_dependency   "yard", "~> 0.9"
-  spec.add_runtime_dependency       "rubocop", ">= 0.89", "< 2.0"
+  spec.add_runtime_dependency       "rubocop", ">= 1.33", "< 2.0"
 end
diff --git a/spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb b/spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb
index c66b788..e10c1d2 100644
--- a/spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb
+++ b/spec/rubocop/cop/packaging/bundler_setup_in_tests_spec.rb
@@ -3,7 +3,7 @@
 RSpec.describe RuboCop::Cop::Packaging::BundlerSetupInTests, :config do
   let(:message) { RuboCop::Cop::Packaging::BundlerSetupInTests::MSG }
 
-  let(:project_root) { RuboCop::ConfigLoader.project_root }
+  let(:project_root) { RuboCop::ConfigFinder.project_root }
 
   context "when `require bundler/setup` is used in specs/" do
     let(:filename) { "#{project_root}/spec/spec_helper.rb" }
@@ -15,8 +15,7 @@ RSpec.describe RuboCop::Cop::Packaging::BundlerSetupInTests, :config do
         #{"^" * source.length} #{message}
       RUBY
 
-      expect_correction(<<~RUBY)
-      RUBY
+      expect_correction("")
     end
   end
 
@@ -30,8 +29,7 @@ RSpec.describe RuboCop::Cop::Packaging::BundlerSetupInTests, :config do
         #{"^" * source.length} #{message}
       RUBY
 
-      expect_correction(<<~RUBY)
-      RUBY
+      expect_correction("")
     end
   end
 
diff --git a/spec/rubocop/cop/packaging/gemspec_git_spec.rb b/spec/rubocop/cop/packaging/gemspec_git_spec.rb
index bc9a955..dc0c1fd 100644
--- a/spec/rubocop/cop/packaging/gemspec_git_spec.rb
+++ b/spec/rubocop/cop/packaging/gemspec_git_spec.rb
@@ -79,8 +79,7 @@ RSpec.describe RuboCop::Cop::Packaging::GemspecGit do
   end
 
   it "does not register an offense when the file is empty/blank" do
-    expect_no_offenses(<<~RUBY)
-    RUBY
+    expect_no_offenses("")
   end
 
   it "does not register an offense not in a specification" do
diff --git a/spec/rubocop/cop/packaging/require_hardcoding_lib_spec.rb b/spec/rubocop/cop/packaging/require_hardcoding_lib_spec.rb
index a32afac..0e0c3d8 100644
--- a/spec/rubocop/cop/packaging/require_hardcoding_lib_spec.rb
+++ b/spec/rubocop/cop/packaging/require_hardcoding_lib_spec.rb
@@ -3,7 +3,7 @@
 RSpec.describe RuboCop::Cop::Packaging::RequireHardcodingLib, :config do
   let(:message) { RuboCop::Cop::Packaging::RequireHardcodingLib::MSG }
 
-  let(:project_root) { RuboCop::ConfigLoader.project_root }
+  let(:project_root) { RuboCop::ConfigFinder.project_root }
 
   context "when `require` call lies outside spec/" do
     let(:filename) { "#{project_root}/spec/foo_spec.rb" }
diff --git a/spec/rubocop/cop/packaging/require_relative_hardcoding_lib_spec.rb b/spec/rubocop/cop/packaging/require_relative_hardcoding_lib_spec.rb
index 85868b4..02b69fc 100644
--- a/spec/rubocop/cop/packaging/require_relative_hardcoding_lib_spec.rb
+++ b/spec/rubocop/cop/packaging/require_relative_hardcoding_lib_spec.rb
@@ -3,7 +3,7 @@
 RSpec.describe RuboCop::Cop::Packaging::RequireRelativeHardcodingLib, :config do
   let(:message) { RuboCop::Cop::Packaging::RequireRelativeHardcodingLib::MSG }
 
-  let(:project_root) { RuboCop::ConfigLoader.project_root }
+  let(:project_root) { RuboCop::ConfigFinder.project_root }
 
   context "when `require_relative` call lies outside spec/" do
     let(:filename) { "#{project_root}/spec/foo_spec.rb" }
diff --git a/spec/rubocop/packaging_spec.rb b/spec/rubocop/packaging_spec.rb
index 043fba7..9064820 100644
--- a/spec/rubocop/packaging_spec.rb
+++ b/spec/rubocop/packaging_spec.rb
@@ -50,8 +50,7 @@ RSpec.describe RuboCop::Packaging do
       end
     end
 
-    it "has a SupportedStyles for all EnforcedStyle " \
-      "and EnforcedStyle is valid" do
+    it "has a SupportedStyles for all EnforcedStyle and EnforcedStyle is valid" do
       errors = []
       cop_names.each do |name|
         enforced_styles = config[name]
diff --git a/tasks/cops_documentation.rake b/tasks/cops_documentation.rake
index 43ed3df..6e76f6c 100644
--- a/tasks/cops_documentation.rake
+++ b/tasks/cops_documentation.rake
@@ -25,8 +25,7 @@ task verify_cops_documentation: :generate_cops_documentation do
     # Output diff before raising error
     sh("GIT_PAGER=cat git diff docs")
 
-    warn "The docs directory is out of sync. " \
-      "Run `rake generate_cops_documentation` and commit the results."
+    warn "The docs directory is out of sync. Run `rake generate_cops_documentation` and commit the results."
     exit!
   end
 end

Debdiff

[The following lists of changes regard files as different if they have different names, permissions or owners.]

Files in second set of .debs but not in first

-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.2/config/default.yml
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.2/lib/rubocop-packaging.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.2/lib/rubocop/cop/packaging/bundler_setup_in_tests.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.2/lib/rubocop/cop/packaging/gemspec_git.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.2/lib/rubocop/cop/packaging/require_hardcoding_lib.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.2/lib/rubocop/cop/packaging/require_relative_hardcoding_lib.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.2/lib/rubocop/cop/packaging_cops.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.2/lib/rubocop/packaging.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.2/lib/rubocop/packaging/inject.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.2/lib/rubocop/packaging/lib_helper_module.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.2/lib/rubocop/packaging/version.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/specifications/rubocop-packaging-0.5.2.gemspec

Files in first set of .debs but not in second

-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.1/config/default.yml
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.1/lib/rubocop-packaging.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.1/lib/rubocop/cop/packaging/bundler_setup_in_tests.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.1/lib/rubocop/cop/packaging/gemspec_git.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.1/lib/rubocop/cop/packaging/require_hardcoding_lib.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.1/lib/rubocop/cop/packaging/require_relative_hardcoding_lib.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.1/lib/rubocop/cop/packaging_cops.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.1/lib/rubocop/packaging.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.1/lib/rubocop/packaging/inject.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.1/lib/rubocop/packaging/lib_helper_module.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/gems/rubocop-packaging-0.5.1/lib/rubocop/packaging/version.rb
-rw-r--r--  root/root   /usr/share/rubygems-integration/all/specifications/rubocop-packaging-0.5.1.gemspec

Control files: lines which differ (wdiff format)

  • Depends: rubocop (>= 0.89), 1.33), rubocop (<< 2.0)
  • Ruby-Versions: all

More details

Full run details