Codebase list mtr / debian/0.85-1 SECURITY
debian/0.85-1

Tree @debian/0.85-1 (Download .tar.gz)

SECURITY @debian/0.85-1raw · history · blame

SECURITY ISSUES RELATED TO MTR

You can limit mtr usage to the root user by not putting a setuid bit
on the mtr binary. In that case, the security implications are
minimal. 

Or you can make mtr setuid-root, and the following applies to you....

Since mtr is installed as suid-root, some concern over security is
justified.  Since version 0.21 of mtr, does the following two things
after it is launched:

*  mtr requests a pair of raw sockets from the kernel.  
*  mtr sets the effective uid to match the real uid.

See main() in mtr.c and net_preopen() in net.c for the details of this
process.  Note that no code from GTK+ or curses is executed before the
drop in permissions.

This should severely limit the possibilities of using mtr to breach
system security.  This means the worst case scenerio is as follows:

Due to some oversight in the mtr code, a malicious user is able to
overrun one of mtr's internal buffers with binary code that is
eventually executed.  The malicious user is still not able to read
from or write to any system files which they wouldn't normally have
permission to write to.  The only priveledge gained is access to the
raw socket descriptors, which would allow the malicious user to listen
to all ICMP packets arriving at the system, and send forged packets
with arbitrary contents.

The mtr-code does its best to prevent calling of external library
code before dropping privileges. It seems that C++ library code has 
the ability to issue a "please execute me before calling main" to the
loader/linker.  That would mean that we're still vulnerable to 
errors in that code. This is why I would prefer to drop the backends, 
have mtr-core always run in "raw" mode, and have the backends interpret
the output from the mtr-core. Maybe a nice project for a college-level
student. 

If you have further questions or comments about security issues,
please direct them to the mtr mailing list.  See README for details.